Make CMS startup more asynchronous
authorMathieu Baudier <mbaudier@argeo.org>
Sun, 4 Feb 2018 14:07:06 +0000 (15:07 +0100)
committerMathieu Baudier <mbaudier@argeo.org>
Sun, 4 Feb 2018 14:07:06 +0000 (15:07 +0100)
14 files changed:
org.argeo.cms/src/org/argeo/cms/internal/http/CmsSessionProvider.java
org.argeo.cms/src/org/argeo/cms/internal/http/DataHttpContext.java
org.argeo.cms/src/org/argeo/cms/internal/http/HttpUtils.java
org.argeo.cms/src/org/argeo/cms/internal/http/LinkServlet.java
org.argeo.cms/src/org/argeo/cms/internal/http/NodeHttp.java [deleted file]
org.argeo.cms/src/org/argeo/cms/internal/http/PrivateHttpContext.java
org.argeo.cms/src/org/argeo/cms/internal/http/RobotServlet.java
org.argeo.cms/src/org/argeo/cms/internal/http/client/SpnegoAuthScheme.java
org.argeo.cms/src/org/argeo/cms/internal/kernel/Activator.java
org.argeo.cms/src/org/argeo/cms/internal/kernel/CmsDeployment.java
org.argeo.cms/src/org/argeo/cms/internal/kernel/KernelUtils.java
org.argeo.cms/src/org/argeo/cms/internal/kernel/NodeHttp.java [new file with mode: 0644]
org.argeo.cms/src/org/argeo/cms/internal/kernel/NodeLogger.java
org.argeo.cms/src/org/argeo/cms/internal/kernel/NodeUserAdmin.java

index 4f0c184dbc1b392031b3150a4aa7e8a2b72ccde1..943decaf8a61e19376c7b32d8df04fa887e08d47 100644 (file)
@@ -19,7 +19,7 @@ import org.argeo.jcr.JcrUtils;
  * Implements an open session in view patter: a new JCR session is created for
  * each request
  */
-class CmsSessionProvider implements SessionProvider, Serializable {
+public class CmsSessionProvider implements SessionProvider, Serializable {
        private static final long serialVersionUID = -1358136599534938466L;
 
        private final static Log log = LogFactory.getLog(CmsSessionProvider.class);
index b7a8d0f9e8684bee8ef6fede0779dbd0d7b14bd7..93f63530e3edfa9709f13ec4b089633230ceb9b2 100644 (file)
@@ -16,7 +16,7 @@ import org.osgi.framework.BundleContext;
 import org.osgi.framework.FrameworkUtil;
 import org.osgi.service.http.HttpContext;
 
-class DataHttpContext implements HttpContext {
+public class DataHttpContext implements HttpContext {
        private final static Log log = LogFactory.getLog(DataHttpContext.class);
 
        private final BundleContext bc = FrameworkUtil.getBundle(getClass()).getBundleContext();
index efa2d661aadeb9d75c7cf12155e6945dacb551bb..58d9324ec7b67e498ac9c34dc17cc8de9dffb3f3 100644 (file)
@@ -6,12 +6,12 @@ import javax.servlet.http.HttpServletRequest;
 
 import org.apache.commons.logging.Log;
 
-class HttpUtils {
-       final static String HEADER_AUTHORIZATION = "Authorization";
-       final static String HEADER_WWW_AUTHENTICATE = "WWW-Authenticate";
+public class HttpUtils {
+       public final static String HEADER_AUTHORIZATION = "Authorization";
+       public final static String HEADER_WWW_AUTHENTICATE = "WWW-Authenticate";
 
-       final static String DEFAULT_PROTECTED_HANDLERS = "/org/argeo/cms/internal/http/protectedHandlers.xml";
-       final static String WEBDAV_CONFIG = "/org/argeo/cms/internal/http/webdav-config.xml";
+       public final static String DEFAULT_PROTECTED_HANDLERS = "/org/argeo/cms/internal/http/protectedHandlers.xml";
+       public final static String WEBDAV_CONFIG = "/org/argeo/cms/internal/http/webdav-config.xml";
 
        static boolean isBrowser(String userAgent) {
                return userAgent.contains("webkit") || userAgent.contains("gecko") || userAgent.contains("firefox")
@@ -19,7 +19,7 @@ class HttpUtils {
                                || userAgent.contains("opera") || userAgent.contains("browser");
        }
 
-       static void logRequestHeaders(Log log, HttpServletRequest request) {
+       public static void logRequestHeaders(Log log, HttpServletRequest request) {
                if (!log.isDebugEnabled())
                        return;
                for (Enumeration<String> headerNames = request.getHeaderNames(); headerNames.hasMoreElements();) {
@@ -30,7 +30,7 @@ class HttpUtils {
                log.debug(request.getRequestURI() + "\n");
        }
 
-       static void logRequest(Log log,HttpServletRequest request) {
+       public static void logRequest(Log log,HttpServletRequest request) {
                log.debug("contextPath=" + request.getContextPath());
                log.debug("servletPath=" + request.getServletPath());
                log.debug("requestURI=" + request.getRequestURI());
index d77e39cb9edf4de9ed19661e15b9d2455d89051c..34bdcaa176587558bed883d067877db7a467c7cf 100644 (file)
@@ -34,7 +34,7 @@ import org.osgi.framework.BundleContext;
 import org.osgi.framework.FrameworkUtil;
 import org.osgi.framework.ServiceReference;
 
-class LinkServlet extends HttpServlet {
+public class LinkServlet extends HttpServlet {
        private final BundleContext bc = FrameworkUtil.getBundle(getClass()).getBundleContext();
 
        private static final long serialVersionUID = 3749990143146845708L;
diff --git a/org.argeo.cms/src/org/argeo/cms/internal/http/NodeHttp.java b/org.argeo.cms/src/org/argeo/cms/internal/http/NodeHttp.java
deleted file mode 100644 (file)
index 4cc0b55..0000000
+++ /dev/null
@@ -1,329 +0,0 @@
-package org.argeo.cms.internal.http;
-
-import java.io.IOException;
-import java.nio.file.Files;
-import java.nio.file.Path;
-import java.util.Properties;
-
-import javax.jcr.Repository;
-import javax.servlet.ServletException;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-import org.apache.jackrabbit.server.SessionProvider;
-import org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet;
-import org.apache.jackrabbit.webdav.simple.SimpleWebdavServlet;
-import org.argeo.cms.CmsException;
-import org.argeo.cms.internal.kernel.KernelConstants;
-import org.argeo.node.NodeConstants;
-import org.osgi.framework.BundleContext;
-import org.osgi.framework.FrameworkUtil;
-import org.osgi.framework.ServiceReference;
-import org.osgi.service.http.HttpService;
-import org.osgi.service.http.NamespaceException;
-import org.osgi.util.tracker.ServiceTracker;
-
-/**
- * Intercepts and enriches http access, mainly focusing on security and
- * transactionality.
- */
-public class NodeHttp implements KernelConstants {
-       private final static Log log = LogFactory.getLog(NodeHttp.class);
-
-       public final static String DEFAULT_SERVICE = "HTTP";
-
-       private final BundleContext bc = FrameworkUtil.getBundle(getClass()).getBundleContext();
-
-       private ServiceTracker<Repository, Repository> repositories;
-       private final ServiceTracker<HttpService, HttpService> httpServiceTracker;
-
-       private String httpRealm = "Argeo";
-
-       public NodeHttp() {
-               httpServiceTracker = new PrepareHttpStc();
-               httpServiceTracker.open();
-       }
-
-       public void destroy() {
-               if (repositories != null)
-                       repositories.close();
-       }
-
-       void registerRepositoryServlets(HttpService httpService, String alias, Repository repository) {
-               if (httpService == null)
-                       throw new CmsException("No HTTP service available");
-               try {
-                       registerWebdavServlet(httpService, alias, repository);
-                       registerRemotingServlet(httpService, alias, repository);
-                       if (NodeConstants.HOME.equals(alias))
-                               registerFilesServlet(httpService, alias, repository);
-                       if (log.isDebugEnabled())
-                               log.debug("Registered servlets for repository '" + alias + "'");
-               } catch (Exception e) {
-                       throw new CmsException("Could not register servlets for repository '" + alias + "'", e);
-               }
-       }
-
-       void unregisterRepositoryServlets(HttpService httpService, String alias) {
-               if (httpService == null)
-                       return;
-               try {
-                       httpService.unregister(webdavPath(alias));
-                       httpService.unregister(remotingPath(alias));
-                       if (NodeConstants.HOME.equals(alias))
-                               httpService.unregister(filesPath(alias));
-                       if (log.isDebugEnabled())
-                               log.debug("Unregistered servlets for repository '" + alias + "'");
-               } catch (Exception e) {
-                       log.error("Could not unregister servlets for repository '" + alias + "'", e);
-               }
-       }
-
-       void registerWebdavServlet(HttpService httpService, String alias, Repository repository)
-                       throws NamespaceException, ServletException {
-               // WebdavServlet webdavServlet = new WebdavServlet(repository, new
-               // OpenInViewSessionProvider(alias));
-               WebdavServlet webdavServlet = new WebdavServlet(repository, new CmsSessionProvider(alias));
-               String path = webdavPath(alias);
-               Properties ip = new Properties();
-               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_CONFIG, HttpUtils.WEBDAV_CONFIG);
-               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_PATH_PREFIX, path);
-               httpService.registerServlet(path, webdavServlet, ip, new DataHttpContext(httpRealm));
-       }
-
-       void registerFilesServlet(HttpService httpService, String alias, Repository repository)
-                       throws NamespaceException, ServletException {
-               WebdavServlet filesServlet = new WebdavServlet(repository, new CmsSessionProvider(alias));
-               String path = filesPath(alias);
-               Properties ip = new Properties();
-               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_CONFIG, HttpUtils.WEBDAV_CONFIG);
-               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_PATH_PREFIX, path);
-               httpService.registerServlet(path, filesServlet, ip, new PrivateHttpContext(httpRealm, true));
-       }
-
-       void registerRemotingServlet(HttpService httpService, String alias, Repository repository)
-                       throws NamespaceException, ServletException {
-               RemotingServlet remotingServlet = new RemotingServlet(repository, new CmsSessionProvider(alias));
-               String path = remotingPath(alias);
-               Properties ip = new Properties();
-               ip.setProperty(JcrRemotingServlet.INIT_PARAM_RESOURCE_PATH_PREFIX, path);
-               ip.setProperty(JcrRemotingServlet.INIT_PARAM_AUTHENTICATE_HEADER, "Negotiate");
-
-               // Looks like a bug in Jackrabbit remoting init
-               Path tmpDir;
-               try {
-                       tmpDir = Files.createTempDirectory("remoting_" + alias);
-               } catch (IOException e) {
-                       throw new CmsException("Cannot create temp directory for remoting servlet", e);
-               }
-               ip.setProperty(RemotingServlet.INIT_PARAM_HOME, tmpDir.toString());
-               ip.setProperty(RemotingServlet.INIT_PARAM_TMP_DIRECTORY, "remoting_" + alias);
-               ip.setProperty(RemotingServlet.INIT_PARAM_PROTECTED_HANDLERS_CONFIG, HttpUtils.DEFAULT_PROTECTED_HANDLERS);
-               ip.setProperty(RemotingServlet.INIT_PARAM_CREATE_ABSOLUTE_URI, "false");
-               httpService.registerServlet(path, remotingServlet, ip, new PrivateHttpContext(httpRealm));
-       }
-
-       private String webdavPath(String alias) {
-               return NodeConstants.PATH_DATA + "/" + alias;
-       }
-
-       private String remotingPath(String alias) {
-               return NodeConstants.PATH_JCR + "/" + alias;
-       }
-
-       private String filesPath(String alias) {
-               return NodeConstants.PATH_FILES;
-       }
-
-       // private Subject subjectFromRequest(HttpServletRequest request,
-       // HttpServletResponse response) {
-       // Authorization authorization = (Authorization)
-       // request.getAttribute(HttpContext.AUTHORIZATION);
-       // if (authorization == null)
-       // throw new CmsException("Not authenticated");
-       // try {
-       // LoginContext lc = new LoginContext(NodeConstants.LOGIN_CONTEXT_USER,
-       // new HttpRequestCallbackHandler(request, response));
-       // lc.login();
-       // return lc.getSubject();
-       // } catch (LoginException e) {
-       // throw new CmsException("Cannot login", e);
-       // }
-       // }
-
-       private class RepositoriesStc extends ServiceTracker<Repository, Repository> {
-               private final HttpService httpService;
-
-               public RepositoriesStc(HttpService httpService) {
-                       super(bc, Repository.class, null);
-                       this.httpService = httpService;
-               }
-
-               @Override
-               public Repository addingService(ServiceReference<Repository> reference) {
-                       Repository repository = bc.getService(reference);
-                       Object jcrRepoAlias = reference.getProperty(NodeConstants.CN);
-                       if (jcrRepoAlias != null) {
-                               String alias = jcrRepoAlias.toString();
-                               registerRepositoryServlets(httpService, alias, repository);
-                       }
-                       return repository;
-               }
-
-               @Override
-               public void modifiedService(ServiceReference<Repository> reference, Repository service) {
-               }
-
-               @Override
-               public void removedService(ServiceReference<Repository> reference, Repository service) {
-                       Object jcrRepoAlias = reference.getProperty(NodeConstants.CN);
-                       if (jcrRepoAlias != null) {
-                               String alias = jcrRepoAlias.toString();
-                               unregisterRepositoryServlets(httpService, alias);
-                       }
-               }
-       }
-
-       private class PrepareHttpStc extends ServiceTracker<HttpService, HttpService> {
-               // private DataHttp dataHttp;
-               // private NodeHttp nodeHttp;
-
-               public PrepareHttpStc() {
-                       super(bc, HttpService.class, null);
-               }
-
-               @Override
-               public HttpService addingService(ServiceReference<HttpService> reference) {
-                       HttpService httpService = addHttpService(reference);
-                       return httpService;
-               }
-
-               @Override
-               public void removedService(ServiceReference<HttpService> reference, HttpService service) {
-                       // if (dataHttp != null)
-                       // dataHttp.destroy();
-                       // dataHttp = null;
-                       // if (nodeHttp != null)
-                       // nodeHttp.destroy();
-                       // nodeHttp = null;
-                       // destroy();
-                       repositories.close();
-                       repositories = null;
-               }
-
-               private HttpService addHttpService(ServiceReference<HttpService> sr) {
-                       HttpService httpService = bc.getService(sr);
-                       // TODO find constants
-                       Object httpPort = sr.getProperty("http.port");
-                       Object httpsPort = sr.getProperty("https.port");
-
-                       try {
-                               httpService.registerServlet("/!", new LinkServlet(), null, null);
-                               httpService.registerServlet("/robots.txt", new RobotServlet(), null, null);
-                       } catch (Exception e) {
-                               throw new CmsException("Cannot register filters", e);
-                       }
-                       // track repositories
-                       if (repositories != null)
-                               throw new CmsException("An http service is already configured");
-                       repositories = new RepositoriesStc(httpService);
-                       repositories.open();
-                       log.info(httpPortsMsg(httpPort, httpsPort));
-                       // httpAvailable = true;
-                       // checkReadiness();
-
-                       bc.registerService(NodeHttp.class, NodeHttp.this, null);
-                       return httpService;
-               }
-
-               private String httpPortsMsg(Object httpPort, Object httpsPort) {
-                       return "HTTP " + httpPort + (httpsPort != null ? " - HTTPS " + httpsPort : "");
-               }
-       }
-
-       private class WebdavServlet extends SimpleWebdavServlet {
-               private static final long serialVersionUID = -4687354117811443881L;
-               private final Repository repository;
-
-               public WebdavServlet(Repository repository, SessionProvider sessionProvider) {
-                       this.repository = repository;
-                       setSessionProvider(sessionProvider);
-               }
-
-               public Repository getRepository() {
-                       return repository;
-               }
-
-               @Override
-               protected void service(final HttpServletRequest request, final HttpServletResponse response)
-                               throws ServletException, IOException {
-                       WebdavServlet.super.service(request, response);
-                       // try {
-                       // Subject subject = subjectFromRequest(request);
-                       // // TODO make it stronger, with eTags.
-                       // // if (CurrentUser.isAnonymous(subject) &&
-                       // // request.getMethod().equals("GET")) {
-                       // // response.setHeader("Cache-Control", "no-transform, public,
-                       // // max-age=300, s-maxage=900");
-                       // // }
-                       //
-                       // Subject.doAs(subject, new PrivilegedExceptionAction<Void>() {
-                       // @Override
-                       // public Void run() throws Exception {
-                       // WebdavServlet.super.service(request, response);
-                       // return null;
-                       // }
-                       // });
-                       // } catch (PrivilegedActionException e) {
-                       // throw new CmsException("Cannot process webdav request",
-                       // e.getException());
-                       // }
-               }
-
-       }
-
-       private class RemotingServlet extends JcrRemotingServlet {
-               private final Log log = LogFactory.getLog(RemotingServlet.class);
-               private static final long serialVersionUID = 4605238259548058883L;
-               private final Repository repository;
-               private final SessionProvider sessionProvider;
-
-               public RemotingServlet(Repository repository, SessionProvider sessionProvider) {
-                       this.repository = repository;
-                       this.sessionProvider = sessionProvider;
-               }
-
-               @Override
-               protected Repository getRepository() {
-                       return repository;
-               }
-
-               @Override
-               protected SessionProvider getSessionProvider() {
-                       return sessionProvider;
-               }
-
-               @Override
-               protected void service(final HttpServletRequest request, final HttpServletResponse response)
-                               throws ServletException, IOException {
-                       // try {
-                       // Subject subject = subjectFromRequest(request, response);
-                       // Subject.doAs(subject, new PrivilegedExceptionAction<Void>() {
-                       // @Override
-                       // public Void run() throws Exception {
-                       if (log.isTraceEnabled())
-                               HttpUtils.logRequest(log, request);
-                       RemotingServlet.super.service(request, response);
-                       // return null;
-                       // }
-                       // });
-                       // } catch (PrivilegedActionException e) {
-                       // throw new CmsException("Cannot process JCR remoting request",
-                       // e.getException());
-                       // }
-               }
-       }
-
-}
index 2babd188b2c0843fcd11dfc1485c0f350dfc39da..c3f2a1c802d1d8fd401d61261ba23ae7909fe6bc 100644 (file)
@@ -5,7 +5,7 @@ import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
 /** Requests authorisation */
-class PrivateHttpContext extends DataHttpContext {
+public class PrivateHttpContext extends DataHttpContext {
 
        public PrivateHttpContext(String httpAuthrealm, boolean forceBasic) {
                super(httpAuthrealm, forceBasic);
index 92d9eb78cfccb7caf91b328227b0f1abe1003507..6d3d302b7dda8cf1ade89600701d9072a544ca26 100644 (file)
@@ -8,7 +8,7 @@ import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-class RobotServlet extends HttpServlet {
+public class RobotServlet extends HttpServlet {
        private static final long serialVersionUID = 7935661175336419089L;
 
        @Override
index 64dbaab74029bf8af594020c4d80e1c31900a9c3..7a8071f4a9eb41c073be8d973e8e0983a25e4273 100644 (file)
@@ -20,7 +20,7 @@ import org.apache.commons.httpclient.auth.MalformedChallengeException;
 import org.apache.commons.httpclient.methods.GetMethod;
 import org.apache.commons.httpclient.params.DefaultHttpParams;
 import org.apache.commons.httpclient.params.HttpParams;
-import org.argeo.cms.internal.http.NodeHttp;
+import org.argeo.cms.internal.kernel.NodeHttp;
 import org.ietf.jgss.GSSContext;
 import org.ietf.jgss.GSSException;
 import org.ietf.jgss.GSSManager;
index 25746a48116b29f84930e93ea7a18272d1199412..980dde975fd2424a2ec210240573ebb3406397be 100644 (file)
@@ -59,6 +59,7 @@ public class Activator implements BundleActivator {
                        initSecurity();
                        initArgeoLogger();
                        initNode();
+                       log.debug("Kernel bundle started");
                } catch (Exception e) {
                        log.error("## FATAL: CMS activator failed", e);
                }
index 7dedfe811db420e682a09730db55407870b5b880..7f547fd11eed767a5bb609751ed3ee7bdb788a05 100644 (file)
@@ -21,7 +21,6 @@ import org.apache.commons.logging.LogFactory;
 import org.apache.jackrabbit.commons.cnd.CndImporter;
 import org.apache.jackrabbit.core.RepositoryContext;
 import org.argeo.cms.CmsException;
-import org.argeo.cms.internal.http.NodeHttp;
 import org.argeo.jcr.JcrUtils;
 import org.argeo.node.DataModelNamespace;
 import org.argeo.node.NodeConstants;
@@ -78,7 +77,7 @@ public class CmsDeployment implements NodeDeployment {
        }
 
        private void initTrackers() {
-               new ServiceTracker<NodeHttp, NodeHttp>(bc, NodeHttp.class, null) {
+               ServiceTracker<?, ?> httpSt = new ServiceTracker<NodeHttp, NodeHttp>(bc, NodeHttp.class, null) {
 
                        @Override
                        public NodeHttp addingService(ServiceReference<NodeHttp> reference) {
@@ -86,17 +85,27 @@ public class CmsDeployment implements NodeDeployment {
                                checkReadiness();
                                return super.addingService(reference);
                        }
-               }.open();
-               new RepositoryContextStc().open();
-               new ServiceTracker<UserAdmin, UserAdmin>(bc, UserAdmin.class, null) {
+               };
+//             httpSt.open();
+               KernelUtils.asyncOpen(httpSt);
+
+               ServiceTracker<?, ?> repoContextSt = new RepositoryContextStc();
+//             repoContextSt.open();
+               KernelUtils.asyncOpen(repoContextSt);
+
+               ServiceTracker<?, ?> userAdminSt = new ServiceTracker<UserAdmin, UserAdmin>(bc, UserAdmin.class, null) {
                        @Override
                        public UserAdmin addingService(ServiceReference<UserAdmin> reference) {
                                userAdminAvailable = true;
                                checkReadiness();
                                return super.addingService(reference);
                        }
-               }.open();
-               new ServiceTracker<ConfigurationAdmin, ConfigurationAdmin>(bc, ConfigurationAdmin.class, null) {
+               };
+//             userAdminSt.open();
+               KernelUtils.asyncOpen(userAdminSt);
+
+               ServiceTracker<?, ?> confAdminSt = new ServiceTracker<ConfigurationAdmin, ConfigurationAdmin>(bc,
+                               ConfigurationAdmin.class, null) {
                        @Override
                        public ConfigurationAdmin addingService(ServiceReference<ConfigurationAdmin> reference) {
                                ConfigurationAdmin configurationAdmin = bc.getService(reference);
@@ -130,7 +139,9 @@ public class CmsDeployment implements NodeDeployment {
                                }
                                return super.addingService(reference);
                        }
-               }.open();
+               };
+//             confAdminSt.open();
+               KernelUtils.asyncOpen(confAdminSt);
        }
 
        private void loadIpaJaasConfiguration() {
index b3fb33ac3169911e02eaafe4b6df4fbd1197dfb5..63cb356d33fca383b2c90f782036eb896cc62fe7 100644 (file)
@@ -29,6 +29,7 @@ import org.argeo.node.NodeConstants;
 import org.osgi.framework.Bundle;
 import org.osgi.framework.BundleContext;
 import org.osgi.framework.FrameworkUtil;
+import org.osgi.util.tracker.ServiceTracker;
 
 /** Package utilities */
 class KernelUtils implements KernelConstants {
@@ -188,9 +189,20 @@ class KernelUtils implements KernelConstants {
                });
        }
 
+       static void asyncOpen(ServiceTracker<?, ?> st) {
+               Runnable run = new Runnable() {
+
+                       @Override
+                       public void run() {
+                               st.open();
+                       }
+               };
+               new Thread(run, "Open service tracker " + st).start();
+       }
+
        /**
-        * @return the {@link BundleContext} of the {@link Bundle} which provided
-        *         this class, never null.
+        * @return the {@link BundleContext} of the {@link Bundle} which provided this
+        *         class, never null.
         * @throws CmsException
         *             if the related bundle is not active
         */
diff --git a/org.argeo.cms/src/org/argeo/cms/internal/kernel/NodeHttp.java b/org.argeo.cms/src/org/argeo/cms/internal/kernel/NodeHttp.java
new file mode 100644 (file)
index 0000000..f17c982
--- /dev/null
@@ -0,0 +1,342 @@
+package org.argeo.cms.internal.kernel;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Properties;
+
+import javax.jcr.Repository;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.jackrabbit.server.SessionProvider;
+import org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet;
+import org.apache.jackrabbit.webdav.simple.SimpleWebdavServlet;
+import org.argeo.cms.CmsException;
+import org.argeo.cms.internal.http.CmsSessionProvider;
+import org.argeo.cms.internal.http.DataHttpContext;
+import org.argeo.cms.internal.http.HttpUtils;
+import org.argeo.cms.internal.http.LinkServlet;
+import org.argeo.cms.internal.http.PrivateHttpContext;
+import org.argeo.cms.internal.http.RobotServlet;
+import org.argeo.node.NodeConstants;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.FrameworkUtil;
+import org.osgi.framework.ServiceReference;
+import org.osgi.service.http.HttpService;
+import org.osgi.service.http.NamespaceException;
+import org.osgi.util.tracker.ServiceTracker;
+
+/**
+ * Intercepts and enriches http access, mainly focusing on security and
+ * transactionality.
+ */
+public class NodeHttp implements KernelConstants {
+       private final static Log log = LogFactory.getLog(NodeHttp.class);
+
+       public final static String DEFAULT_SERVICE = "HTTP";
+
+       private final BundleContext bc = FrameworkUtil.getBundle(getClass()).getBundleContext();
+
+       private ServiceTracker<Repository, Repository> repositories;
+       private final ServiceTracker<HttpService, HttpService> httpServiceTracker;
+
+       private static String httpRealm = "Argeo";
+
+       public NodeHttp() {
+               httpServiceTracker = new PrepareHttpStc();
+               // httpServiceTracker.open();
+               KernelUtils.asyncOpen(httpServiceTracker);
+       }
+
+       public void destroy() {
+               if (repositories != null)
+                       repositories.close();
+       }
+
+       public static void registerRepositoryServlets(HttpService httpService, String alias, Repository repository) {
+               if (httpService == null)
+                       throw new CmsException("No HTTP service available");
+               try {
+                       registerWebdavServlet(httpService, alias, repository);
+                       registerRemotingServlet(httpService, alias, repository);
+                       if (NodeConstants.HOME.equals(alias))
+                               registerFilesServlet(httpService, alias, repository);
+                       if (log.isDebugEnabled())
+                               log.debug("Registered servlets for repository '" + alias + "'");
+               } catch (Exception e) {
+                       throw new CmsException("Could not register servlets for repository '" + alias + "'", e);
+               }
+       }
+
+       public static void unregisterRepositoryServlets(HttpService httpService, String alias) {
+               if (httpService == null)
+                       return;
+               try {
+                       httpService.unregister(webdavPath(alias));
+                       httpService.unregister(remotingPath(alias));
+                       if (NodeConstants.HOME.equals(alias))
+                               httpService.unregister(filesPath(alias));
+                       if (log.isDebugEnabled())
+                               log.debug("Unregistered servlets for repository '" + alias + "'");
+               } catch (Exception e) {
+                       log.error("Could not unregister servlets for repository '" + alias + "'", e);
+               }
+       }
+
+       static void registerWebdavServlet(HttpService httpService, String alias, Repository repository)
+                       throws NamespaceException, ServletException {
+               // WebdavServlet webdavServlet = new WebdavServlet(repository, new
+               // OpenInViewSessionProvider(alias));
+               WebdavServlet webdavServlet = new WebdavServlet(repository, new CmsSessionProvider(alias));
+               String path = webdavPath(alias);
+               Properties ip = new Properties();
+               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_CONFIG, HttpUtils.WEBDAV_CONFIG);
+               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_PATH_PREFIX, path);
+               httpService.registerServlet(path, webdavServlet, ip, new DataHttpContext(httpRealm));
+       }
+
+       static void registerFilesServlet(HttpService httpService, String alias, Repository repository)
+                       throws NamespaceException, ServletException {
+               WebdavServlet filesServlet = new WebdavServlet(repository, new CmsSessionProvider(alias));
+               String path = filesPath(alias);
+               Properties ip = new Properties();
+               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_CONFIG, HttpUtils.WEBDAV_CONFIG);
+               ip.setProperty(WebdavServlet.INIT_PARAM_RESOURCE_PATH_PREFIX, path);
+               httpService.registerServlet(path, filesServlet, ip, new PrivateHttpContext(httpRealm, true));
+       }
+
+       static void registerRemotingServlet(HttpService httpService, String alias, Repository repository)
+                       throws NamespaceException, ServletException {
+               RemotingServlet remotingServlet = new RemotingServlet(repository, new CmsSessionProvider(alias));
+               String path = remotingPath(alias);
+               Properties ip = new Properties();
+               ip.setProperty(JcrRemotingServlet.INIT_PARAM_RESOURCE_PATH_PREFIX, path);
+               ip.setProperty(JcrRemotingServlet.INIT_PARAM_AUTHENTICATE_HEADER, "Negotiate");
+
+               // Looks like a bug in Jackrabbit remoting init
+               Path tmpDir;
+               try {
+                       tmpDir = Files.createTempDirectory("remoting_" + alias);
+               } catch (IOException e) {
+                       throw new CmsException("Cannot create temp directory for remoting servlet", e);
+               }
+               ip.setProperty(RemotingServlet.INIT_PARAM_HOME, tmpDir.toString());
+               ip.setProperty(RemotingServlet.INIT_PARAM_TMP_DIRECTORY, "remoting_" + alias);
+               ip.setProperty(RemotingServlet.INIT_PARAM_PROTECTED_HANDLERS_CONFIG, HttpUtils.DEFAULT_PROTECTED_HANDLERS);
+               ip.setProperty(RemotingServlet.INIT_PARAM_CREATE_ABSOLUTE_URI, "false");
+               httpService.registerServlet(path, remotingServlet, ip, new PrivateHttpContext(httpRealm));
+       }
+
+       static String webdavPath(String alias) {
+               return NodeConstants.PATH_DATA + "/" + alias;
+       }
+
+       static String remotingPath(String alias) {
+               return NodeConstants.PATH_JCR + "/" + alias;
+       }
+
+       static String filesPath(String alias) {
+               return NodeConstants.PATH_FILES;
+       }
+
+       // private Subject subjectFromRequest(HttpServletRequest request,
+       // HttpServletResponse response) {
+       // Authorization authorization = (Authorization)
+       // request.getAttribute(HttpContext.AUTHORIZATION);
+       // if (authorization == null)
+       // throw new CmsException("Not authenticated");
+       // try {
+       // LoginContext lc = new LoginContext(NodeConstants.LOGIN_CONTEXT_USER,
+       // new HttpRequestCallbackHandler(request, response));
+       // lc.login();
+       // return lc.getSubject();
+       // } catch (LoginException e) {
+       // throw new CmsException("Cannot login", e);
+       // }
+       // }
+
+       static class RepositoriesStc extends ServiceTracker<Repository, Repository> {
+               private final HttpService httpService;
+
+               private final BundleContext bc;
+
+               public RepositoriesStc(BundleContext bc, HttpService httpService) {
+                       super(bc, Repository.class, null);
+                       this.httpService = httpService;
+                       this.bc = bc;
+               }
+
+               @Override
+               public Repository addingService(ServiceReference<Repository> reference) {
+                       Repository repository = bc.getService(reference);
+                       Object jcrRepoAlias = reference.getProperty(NodeConstants.CN);
+                       if (jcrRepoAlias != null) {
+                               String alias = jcrRepoAlias.toString();
+                               registerRepositoryServlets(httpService, alias, repository);
+                       }
+                       return repository;
+               }
+
+               @Override
+               public void modifiedService(ServiceReference<Repository> reference, Repository service) {
+               }
+
+               @Override
+               public void removedService(ServiceReference<Repository> reference, Repository service) {
+                       Object jcrRepoAlias = reference.getProperty(NodeConstants.CN);
+                       if (jcrRepoAlias != null) {
+                               String alias = jcrRepoAlias.toString();
+                               unregisterRepositoryServlets(httpService, alias);
+                       }
+               }
+       }
+
+       private class PrepareHttpStc extends ServiceTracker<HttpService, HttpService> {
+               // private DataHttp dataHttp;
+               // private NodeHttp nodeHttp;
+
+               public PrepareHttpStc() {
+                       super(bc, HttpService.class, null);
+               }
+
+               @Override
+               public HttpService addingService(ServiceReference<HttpService> reference) {
+                       long begin = System.currentTimeMillis();
+                       log.debug("HTTP prepare starts...");
+                       HttpService httpService = addHttpService(reference);
+                       log.debug("HTTP prepare duration: " + (System.currentTimeMillis() - begin) + "ms");
+                       return httpService;
+               }
+
+               @Override
+               public void removedService(ServiceReference<HttpService> reference, HttpService service) {
+                       // if (dataHttp != null)
+                       // dataHttp.destroy();
+                       // dataHttp = null;
+                       // if (nodeHttp != null)
+                       // nodeHttp.destroy();
+                       // nodeHttp = null;
+                       // destroy();
+                       repositories.close();
+                       repositories = null;
+               }
+
+               private HttpService addHttpService(ServiceReference<HttpService> sr) {
+                       HttpService httpService = bc.getService(sr);
+                       // TODO find constants
+                       Object httpPort = sr.getProperty("http.port");
+                       Object httpsPort = sr.getProperty("https.port");
+
+                       try {
+                               httpService.registerServlet("/!", new LinkServlet(), null, null);
+                               httpService.registerServlet("/robots.txt", new RobotServlet(), null, null);
+                       } catch (Exception e) {
+                               throw new CmsException("Cannot register filters", e);
+                       }
+                       // track repositories
+                       if (repositories != null)
+                               throw new CmsException("An http service is already configured");
+                       repositories = new RepositoriesStc(bc, httpService);
+                       // repositories.open();
+                       KernelUtils.asyncOpen(repositories);
+                       log.info(httpPortsMsg(httpPort, httpsPort));
+                       // httpAvailable = true;
+                       // checkReadiness();
+
+                       bc.registerService(NodeHttp.class, NodeHttp.this, null);
+                       return httpService;
+               }
+
+               private String httpPortsMsg(Object httpPort, Object httpsPort) {
+                       return "HTTP " + httpPort + (httpsPort != null ? " - HTTPS " + httpsPort : "");
+               }
+       }
+
+       private static class WebdavServlet extends SimpleWebdavServlet {
+               private static final long serialVersionUID = -4687354117811443881L;
+               private final Repository repository;
+
+               public WebdavServlet(Repository repository, SessionProvider sessionProvider) {
+                       this.repository = repository;
+                       setSessionProvider(sessionProvider);
+               }
+
+               public Repository getRepository() {
+                       return repository;
+               }
+
+               @Override
+               protected void service(final HttpServletRequest request, final HttpServletResponse response)
+                               throws ServletException, IOException {
+                       WebdavServlet.super.service(request, response);
+                       // try {
+                       // Subject subject = subjectFromRequest(request);
+                       // // TODO make it stronger, with eTags.
+                       // // if (CurrentUser.isAnonymous(subject) &&
+                       // // request.getMethod().equals("GET")) {
+                       // // response.setHeader("Cache-Control", "no-transform, public,
+                       // // max-age=300, s-maxage=900");
+                       // // }
+                       //
+                       // Subject.doAs(subject, new PrivilegedExceptionAction<Void>() {
+                       // @Override
+                       // public Void run() throws Exception {
+                       // WebdavServlet.super.service(request, response);
+                       // return null;
+                       // }
+                       // });
+                       // } catch (PrivilegedActionException e) {
+                       // throw new CmsException("Cannot process webdav request",
+                       // e.getException());
+                       // }
+               }
+
+       }
+
+       private static class RemotingServlet extends JcrRemotingServlet {
+               private final Log log = LogFactory.getLog(RemotingServlet.class);
+               private static final long serialVersionUID = 4605238259548058883L;
+               private final Repository repository;
+               private final SessionProvider sessionProvider;
+
+               public RemotingServlet(Repository repository, SessionProvider sessionProvider) {
+                       this.repository = repository;
+                       this.sessionProvider = sessionProvider;
+               }
+
+               @Override
+               protected Repository getRepository() {
+                       return repository;
+               }
+
+               @Override
+               protected SessionProvider getSessionProvider() {
+                       return sessionProvider;
+               }
+
+               @Override
+               protected void service(final HttpServletRequest request, final HttpServletResponse response)
+                               throws ServletException, IOException {
+                       // try {
+                       // Subject subject = subjectFromRequest(request, response);
+                       // Subject.doAs(subject, new PrivilegedExceptionAction<Void>() {
+                       // @Override
+                       // public Void run() throws Exception {
+                       if (log.isTraceEnabled())
+                               HttpUtils.logRequest(log, request);
+                       RemotingServlet.super.service(request, response);
+                       // return null;
+                       // }
+                       // });
+                       // } catch (PrivilegedActionException e) {
+                       // throw new CmsException("Cannot process JCR remoting request",
+                       // e.getException());
+                       // }
+               }
+       }
+
+}
index 45ed8ec3e11ae2984958d5317f9e970df616ce2e..134ab26ab3d06b8f3a97bd81bc357b48dd11c342 100644 (file)
@@ -129,6 +129,10 @@ class NodeLogger implements ArgeoLogger, LogListener {
        // this.layout = layout;
        // }
 
+       public String toString() {
+               return "Node Logger";
+       }
+
        //
        // OSGi LOGGER
        //
index 077a1f8a7286bf76568fb3547ab53e791e75d258..f1132a64260a1ebca5d9e41011aa79ff195442f4 100644 (file)
@@ -36,7 +36,6 @@ import org.apache.commons.httpclient.params.HttpParams;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.argeo.cms.CmsException;
-import org.argeo.cms.internal.http.NodeHttp;
 import org.argeo.cms.internal.http.client.HttpCredentialProvider;
 import org.argeo.cms.internal.http.client.SpnegoAuthScheme;
 import org.argeo.naming.DnsBrowser;