Better deal with multiple user directories.
[lgpl/argeo-commons.git] / org.argeo.cms / src / org / argeo / cms / internal / kernel / DeployConfig.java
index b42220a6c8701635d22012b532ed4a32e3ad1ce5..f481f3fa10e2ce9bf1ef9838b42dbc37fecf8f18 100644 (file)
@@ -12,6 +12,7 @@ import java.util.SortedMap;
 import java.util.TreeMap;
 
 import javax.naming.InvalidNameException;
+import javax.naming.directory.Attribute;
 import javax.naming.directory.Attributes;
 import javax.naming.directory.BasicAttributes;
 import javax.naming.ldap.LdapName;
@@ -19,12 +20,12 @@ import javax.naming.ldap.Rdn;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
-import org.argeo.cms.CmsException;
+import org.argeo.api.NodeConstants;
 import org.argeo.naming.AttributesDictionary;
 import org.argeo.naming.LdifParser;
 import org.argeo.naming.LdifWriter;
-import org.argeo.node.NodeConstants;
 import org.argeo.osgi.useradmin.UserAdminConf;
+import org.eclipse.equinox.http.jetty.JettyConfigurator;
 import org.osgi.framework.BundleContext;
 import org.osgi.framework.FrameworkUtil;
 import org.osgi.service.cm.Configuration;
@@ -32,6 +33,7 @@ import org.osgi.service.cm.ConfigurationAdmin;
 import org.osgi.service.cm.ConfigurationEvent;
 import org.osgi.service.cm.ConfigurationListener;
 
+/** Manages the LDIF-based deployment configuration. */
 class DeployConfig implements ConfigurationListener {
        private final Log log = LogFactory.getLog(getClass());
        private final BundleContext bc = FrameworkUtil.getBundle(getClass()).getBundleContext();
@@ -40,19 +42,22 @@ class DeployConfig implements ConfigurationListener {
        private SortedMap<LdapName, Attributes> deployConfigs = new TreeMap<>();
        private final DataModels dataModels;
 
+       private boolean isFirstInit = false;
+
+       private final static String ROLES = "roles";
+
        public DeployConfig(ConfigurationAdmin configurationAdmin, DataModels dataModels, boolean isClean) {
                this.dataModels = dataModels;
                // ConfigurationAdmin configurationAdmin =
                // bc.getService(bc.getServiceReference(ConfigurationAdmin.class));
                try {
-                       boolean isFirstInit = false;
                        if (!isInitialized()) { // first init
                                isFirstInit = true;
                                firstInit();
                        }
                        init(configurationAdmin, isClean, isFirstInit);
                } catch (IOException e) {
-                       throw new CmsException("Could not init deploy configs", e);
+                       throw new RuntimeException("Could not init deploy configs", e);
                }
                // FIXME check race conditions during initialization
                // bc.registerService(ConfigurationListener.class, this, null);
@@ -83,7 +88,7 @@ class DeployConfig implements ConfigurationListener {
 
                // additional repositories
                dataModels: for (DataModels.DataModel dataModel : dataModels.getNonAbstractDataModels()) {
-                       if (NodeConstants.NODE.equals(dataModel.getName()))
+                       if (NodeConstants.NODE_REPOSITORY.equals(dataModel.getName()))
                                continue dataModels;
                        Dictionary<String, Object> config = InitUtils.getRepositoryConfig(dataModel.getName(),
                                        getProps(NodeConstants.NODE_REPOS_FACTORY_PID, dataModel.getName()));
@@ -97,7 +102,12 @@ class DeployConfig implements ConfigurationListener {
                        List<String> activeCns = new ArrayList<>();
                        for (int i = 0; i < userDirectoryConfigs.size(); i++) {
                                Dictionary<String, Object> userDirectoryConfig = userDirectoryConfigs.get(i);
-                               String cn = UserAdminConf.baseDnHash(userDirectoryConfig);
+                               String baseDn = (String) userDirectoryConfig.get(UserAdminConf.baseDn.name());
+                               String cn;
+                               if (NodeConstants.ROLES_BASEDN.equals(baseDn))
+                                       cn = ROLES;
+                               else
+                                       cn = UserAdminConf.baseDnHash(userDirectoryConfig);
                                activeCns.add(cn);
                                userDirectoryConfig.put(NodeConstants.CN, cn);
                                putFactoryDeployConfig(NodeConstants.NODE_USER_ADMIN_PID, userDirectoryConfig);
@@ -106,26 +116,76 @@ class DeployConfig implements ConfigurationListener {
                        LdapName userAdminFactoryName = serviceFactoryDn(NodeConstants.NODE_USER_ADMIN_PID);
                        for (LdapName name : deployConfigs.keySet()) {
                                if (name.startsWith(userAdminFactoryName) && !name.equals(userAdminFactoryName)) {
-                                       try {
-                                               Attributes attrs = deployConfigs.get(name);
-                                               String cn = name.getRdn(name.size() - 1).getValue().toString();
-                                               if (!activeCns.contains(cn)) {
-                                                       attrs.put(UserAdminConf.disabled.name(), "true");
-                                               }
-                                       } catch (Exception e) {
-                                               throw new CmsException("Cannot disable user directory " + name, e);
+//                                     try {
+                                       Attributes attrs = deployConfigs.get(name);
+                                       String cn = name.getRdn(name.size() - 1).getValue().toString();
+                                       if (!activeCns.contains(cn)) {
+                                               attrs.put(UserAdminConf.disabled.name(), "true");
                                        }
+//                                     } catch (Exception e) {
+//                                             throw new CmsException("Cannot disable user directory " + name, e);
+//                                     }
                                }
                        }
                }
 
                // http server
+//             Dictionary<String, Object> webServerConfig = InitUtils
+//                             .getHttpServerConfig(getProps(KernelConstants.JETTY_FACTORY_PID, NodeConstants.DEFAULT));
+//             if (!webServerConfig.isEmpty()) {
+//                     // TODO check for other customizers
+//                     webServerConfig.put("customizer.class", "org.argeo.equinox.jetty.CmsJettyCustomizer");
+//                     putFactoryDeployConfig(KernelConstants.JETTY_FACTORY_PID, webServerConfig);
+//             }
+               LdapName defaultHttpServiceDn = serviceDn(KernelConstants.JETTY_FACTORY_PID, NodeConstants.DEFAULT);
+               if (deployConfigs.containsKey(defaultHttpServiceDn)) {
+                       // remove old default configs since we have now to start Jetty servlet bridge
+                       // indirectly
+                       deployConfigs.remove(defaultHttpServiceDn);
+               }
+
+               // SAVE
+               save();
+               //
+
+               // Explicitly configures Jetty so that the default server is not started by the
+               // activator of the Equinox Jetty bundle.
                Dictionary<String, Object> webServerConfig = InitUtils
                                .getHttpServerConfig(getProps(KernelConstants.JETTY_FACTORY_PID, NodeConstants.DEFAULT));
-               if (!webServerConfig.isEmpty())
-                       putFactoryDeployConfig(KernelConstants.JETTY_FACTORY_PID, webServerConfig);
+//             if (!webServerConfig.isEmpty()) {
+//                     webServerConfig.put("customizer.class", KernelConstants.CMS_JETTY_CUSTOMIZER_CLASS);
+//
+//                     // TODO centralise with Jetty extender
+//                     Object webSocketEnabled = webServerConfig.get(InternalHttpConstants.WEBSOCKET_ENABLED);
+//                     if (webSocketEnabled != null && webSocketEnabled.toString().equals("true")) {
+//                             bc.registerService(ServerEndpointConfig.Configurator.class, new CmsWebSocketConfigurator(), null);
+//                             webServerConfig.put(InternalHttpConstants.WEBSOCKET_ENABLED, "true");
+//                     }
+//             }
+
+               int tryCount = 60;
+               try {
+                       tryGettyJetty: while (tryCount > 0) {
+                               try {
+                                       JettyConfigurator.startServer(KernelConstants.DEFAULT_JETTY_SERVER, webServerConfig);
+                                       // Explicitly starts Jetty OSGi HTTP bundle, so that it gets triggered if OSGi
+                                       // configuration is not cleaned
+                                       FrameworkUtil.getBundle(JettyConfigurator.class).start();
+                                       break tryGettyJetty;
+                               } catch (IllegalStateException e) {
+                                       // Jetty may not be ready
+                                       try {
+                                               Thread.sleep(1000);
+                                       } catch (Exception e1) {
+                                               // silent
+                                       }
+                                       tryCount--;
+                               }
+                       }
+               } catch (Exception e) {
+                       log.error("Cannot start default Jetty server with config " + webServerConfig, e);
+               }
 
-               save();
        }
 
        private void init(ConfigurationAdmin configurationAdmin, boolean isClean, boolean isFirstInit) throws IOException {
@@ -134,8 +194,20 @@ class DeployConfig implements ConfigurationListener {
                        deployConfigs = new LdifParser().read(in);
                }
                if (isClean) {
+                       if (log.isDebugEnabled())
+                               log.debug("Clean state, loading from framework properties...");
                        setFromFrameworkProperties(isFirstInit);
-                       for (LdapName dn : deployConfigs.keySet()) {
+
+                       // FIXME make it more robust
+                       Configuration systemRolesConf = null;
+                       LdapName systemRolesDn;
+                       try {
+                               // FIXME make it more robust
+                               systemRolesDn = new LdapName("cn=roles,ou=org.argeo.api.userAdmin,ou=deploy,ou=node");
+                       } catch (InvalidNameException e) {
+                               throw new IllegalArgumentException(e);
+                       }
+                       deployConfigs: for (LdapName dn : deployConfigs.keySet()) {
                                Rdn lastRdn = dn.getRdn(dn.size() - 1);
                                LdapName prefix = (LdapName) dn.getPrefix(dn.size() - 1);
                                if (prefix.toString().equals(NodeConstants.DEPLOY_BASEDN)) {
@@ -149,15 +221,28 @@ class DeployConfig implements ConfigurationListener {
                                                // service factory definition
                                        }
                                } else {
+                                       Attributes config = deployConfigs.get(dn);
+                                       Attribute disabled = config.get(UserAdminConf.disabled.name());
+                                       if (disabled != null)
+                                               continue deployConfigs;
                                        // service factory service
                                        Rdn beforeLastRdn = dn.getRdn(dn.size() - 2);
                                        assert beforeLastRdn.getType().equals(NodeConstants.OU);
                                        String factoryPid = beforeLastRdn.getValue().toString();
                                        Configuration conf = configurationAdmin.createFactoryConfiguration(factoryPid.toString(), null);
-                                       AttributesDictionary dico = new AttributesDictionary(deployConfigs.get(dn));
-                                       conf.update(dico);
+                                       if (systemRolesDn.equals(dn)) {
+                                               systemRolesConf = configurationAdmin.createFactoryConfiguration(factoryPid.toString(), null);
+                                       } else {
+                                               AttributesDictionary dico = new AttributesDictionary(config);
+                                               conf.update(dico);
+                                       }
                                }
                        }
+
+                       // system roles must be last since it triggers node user admin publication
+                       if (systemRolesConf == null)
+                               throw new IllegalStateException("System roles are not configured.");
+                       systemRolesConf.update(new AttributesDictionary(deployConfigs.get(systemRolesDn)));
                }
                // TODO check consistency if not clean
        }
@@ -245,7 +330,8 @@ class DeployConfig implements ConfigurationListener {
                try (Writer writer = Files.newBufferedWriter(deployConfigPath)) {
                        new LdifWriter(writer).write(deployConfigs);
                } catch (IOException e) {
-                       throw new CmsException("Cannot save deploy configs", e);
+                       // throw new CmsException("Cannot save deploy configs", e);
+                       log.error("Cannot save deploy configs", e);
                }
        }
 
@@ -288,8 +374,12 @@ class DeployConfig implements ConfigurationListener {
                        return null;
        }
 
-       static boolean isInitialized() {
+       private static boolean isInitialized() {
                return Files.exists(deployConfigPath);
        }
 
+       public boolean isFirstInit() {
+               return isFirstInit;
+       }
+
 }