Synchronise archives download

[cc0/argeo-build.git] / src / org / argeo / build / Repackage.java

diff --git a/src/org/argeo/build/Repackage.java b/src/org/argeo/build/Repackage.java
index 037ddbd7cd26b2325d64126a34ececfc32370219..c6919d791eb5274c8c942ce02193d1e4ffb0d120 100644 (file)
--- a/src/org/argeo/build/Repackage.java
+++ b/src/org/argeo/build/Repackage.java
@@ -941,8 +941,11 @@ public class Repackage {
                return download(url, dir, (String) null);
        }
 
-       /** Effectively download. */
-       protected Path download(URL url, Path dir, String name) throws IOException {
+       /**
+        * Effectively download. Synchronized in order to avoid downloading twice in
+        * parallel.
+        */
+       protected synchronized Path download(URL url, Path dir, String name) throws IOException {
 
                Path dest;
                if (name == null) {
@@ -951,6 +954,7 @@ public class Repackage {
 
                dest = dir.resolve(name);
                if (Files.exists(dest)) {
+                       // FIXME If new archives have the same name (e.g. nebula-latest.zip) they will be skipped
                        logger.log(Level.TRACE, () -> "File " + dest + " already exists for " + url + ", not downloading again");
                        return dest;
                } else {