import static java.lang.System.Logger.Level.TRACE;
import static java.lang.System.Logger.Level.WARNING;
import static java.nio.file.FileVisitResult.CONTINUE;
+import static java.util.jar.Attributes.Name.MANIFEST_VERSION;
import static org.argeo.build.Repackage.ManifestConstants.ARGEO_ORIGIN_M2;
+import static org.argeo.build.Repackage.ManifestConstants.ARGEO_ORIGIN_M2_MERGE;
import static org.argeo.build.Repackage.ManifestConstants.ARGEO_ORIGIN_M2_REPO;
+import static org.argeo.build.Repackage.ManifestConstants.ARGEO_ORIGIN_URI;
+import static org.argeo.build.Repackage.ManifestConstants.BUNDLE_LICENSE;
import static org.argeo.build.Repackage.ManifestConstants.BUNDLE_SYMBOLICNAME;
import static org.argeo.build.Repackage.ManifestConstants.BUNDLE_VERSION;
+import static org.argeo.build.Repackage.ManifestConstants.ECLIPSE_SOURCE_BUNDLE;
import static org.argeo.build.Repackage.ManifestConstants.EXPORT_PACKAGE;
+import static org.argeo.build.Repackage.ManifestConstants.IMPORT_PACKAGE;
+import static org.argeo.build.Repackage.ManifestConstants.SPDX_LICENSE_IDENTIFIER;
+import java.io.BufferedWriter;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.Map;
import java.util.Objects;
import java.util.Properties;
+import java.util.Set;
import java.util.TreeMap;
+import java.util.TreeSet;
import java.util.concurrent.CompletableFuture;
import java.util.jar.Attributes;
import java.util.jar.JarEntry;
* repository.
*/
public class Repackage {
- private final static Logger logger = System.getLogger(Repackage.class.getName());
+ final static Logger logger = System.getLogger(Repackage.class.getName());
/**
* Environment variable on whether sources should be packaged separately or
* integrated in the bundles.
*/
- private final static String ENV_SOURCE_BUNDLES = "SOURCE_BUNDLES";
+ final static String ENV_SOURCE_BUNDLES = "SOURCE_BUNDLES";
- /** Whethere repackaging should run in parallel or sequentially. */
- private final static boolean parallel = true;
+ /** Whether repackaging should run in parallel or sequentially. */
+ final static boolean parallel = true;
+
+ // cache
+ /** Summary of all license seen during the repackaging. */
+ final static Map<String, Set<String>> licensesUsed = new TreeMap<>();
/** Main entry point. */
public static void main(String[] args) {
factory.processCategory(p);
}
CompletableFuture.allOf(toDos.toArray(new CompletableFuture[toDos.size()])).join();
+
+ // Summary
+ StringBuilder sb = new StringBuilder();
+ for (String licenseId : licensesUsed.keySet())
+ for (String name : licensesUsed.get(licenseId))
+ sb.append((licenseId.equals("") ? "Proprietary" : licenseId) + "\t\t" + name + "\n");
+ logger.log(INFO, "# License summary:\n" + sb);
}
- private final static String COMMON_BND = "common.bnd";
- private final static String MERGE_BND = "merge.bnd";
+ /** Name of the file centralising information for multiple M2 artifacts. */
+ final static String COMMON_BND = "common.bnd";
+ /** Name of the file centralising information for mergin M2 artifacts. */
+ final static String MERGE_BND = "merge.bnd";
+ /**
+ * Subdirectory of the jar file where origin informations (changes, legal
+ * notices etc. are stored)
+ */
+ final static String A2_ORIGIN = "A2-ORIGIN";
/** Directory where to download archives */
- private Path originBase;
+ Path originBase;
/** Directory where to download Maven artifacts */
- private Path mavenBase;
+ Path mavenBase;
/** A2 repository base for binary bundles */
- private Path a2Base;
+ Path a2Base;
/** A2 repository base for source bundles */
- private Path a2SrcBase;
+ Path a2SrcBase;
/** A2 base for native components */
- private Path a2LibBase;
+ Path a2LibBase;
/** Location of the descriptors driving the packaging */
- private Path descriptorsBase;
+ Path descriptorsBase;
/** URIs of archives to download */
- private Properties uris = new Properties();
+ Properties uris = new Properties();
/** Mirrors for archive download. Key is URI prefix, value list of base URLs */
- private Map<String, List<String>> mirrors = new HashMap<String, List<String>>();
+ Map<String, List<String>> mirrors = new HashMap<String, List<String>>();
/** Whether sources should be packaged separately */
- private final boolean sourceBundles;
+ final boolean sourceBundles;
/** Constructor initialises the various variables */
public Repackage(Path a2Base, Path descriptorsBase) {
* MAVEN ORIGIN
*/
/** Process a whole category/group id. */
- public void processCategory(Path categoryRelativePath) {
+ void processCategory(Path categoryRelativePath) {
try {
Path targetCategoryBase = descriptorsBase.resolve(categoryRelativePath);
DirectoryStream<Path> bnds = Files.newDirectoryStream(targetCategoryBase,
}
/** Process a standalone Maven artifact. */
- public void processSingleM2ArtifactDistributionUnit(Path bndFile) {
+ void processSingleM2ArtifactDistributionUnit(Path bndFile) {
try {
Path categoryRelativePath = descriptorsBase.relativize(bndFile.getParent());
Path targetCategoryBase = a2Base.resolve(categoryRelativePath);
URL url = M2ConventionsUtils.mavenRepoUrl(repoStr, artifact);
Path downloaded = downloadMaven(url, artifact);
- Path targetBundleDir = processBndJar(downloaded, targetCategoryBase, fileProps, artifact);
+ A2Origin origin = new A2Origin();
+ Path targetBundleDir = processBndJar(downloaded, targetCategoryBase, fileProps, artifact, origin);
downloadAndProcessM2Sources(repoStr, artifact, targetBundleDir);
- createJar(targetBundleDir);
+ createJar(targetBundleDir, origin);
} catch (Exception e) {
throw new RuntimeException("Cannot process " + bndFile, e);
}
}
- /** Process multiple Maven artifacts. */
- public void processM2BasedDistributionUnit(Path duDir) {
+ /**
+ * Process multiple Maven artifacts coming from a same project and therefore
+ * with information in common (typically the version), generating single bundles
+ * or merging them if necessary.
+ */
+ void processM2BasedDistributionUnit(Path duDir) {
try {
Path categoryRelativePath = descriptorsBase.relativize(duDir.getParent());
Path targetCategoryBase = a2Base.resolve(categoryRelativePath);
mergeProps.putAll(commonProps);
fileEntries: for (Object key : fileProps.keySet()) {
- if (ManifestConstants.ARGEO_ORIGIN_M2.toString().equals(key))
+ if (ARGEO_ORIGIN_M2.toString().equals(key))
continue fileEntries;
String value = fileProps.getProperty(key.toString());
Object previousValue = mergeProps.put(key.toString(), value);
commonBnd + ": " + key + " was " + previousValue + ", overridden with " + value);
}
}
- mergeProps.put(ManifestConstants.ARGEO_ORIGIN_M2.toString(), artifact.toM2Coordinates());
+ mergeProps.put(ARGEO_ORIGIN_M2.toString(), artifact.toM2Coordinates());
if (!mergeProps.containsKey(BUNDLE_SYMBOLICNAME.toString())) {
// use file name as symbolic name
String symbolicName = p.getFileName().toString();
URL url = M2ConventionsUtils.mavenRepoUrl(repoStr, artifact);
Path downloaded = downloadMaven(url, artifact);
- Path targetBundleDir = processBndJar(downloaded, targetCategoryBase, mergeProps, artifact);
+ A2Origin origin = new A2Origin();
+ Path targetBundleDir = processBndJar(downloaded, targetCategoryBase, mergeProps, artifact, origin);
downloadAndProcessM2Sources(repoStr, artifact, targetBundleDir);
- createJar(targetBundleDir);
+ createJar(targetBundleDir, origin);
}
} catch (IOException e) {
throw new RuntimeException("Cannot process " + duDir, e);
}
/** Merge multiple Maven artifacts. */
- protected void mergeM2Artifacts(Path mergeBnd) throws IOException {
+ void mergeM2Artifacts(Path mergeBnd) throws IOException {
Path duDir = mergeBnd.getParent();
String category = duDir.getParent().getFileName().toString();
Path targetCategoryBase = a2Base.resolve(category);
throw new IllegalStateException("Only the M2 version can be specified: " + m2Version);
}
m2Version = m2Version.substring(1);
- mergeProps.put(ManifestConstants.BUNDLE_VERSION.toString(), m2Version);
+ mergeProps.put(BUNDLE_VERSION.toString(), m2Version);
- String artifactsStr = mergeProps.getProperty(ManifestConstants.ARGEO_ORIGIN_M2_MERGE.toString());
+ String artifactsStr = mergeProps.getProperty(ARGEO_ORIGIN_M2_MERGE.toString());
if (artifactsStr == null)
- throw new IllegalArgumentException(
- mergeBnd + ": " + ManifestConstants.ARGEO_ORIGIN_M2_MERGE + " must be set");
+ throw new IllegalArgumentException(mergeBnd + ": " + ARGEO_ORIGIN_M2_MERGE + " must be set");
String repoStr = mergeProps.containsKey(ARGEO_ORIGIN_M2_REPO.toString())
? mergeProps.getProperty(ARGEO_ORIGIN_M2_REPO.toString())
: null;
- String bundleSymbolicName = mergeProps.getProperty(ManifestConstants.BUNDLE_SYMBOLICNAME.toString());
+ String bundleSymbolicName = mergeProps.getProperty(BUNDLE_SYMBOLICNAME.toString());
if (bundleSymbolicName == null)
throw new IllegalArgumentException("Bundle-SymbolicName must be set in " + mergeBnd);
CategoryNameVersion nameVersion = new M2Artifact(category + ":" + bundleSymbolicName + ":" + m2Version);
- Path targetBundleDir = targetCategoryBase.resolve(bundleSymbolicName + "." + nameVersion.getBranch());
+ A2Origin origin = new A2Origin();
+ Path bundleDir = targetCategoryBase.resolve(bundleSymbolicName + "." + nameVersion.getBranch());
String[] artifacts = artifactsStr.split(",");
artifacts: for (String str : artifacts) {
entries: while ((entry = jarIn.getNextJarEntry()) != null) {
if (entry.isDirectory())
continue entries;
- else if (entry.getName().endsWith(".RSA") || entry.getName().endsWith(".SF"))
+ if (entry.getName().endsWith(".RSA") || entry.getName().endsWith(".SF")) {
+ origin.deleted.add("cryptographic signatures from " + artifact);
continue entries;
- else if (entry.getName().startsWith("META-INF/versions/"))
- continue entries;
- else if (entry.getName().startsWith("META-INF/maven/"))
- continue entries;
- else if (entry.getName().equals("module-info.class"))
- continue entries;
- else if (entry.getName().equals("META-INF/NOTICE"))
- continue entries;
- else if (entry.getName().equals("META-INF/NOTICE.txt"))
+ }
+ if (entry.getName().endsWith("module-info.class")) { // skip Java 9 module info
+ origin.deleted.add("Java module information (module-info.class) from " + artifact);
continue entries;
- else if (entry.getName().equals("META-INF/LICENSE"))
+ }
+ if (entry.getName().startsWith("META-INF/versions/")) { // skip multi-version
+ origin.deleted.add("additional Java versions (META-INF/versions) from " + artifact);
continue entries;
- else if (entry.getName().equals("META-INF/LICENSE.md"))
+ }
+ if (entry.getName().equals("META-INF/DEPENDENCIES")) {
+ origin.deleted.add("dependency list (META-INF/DEPENDENCIES) from " + artifact);
continue entries;
- else if (entry.getName().equals("META-INF/LICENSE-notice.md"))
+ }
+ if (entry.getName().startsWith("META-INF/maven/")) {
+ origin.deleted.add("Maven information (META-INF/maven) from " + artifact);
continue entries;
- else if (entry.getName().equals("META-INF/DEPENDENCIES"))
+ }
+ if (entry.getName().startsWith(".cache/")) { // Apache SSHD
+ origin.deleted.add("cache directory (.cache) from " + artifact);
continue entries;
- if (entry.getName().startsWith(".cache/")) // Apache SSHD
+ }
+
+ if (entry.getName().endsWith("NOTICE") || entry.getName().endsWith("NOTICE.txt")
+ || entry.getName().endsWith("LICENSE") || entry.getName().endsWith("LICENSE.md")
+ || entry.getName().endsWith("LICENSE-notice.md") || entry.getName().endsWith("COPYING")
+ || entry.getName().endsWith("COPYING.LESSER")) {
+ Path artifactOriginDir = bundleDir.resolve(A2_ORIGIN).resolve(artifact.getGroupId())
+ .resolve(artifact.getArtifactId());
+ Path target = artifactOriginDir.resolve(entry.getName());
+ Files.createDirectories(target.getParent());
+ Files.copy(jarIn, target);
+ origin.moved.add(entry.getName() + " in " + artifact + " to " + bundleDir.relativize(target));
continue entries;
- Path target = targetBundleDir.resolve(entry.getName());
+ }
+ Path target = bundleDir.resolve(entry.getName());
Files.createDirectories(target.getParent());
if (!Files.exists(target)) {
Files.copy(jarIn, target);
jarIn.transferTo(out);
logger.log(DEBUG, artifact.getArtifactId() + " - Appended " + entry.getName());
}
+ origin.modified.add(" " + entry.getName() + ", merging from " + artifact);
} else if (entry.getName().startsWith("org/apache/batik/")) {
logger.log(TRACE, "Skip " + entry.getName());
continue entries;
}
logger.log(TRACE, () -> "Copied " + target);
}
-
}
- downloadAndProcessM2Sources(repoStr, artifact, targetBundleDir);
+ origin.added.add("binary content of " + artifact);
+ downloadAndProcessM2Sources(repoStr, artifact, bundleDir);
}
// additional service files
Path servicesDir = duDir.resolve("services");
if (Files.exists(servicesDir)) {
for (Path p : Files.newDirectoryStream(servicesDir)) {
- Path target = targetBundleDir.resolve("META-INF/services/").resolve(p.getFileName());
+ Path target = bundleDir.resolve("META-INF/services/").resolve(p.getFileName());
try (InputStream in = Files.newInputStream(p);
OutputStream out = Files.newOutputStream(target, StandardOpenOption.APPEND);) {
out.write("\n".getBytes());
Map<String, String> entries = new TreeMap<>();
try (Analyzer bndAnalyzer = new Analyzer()) {
bndAnalyzer.setProperties(mergeProps);
- Jar jar = new Jar(targetBundleDir.toFile());
+ Jar jar = new Jar(bundleDir.toFile());
bndAnalyzer.setJar(jar);
Manifest manifest = bndAnalyzer.calcManifest();
}
Manifest manifest = new Manifest();
- Path manifestPath = targetBundleDir.resolve("META-INF/MANIFEST.MF");
+ Path manifestPath = bundleDir.resolve("META-INF/MANIFEST.MF");
Files.createDirectories(manifestPath.getParent());
for (String key : entries.keySet()) {
String value = entries.get(key);
try (OutputStream out = Files.newOutputStream(manifestPath)) {
manifest.write(out);
}
- createJar(targetBundleDir);
+ createJar(bundleDir, origin);
}
/** Generate MANIFEST using BND. */
- protected Path processBndJar(Path downloaded, Path targetCategoryBase, Properties fileProps, M2Artifact artifact) {
+ Path processBndJar(Path downloaded, Path targetCategoryBase, Properties fileProps, M2Artifact artifact,
+ A2Origin origin) {
try {
Map<String, String> additionalEntries = new TreeMap<>();
boolean doNotModify = Boolean.parseBoolean(fileProps
.getOrDefault(ManifestConstants.ARGEO_ORIGIN_MANIFEST_NOT_MODIFIED.toString(), "false").toString());
- // we always force the symbolic name
-
+ // Note: we always force the symbolic name
if (doNotModify) {
fileEntries: for (Object key : fileProps.keySet()) {
if (ManifestConstants.ARGEO_ORIGIN_M2.toString().equals(key))
}
if ("Require-Capability".equals(key.toString())
&& value.toString().equals("osgi.ee;filter:=\"(&(osgi.ee=JavaSE)(version=1.1))\""))
- continue keys;// hack for very old classes
+ continue keys;// !! hack for very old classes
additionalEntries.put(key.toString(), value.toString());
- // logger.log(DEBUG, () -> key + "=" + value);
-
}
}
}
- Path targetBundleDir = processBundleJar(downloaded, targetCategoryBase, additionalEntries);
+ Path targetBundleDir = processBundleJar(downloaded, targetCategoryBase, additionalEntries, origin);
logger.log(DEBUG, () -> "Processed " + downloaded);
return targetBundleDir;
} catch (Exception e) {
}
/** Download and integrates sources for a single Maven artifact. */
- protected void downloadAndProcessM2Sources(String repoStr, M2Artifact artifact, Path targetBundleDir)
- throws IOException {
+ void downloadAndProcessM2Sources(String repoStr, M2Artifact artifact, Path targetBundleDir) throws IOException {
try {
M2Artifact sourcesArtifact = new M2Artifact(artifact.toM2Coordinates(), "sources");
URL sourcesUrl = M2ConventionsUtils.mavenRepoUrl(repoStr, sourcesArtifact);
}
/** Integrate sources from a downloaded jar file. */
- protected void processM2SourceJar(Path file, Path targetBundleDir) throws IOException {
+ void processM2SourceJar(Path file, Path bundleDir) throws IOException {
try (JarInputStream jarIn = new JarInputStream(Files.newInputStream(file), false)) {
- Path targetSourceDir = sourceBundles
- ? targetBundleDir.getParent().resolve(targetBundleDir.toString() + ".src")
- : targetBundleDir.resolve("OSGI-OPT/src");
+ A2Origin origin = new A2Origin();
+ Path sourceDir = sourceBundles ? bundleDir.getParent().resolve(bundleDir.toString() + ".src")
+ : bundleDir.resolve("OSGI-OPT/src");
- Files.createDirectories(targetSourceDir);
+ Files.createDirectories(sourceDir);
JarEntry entry;
entries: while ((entry = jarIn.getNextJarEntry()) != null) {
if (entry.isDirectory())
continue entries;
- if (entry.getName().startsWith("META-INF"))// skip META-INF entries
+ if (entry.getName().startsWith("META-INF")) {// skip META-INF entries
+ origin.deleted.add("META-INF directory from the sources");
continue entries;
- if (entry.getName().startsWith("module-info.java"))// skip META-INF entries
+ }
+ if (entry.getName().startsWith("module-info.java")) {// skip Java module information
+ origin.deleted.add("Java module information from the sources (module-info.java)");
continue entries;
- if (entry.getName().startsWith("/")) // absolute paths
+ }
+ if (entry.getName().startsWith("/")) { // absolute paths
+ // TODO does it really happen?
+ logger.log(WARNING, entry.getName() + " has an absolute path");
+ origin.deleted.add(entry.getName() + " from the sources");
continue entries;
- Path target = targetSourceDir.resolve(entry.getName());
+ }
+ Path target = sourceDir.resolve(entry.getName());
Files.createDirectories(target.getParent());
if (!Files.exists(target)) {
Files.copy(jarIn, target);
logger.log(TRACE, () -> target + " already exists, skipping...");
}
}
+ // write the changes
+ if (sourceBundles) {
+ origin.appendChanges(sourceDir);
+ } else {
+ origin.added.add("source code under OSGI-OPT/src");
+ origin.appendChanges(bundleDir);
+ }
}
}
/** Download a Maven artifact. */
- protected Path downloadMaven(URL url, M2Artifact artifact) throws IOException {
+ Path downloadMaven(URL url, M2Artifact artifact) throws IOException {
return downloadMaven(url, artifact, false);
}
/** Download a Maven artifact. */
- protected Path downloadMaven(URL url, M2Artifact artifact, boolean sources) throws IOException {
+ Path downloadMaven(URL url, M2Artifact artifact, boolean sources) throws IOException {
return download(url, mavenBase, artifact.getGroupId().replace(".", "/") //
+ '/' + artifact.getArtifactId() + '/' + artifact.getVersion() //
+ '/' + artifact.getArtifactId() + "-" + artifact.getVersion() + (sources ? "-sources" : "") + ".jar");
* ECLIPSE ORIGIN
*/
/** Process an archive in Eclipse format. */
- public void processEclipseArchive(Path duDir) {
+ void processEclipseArchive(Path duDir) {
try {
Path categoryRelativePath = descriptorsBase.relativize(duDir.getParent());
Path targetCategoryBase = a2Base.resolve(categoryRelativePath);
try (InputStream in = Files.newInputStream(commonBnd)) {
commonProps.load(in);
}
- String url = commonProps.getProperty(ManifestConstants.ARGEO_ORIGIN_URI.toString());
+ String url = commonProps.getProperty(ARGEO_ORIGIN_URI.toString());
if (url == null) {
url = uris.getProperty(duDir.getFileName().toString());
if (url == null)
throw new IllegalStateException("No url available for " + duDir);
- commonProps.put(ManifestConstants.ARGEO_ORIGIN_URI.toString(), url);
+ commonProps.put(ARGEO_ORIGIN_URI.toString(), url);
}
Path downloaded = tryDownloadArchive(url, originBase);
}
}
+ // keys are the bundle directories
+ Map<Path, A2Origin> origins = new HashMap<>();
Files.walkFileTree(zipFs.getRootDirectories().iterator().next(), new SimpleFileVisitor<Path>() {
@Override
Map<String, String> map = new HashMap<>();
for (Object key : commonProps.keySet())
map.put(key.toString(), commonProps.getProperty(key.toString()));
- processBundleJar(file, targetCategoryBase, map);
+ A2Origin origin = new A2Origin();
+ Path bundleDirectory = processBundleJar(file, targetCategoryBase, map, origin);
+ origins.put(bundleDirectory, origin);
logger.log(DEBUG, () -> "Processed " + file);
}
break includeMatchers;
DirectoryStream<Path> dirs = Files.newDirectoryStream(targetCategoryBase, (p) -> Files.isDirectory(p)
&& p.getFileName().toString().indexOf('.') >= 0 && !p.getFileName().toString().endsWith(".src"));
for (Path dir : dirs) {
- createJar(dir);
+ A2Origin origin = origins.get(dir);
+ Objects.requireNonNull(origin, "No A2 origin found for " + dir);
+ createJar(dir, origin);
}
} catch (IOException e) {
throw new RuntimeException("Cannot process " + duDir, e);
}
/** Process sources in Eclipse format. */
- protected void processEclipseSourceJar(Path file, Path targetBase) throws IOException {
+ void processEclipseSourceJar(Path file, Path targetBase) throws IOException {
try {
Path targetBundleDir;
try (JarInputStream jarIn = new JarInputStream(Files.newInputStream(file), false)) {
Manifest manifest = jarIn.getManifest();
- String[] relatedBundle = manifest.getMainAttributes().getValue("Eclipse-SourceBundle").split(";");
+ String[] relatedBundle = manifest.getMainAttributes().getValue(ECLIPSE_SOURCE_BUNDLE.toString())
+ .split(";");
String version = relatedBundle[1].substring("version=\"".length());
version = version.substring(0, version.length() - 1);
NameVersion nameVersion = new NameVersion(relatedBundle[0], version);
* COMMON PROCESSING
*/
/** Normalise a bundle. */
- protected Path processBundleJar(Path file, Path targetBase, Map<String, String> entries) throws IOException {
+ Path processBundleJar(Path file, Path targetBase, Map<String, String> entries, A2Origin origin) throws IOException {
NameVersion nameVersion;
- Path targetBundleDir;
+ Path bundleDir;
try (JarInputStream jarIn = new JarInputStream(Files.newInputStream(file), false)) {
Manifest sourceManifest = jarIn.getManifest();
Manifest manifest = sourceManifest != null ? new Manifest(sourceManifest) : new Manifest();
// singleton
boolean isSingleton = false;
- String rawSourceSymbolicName = manifest.getMainAttributes()
- .getValue(ManifestConstants.BUNDLE_SYMBOLICNAME.toString());
+ String rawSourceSymbolicName = manifest.getMainAttributes().getValue(BUNDLE_SYMBOLICNAME.toString());
if (rawSourceSymbolicName != null) {
// make sure there is no directive
String[] arr = rawSourceSymbolicName.split(";");
nameVersion.setName(ourSymbolicName);
}
}
- targetBundleDir = targetBase.resolve(nameVersion.getName() + "." + nameVersion.getBranch());
+ bundleDir = targetBase.resolve(nameVersion.getName() + "." + nameVersion.getBranch());
// force Java 9 module name
entries.put(ManifestConstants.AUTOMATIC_MODULE_NAME.toString(), nameVersion.getName());
boolean isNative = false;
String os = null;
String arch = null;
- if (targetBundleDir.startsWith(a2LibBase)) {
+ if (bundleDir.startsWith(a2LibBase)) {
isNative = true;
- Path libRelativePath = a2LibBase.relativize(targetBundleDir);
+ Path libRelativePath = a2LibBase.relativize(bundleDir);
os = libRelativePath.getName(0).toString();
arch = libRelativePath.getName(1).toString();
}
entries: while ((entry = jarIn.getNextJarEntry()) != null) {
if (entry.isDirectory())
continue entries;
- if (entry.getName().endsWith(".RSA") || entry.getName().endsWith(".SF"))
+ if (entry.getName().endsWith(".RSA") || entry.getName().endsWith(".SF")) {
+ origin.deleted.add("cryptographic signatures");
continue entries;
- if (entry.getName().endsWith("module-info.class")) // skip Java 9 module info
+ }
+ if (entry.getName().endsWith("module-info.class")) { // skip Java 9 module info
+ origin.deleted.add("Java module information (module-info.class)");
continue entries;
- if (entry.getName().startsWith("META-INF/versions/")) // skip multi-version
+ }
+ if (entry.getName().startsWith("META-INF/versions/")) { // skip multi-version
+ origin.deleted.add("additional Java versions (META-INF/versions)");
continue entries;
+ }
// skip file system providers as they cause issues with native image
- if (entry.getName().startsWith("META-INF/services/java.nio.file.spi.FileSystemProvider"))
+ if (entry.getName().startsWith("META-INF/services/java.nio.file.spi.FileSystemProvider")) {
+ origin.deleted
+ .add("file system providers (META-INF/services/java.nio.file.spi.FileSystemProvider)");
continue entries;
- if (entry.getName().startsWith("OSGI-OPT/src/")) // skip embedded sources
+ }
+ if (entry.getName().startsWith("OSGI-OPT/src/")) { // skip embedded sources
+ origin.deleted.add("embedded sources");
continue entries;
- Path target = targetBundleDir.resolve(entry.getName());
+ }
+ Path target = bundleDir.resolve(entry.getName());
Files.createDirectories(target.getParent());
Files.copy(jarIn, target);
// native libraries
if (isNative && (entry.getName().endsWith(".so") || entry.getName().endsWith(".dll")
|| entry.getName().endsWith(".jnilib"))) {
- Path categoryDir = targetBundleDir.getParent();
+ Path categoryDir = bundleDir.getParent();
boolean copyDll = false;
- Path targetDll = categoryDir.resolve(targetBundleDir.relativize(target));
+ Path targetDll = categoryDir.resolve(bundleDir.relativize(target));
if (nameVersion.getName().equals("com.sun.jna")) {
if (arch.equals("x86_64"))
arch = "x86-64";
}
// copy MANIFEST
- Path manifestPath = targetBundleDir.resolve("META-INF/MANIFEST.MF");
+ Path manifestPath = bundleDir.resolve("META-INF/MANIFEST.MF");
Files.createDirectories(manifestPath.getParent());
if (isSingleton && entries.containsKey(BUNDLE_SYMBOLICNAME.toString())) {
entries.get(BUNDLE_SYMBOLICNAME.toString()) + ";singleton:=true");
}
+ // Final MANIFEST decisions
+ // This also where we check the original OSGi metadata and compare with our
+ // changes
for (String key : entries.keySet()) {
String value = entries.get(key);
- Object previousValue = manifest.getMainAttributes().putValue(key, value);
- if (previousValue != null && !previousValue.equals(value)) {
- if (ManifestConstants.IMPORT_PACKAGE.toString().equals(key)
- || ManifestConstants.EXPORT_PACKAGE.toString().equals(key))
- logger.log(TRACE, file.getFileName() + ": " + key + " was modified");
+ String previousValue = manifest.getMainAttributes().getValue(key);
+ boolean wasDifferent = previousValue != null && !previousValue.equals(value);
+ boolean keepPrevious = false;
+ if (wasDifferent) {
+ if (SPDX_LICENSE_IDENTIFIER.toString().equals(key) && previousValue != null)
+ keepPrevious = true;
+ else if (BUNDLE_VERSION.toString().equals(key) && wasDifferent)
+ if (previousValue.equals(value + ".0")) // typically a Maven first release
+ keepPrevious = true;
+
+ if (keepPrevious) {
+ if (logger.isLoggable(DEBUG))
+ logger.log(DEBUG, file.getFileName() + ": " + key + " was NOT modified, value kept is "
+ + previousValue + ", not overriden with " + value);
+ value = previousValue;
+ }
+ }
+
+ manifest.getMainAttributes().putValue(key, value);
+ if (wasDifferent && !keepPrevious) {
+ if (IMPORT_PACKAGE.toString().equals(key) || EXPORT_PACKAGE.toString().equals(key))
+ logger.log(TRACE, () -> file.getFileName() + ": " + key + " was modified");
else
logger.log(WARNING, file.getFileName() + ": " + key + " was " + previousValue
+ ", overridden with " + value);
manifest.getMainAttributes().remove(key);
}
}
+
+ // license checks
+ String spdxLicenceId = manifest.getMainAttributes().getValue(SPDX_LICENSE_IDENTIFIER.toString());
+ String bundleLicense = manifest.getMainAttributes().getValue(BUNDLE_LICENSE.toString());
+ if (spdxLicenceId == null) {
+ logger.log(ERROR, file.getFileName() + ": " + SPDX_LICENSE_IDENTIFIER + " not available, "
+ + BUNDLE_LICENSE + " is " + bundleLicense);
+ } else {
+ if (!licensesUsed.containsKey(spdxLicenceId))
+ licensesUsed.put(spdxLicenceId, new TreeSet<>());
+ licensesUsed.get(spdxLicenceId).add(nameVersion.toString());
+ }
+
+ // write the MANIFEST
try (OutputStream out = Files.newOutputStream(manifestPath)) {
manifest.write(out);
}
}
- return targetBundleDir;
+ origin.modified.add("jar MANIFEST (META-INF/MANIFEST.MF");
+ return bundleDir;
}
/*
* UTILITIES
*/
/** Recursively deletes a directory. */
- private static void deleteDirectory(Path path) throws IOException {
+ static void deleteDirectory(Path path) throws IOException {
if (!Files.exists(path))
return;
Files.walkFileTree(path, new SimpleFileVisitor<Path>() {
}
/** Extract name/version from a MANIFEST. */
- protected NameVersion nameVersionFromManifest(Manifest manifest) {
+ NameVersion nameVersionFromManifest(Manifest manifest) {
Attributes attrs = manifest.getMainAttributes();
// symbolic name
String symbolicName = attrs.getValue(ManifestConstants.BUNDLE_SYMBOLICNAME.toString());
}
/** Try to download from an URI. */
- protected Path tryDownloadArchive(String uri, Path dir) throws IOException {
+ Path tryDownloadArchive(String uri, Path dir) throws IOException {
// find mirror
List<String> urlBases = null;
String uriPrefix = null;
* Effectively download. Synchronised in order to avoid downloading twice in
* parallel.
*/
- protected synchronized Path downloadArchive(URL url, Path dir) throws IOException {
+ synchronized Path downloadArchive(URL url, Path dir) throws IOException {
return download(url, dir, (String) null);
}
/** Effectively download. */
- protected Path download(URL url, Path dir, String name) throws IOException {
+ Path download(URL url, Path dir, String name) throws IOException {
Path dest;
if (name == null) {
}
/** Create a JAR file from a directory. */
- protected Path createJar(Path bundleDir) throws IOException {
+ Path createJar(Path bundleDir, A2Origin origin) throws IOException {
+ // write changes
+ origin.appendChanges(bundleDir);
// Create the jar
Path jarPath = bundleDir.getParent().resolve(bundleDir.getFileName() + ".jar");
Path manifestPath = bundleDir.resolve("META-INF/MANIFEST.MF");
// in case there are additional directives
bundleSymbolicName = bundleSymbolicName.split(";")[0];
Manifest srcManifest = new Manifest();
- srcManifest.getMainAttributes().put(Attributes.Name.MANIFEST_VERSION, "1.0");
- srcManifest.getMainAttributes().putValue("Bundle-SymbolicName", bundleSymbolicName + ".src");
- srcManifest.getMainAttributes().putValue("Bundle-Version",
- manifest.getMainAttributes().getValue("Bundle-Version").toString());
- srcManifest.getMainAttributes().putValue("Eclipse-SourceBundle",
- bundleSymbolicName + ";version=\"" + manifest.getMainAttributes().getValue("Bundle-Version"));
+ srcManifest.getMainAttributes().put(MANIFEST_VERSION, "1.0");
+ srcManifest.getMainAttributes().putValue(BUNDLE_SYMBOLICNAME.toString(), bundleSymbolicName + ".src");
+ srcManifest.getMainAttributes().putValue(BUNDLE_VERSION.toString(),
+ manifest.getMainAttributes().getValue(BUNDLE_VERSION.toString()).toString());
+ srcManifest.getMainAttributes().putValue(ECLIPSE_SOURCE_BUNDLE.toString(), bundleSymbolicName
+ + ";version=\"" + manifest.getMainAttributes().getValue(BUNDLE_VERSION.toString()));
try (JarOutputStream srcJarOut = new JarOutputStream(Files.newOutputStream(srcJarP), srcManifest)) {
srcJarOut.setLevel(Deflater.BEST_COMPRESSION);
BUNDLE_SYMBOLICNAME("Bundle-SymbolicName"), //
/** OSGi bundle version. */
BUNDLE_VERSION("Bundle-Version"), //
-// BUNDLE_LICENSE("Bundle-License"), //
+ /** OSGi bundle license. */
+ BUNDLE_LICENSE("Bundle-License"), //
/** OSGi exported packages list. */
EXPORT_PACKAGE("Export-Package"), //
/** OSGi imported packages list. */
// Java
/** Java module name. */
AUTOMATIC_MODULE_NAME("Automatic-Module-Name"), //
+ // Eclipse
+ /** Eclipse source bundle. */
+ ECLIPSE_SOURCE_BUNDLE("Eclipse-SourceBundle"), //
+ // SPDX
+ /**
+ * SPDX license identifier.
+ *
+ * @see https://spdx.org/licenses/
+ */
+ SPDX_LICENSE_IDENTIFIER("SPDX-License-Identifier"), //
// Argeo Origin
/**
* Maven coordinates of the origin, possibly partial when using common.bnd or
ARGEO_ORIGIN_M2("Argeo-Origin-M2"), //
/** List of Maven coordinates to merge. */
ARGEO_ORIGIN_M2_MERGE("Argeo-Origin-M2-Merge"), //
- /** Maven repository if not the default one. */
+ /** Maven repository, if not the default one. */
ARGEO_ORIGIN_M2_REPO("Argeo-Origin-M2-Repo"), //
/**
* Do not perform BND analysis of the origin component. Typically IMport_package
}
}
+/**
+ * Gathers modifications performed on the original binaries and sources,
+ * especially in order to comply with their license requirements.
+ */
+class A2Origin {
+ Set<String> modified = new TreeSet<>();
+ Set<String> deleted = new TreeSet<>();
+ Set<String> added = new TreeSet<>();
+ Set<String> moved = new TreeSet<>();
+
+ /** Append changes to the A2-ORIGIN/changes file. */
+ void appendChanges(Path baseDirectory) throws IOException {
+ Path changesFile = baseDirectory.resolve("A2-ORIGIN/changes");
+ Files.createDirectories(changesFile.getParent());
+ try (BufferedWriter writer = Files.newBufferedWriter(changesFile, StandardOpenOption.APPEND,
+ StandardOpenOption.CREATE)) {
+ for (String msg : modified)
+ writer.write("- Modified " + msg + ".\n");
+ for (String msg : added)
+ writer.write("- Added " + msg + ".\n");
+ for (String msg : deleted)
+ writer.write("- Deleted " + msg + ".\n");
+ for (String msg : moved)
+ writer.write("- Moved " + msg + ".\n");
+ }
+ }
+}
+
/** Simple representation of an M2 artifact. */
class M2Artifact extends CategoryNameVersion {
private String classifier;