]> git.argeo.org Git - lgpl/argeo-commons.git/blobdiff - server/runtime/org.argeo.server.jackrabbit/src/main/java/org/argeo/jackrabbit/remote/SimpleSessionProvider.java
Fix NPE when TRACE logging is activated
[lgpl/argeo-commons.git] / server / runtime / org.argeo.server.jackrabbit / src / main / java / org / argeo / jackrabbit / remote / SimpleSessionProvider.java
index 8e8b1d945ce22f2c7a3883d74cfc0f6673150b57..1d438d5044561218e0dd6258f4656495d3794c53 100644 (file)
@@ -1,3 +1,18 @@
+/*
+ * Copyright (C) 2007-2012 Argeo GmbH
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.argeo.jackrabbit.remote;
 
 import java.io.Serializable;
@@ -27,11 +42,16 @@ import org.apache.jackrabbit.server.SessionProvider;
 import org.argeo.ArgeoException;
 import org.argeo.jcr.ArgeoNames;
 import org.argeo.jcr.JcrUtils;
+import org.argeo.jcr.UserJcrUtils;
 
 /**
- * To be injected, typically of scope="session". Implements an open session in
- * view patter: a new JCR session is created for each request
+ * Implements an open session in view patter: a new JCR session is created for
+ * each request
+ * 
+ * @deprecated use {@link ScopedSessionProvider} or
+ *             {@link OpenInViewSessionProvider}
  */
+@Deprecated
 public class SimpleSessionProvider implements SessionProvider, Serializable {
        private static final long serialVersionUID = 2270957712453841368L;
 
@@ -42,16 +62,27 @@ public class SimpleSessionProvider implements SessionProvider, Serializable {
 
        private Boolean openSessionInView = true;
 
+       private String defaultWorkspace = "default";
+
+       private String webSessionId = null;
+
        public Session getSession(HttpServletRequest request, Repository rep,
                        String workspace) throws LoginException, ServletException,
                        RepositoryException {
 
                if (openSessionInView) {
-                       JackrabbitSession session = (JackrabbitSession) rep
-                                       .login(workspace);
-                       writeRemoteRoles(session);
+                       JackrabbitSession session = (JackrabbitSession) login(request, rep,
+                                       workspace);
+                       if (session.getWorkspace().getName().equals(defaultWorkspace))
+                               writeRemoteRoles(session);
                        return session;
                } else {
+                       if (webSessionId != null
+                                       && !webSessionId.equals(request.getSession().getId()))
+                               throw new ArgeoException(
+                                               "Only session scope is supported in this mode");
+                       webSessionId = request.getSession().getId();
+
                        // since sessions is transient it can't be restored from the session
                        if (sessions == null)
                                sessions = Collections
@@ -59,9 +90,14 @@ public class SimpleSessionProvider implements SessionProvider, Serializable {
 
                        if (!sessions.containsKey(workspace)) {
                                try {
-                                       JackrabbitSession session = (JackrabbitSession) rep.login(
-                                                       null, workspace);
-                                       writeRemoteRoles(session);
+                                       // JackrabbitSession session = (JackrabbitSession)
+                                       // rep.login(
+                                       // null, workspace);
+                                       JackrabbitSession session = (JackrabbitSession) login(
+                                                       request, rep, workspace);
+                                       if (session.getWorkspace().getName()
+                                                       .equals(defaultWorkspace))
+                                               writeRemoteRoles(session);
                                        if (log.isTraceEnabled())
                                                log.trace("User " + session.getUserID()
                                                                + " logged into " + request.getServletPath());
@@ -74,7 +110,7 @@ public class SimpleSessionProvider implements SessionProvider, Serializable {
                                Session session = sessions.get(workspace);
                                if (!session.isLive()) {
                                        sessions.remove(workspace);
-                                       session = rep.login(null, workspace);
+                                       session = login(request, rep, workspace);
                                        sessions.put(workspace, session);
                                }
                                return session;
@@ -82,8 +118,19 @@ public class SimpleSessionProvider implements SessionProvider, Serializable {
                }
        }
 
+       protected Session login(HttpServletRequest request, Repository repository,
+                       String workspace) throws RepositoryException {
+               if (log.isDebugEnabled())
+                       log.debug("Login to workspace "
+                                       + (workspace == null ? "<default>" : workspace)
+                                       + " in web session " + request.getSession().getId());
+               return repository.login(workspace);
+       }
+
        protected void writeRemoteRoles(JackrabbitSession session)
                        throws RepositoryException {
+               // FIXME better deal w/ non node repo
+
                // retrieve roles
                String userId = session.getUserID();
                UserManager userManager = session.getUserManager();
@@ -98,11 +145,11 @@ public class SimpleSessionProvider implements SessionProvider, Serializable {
                                userGroupIds.add(it.next().getID());
 
                // write roles if needed
-               Node userProfile = JcrUtils.getUserProfile(session);
+               Node userHome = UserJcrUtils.getUserHome(session);
                boolean writeRoles = false;
-               if (userProfile.hasProperty(ArgeoNames.ARGEO_REMOTE_ROLES)) {
-                       Value[] roles = userProfile.getProperty(
-                                       ArgeoNames.ARGEO_REMOTE_ROLES).getValues();
+               if (userHome.hasProperty(ArgeoNames.ARGEO_REMOTE_ROLES)) {
+                       Value[] roles = userHome.getProperty(ArgeoNames.ARGEO_REMOTE_ROLES)
+                                       .getValues();
                        if (roles.length != userGroupIds.size())
                                writeRoles = true;
                        else
@@ -114,14 +161,14 @@ public class SimpleSessionProvider implements SessionProvider, Serializable {
 
                if (writeRoles) {
                        session.getWorkspace().getVersionManager()
-                                       .checkout(userProfile.getPath());
+                                       .checkout(userHome.getPath());
                        String[] roleIds = userGroupIds.toArray(new String[userGroupIds
                                        .size()]);
-                       userProfile.setProperty(ArgeoNames.ARGEO_REMOTE_ROLES, roleIds);
-                       JcrUtils.updateLastModified(userProfile);
+                       userHome.setProperty(ArgeoNames.ARGEO_REMOTE_ROLES, roleIds);
+                       JcrUtils.updateLastModified(userHome);
                        session.save();
                        session.getWorkspace().getVersionManager()
-                                       .checkin(userProfile.getPath());
+                                       .checkin(userHome.getPath());
                }
 
        }
@@ -130,26 +177,40 @@ public class SimpleSessionProvider implements SessionProvider, Serializable {
                if (log.isTraceEnabled())
                        log.trace("Releasing JCR session " + session);
                if (openSessionInView) {
-                       if (session.isLive()) {
-                               session.logout();
-                               if (log.isTraceEnabled())
-                                       log.trace("Logged out remote JCR session " + session);
-                       }
+                       JcrUtils.logoutQuietly(session);
+                       if (log.isDebugEnabled())
+                               log.debug("Logged out remote JCR session " + session);
                }
        }
 
        public void init() {
+               if (log.isDebugEnabled())
+                       log.debug("Init session provider for web session " + webSessionId);
        }
 
-       public void dispose() {
+       public void destroy() {
+               if (log.isDebugEnabled())
+                       log.debug("Destroy session provider for web session "
+                                       + webSessionId);
+
                if (sessions != null)
                        for (String workspace : sessions.keySet()) {
                                Session session = sessions.get(workspace);
-                               if (session.isLive()) {
-                                       session.logout();
-                                       if (log.isDebugEnabled())
-                                               log.debug("Logged out remote JCR session " + session);
-                               }
+                               JcrUtils.logoutQuietly(session);
                        }
        }
+
+       /**
+        * If set to true a new session will be created each time (the default),
+        * otherwise a single session is cached by workspace and the object should
+        * be of scope session (not supported)
+        */
+       public void setOpenSessionInView(Boolean openSessionInView) {
+               this.openSessionInView = openSessionInView;
+       }
+
+       public void setSecurityWorkspace(String securityWorkspace) {
+               this.defaultWorkspace = securityWorkspace;
+       }
+
 }