Improve user admin perspective
[lgpl/argeo-commons.git] / org.argeo.cms.ui.workbench / src / org / argeo / cms / ui / workbench / internal / useradmin / parts / GroupMainPage.java
index e5c01b1435a6bae02a00abd84ac9432ee16880db..2103ec9ada5f0021aeb09d7463a0db5cf5f77f9a 100644 (file)
@@ -23,10 +23,11 @@ import javax.jcr.Node;
 import javax.jcr.Repository;
 import javax.jcr.RepositoryException;
 import javax.jcr.Session;
-import javax.jcr.nodetype.NodeType;
-import javax.jcr.security.Privilege;
+import javax.naming.InvalidNameException;
+import javax.naming.ldap.LdapName;
 import javax.transaction.UserTransaction;
 
+import org.argeo.cms.ArgeoNames;
 import org.argeo.cms.CmsException;
 import org.argeo.cms.ui.workbench.CmsWorkbenchStyles;
 import org.argeo.cms.ui.workbench.internal.useradmin.SecurityAdminImages;
@@ -37,7 +38,6 @@ import org.argeo.cms.ui.workbench.internal.useradmin.providers.CommonNameLP;
 import org.argeo.cms.ui.workbench.internal.useradmin.providers.MailLP;
 import org.argeo.cms.ui.workbench.internal.useradmin.providers.RoleIconLP;
 import org.argeo.cms.ui.workbench.internal.useradmin.providers.UserFilter;
-import org.argeo.cms.ui.workbench.internal.useradmin.providers.UserNameLP;
 import org.argeo.cms.ui.workbench.internal.useradmin.providers.UserTableDefaultDClickListener;
 import org.argeo.cms.util.CmsUtils;
 import org.argeo.cms.util.UserAdminUtils;
@@ -46,9 +46,7 @@ import org.argeo.eclipse.ui.EclipseUiUtils;
 import org.argeo.eclipse.ui.parts.LdifUsersTable;
 import org.argeo.jcr.JcrUtils;
 import org.argeo.naming.LdapAttrs;
-import org.argeo.node.ArgeoNames;
-import org.argeo.node.NodeNames;
-import org.argeo.node.NodeTypes;
+import org.argeo.node.NodeInstance;
 import org.argeo.node.NodeUtils;
 import org.eclipse.jface.action.Action;
 import org.eclipse.jface.action.ToolBarManager;
@@ -96,10 +94,12 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
        final static String ID = "GroupEditor.mainPage";
 
        private final UserEditor editor;
-       private UserAdminWrapper userAdminWrapper;
+       private final NodeInstance nodeInstance;
+       private final UserAdminWrapper userAdminWrapper;
        private final Session session;
 
-       public GroupMainPage(FormEditor editor, UserAdminWrapper userAdminWrapper, Repository repository) {
+       public GroupMainPage(FormEditor editor, UserAdminWrapper userAdminWrapper, Repository repository,
+                       NodeInstance nodeInstance) {
                super(editor, ID, "Main");
                try {
                        session = repository.login();
@@ -108,6 +108,7 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                }
                this.editor = (UserEditor) editor;
                this.userAdminWrapper = userAdminWrapper;
+               this.nodeInstance = nodeInstance;
        }
 
        protected void createFormContent(final IManagedForm mf) {
@@ -130,18 +131,17 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
        protected void appendOverviewPart(final Composite parent, final Group group) {
                FormToolkit tk = getManagedForm().getToolkit();
                Composite body = addSection(tk, parent);
-               GridLayout layout = new GridLayout(5, false);
+               // GridLayout layout = new GridLayout(5, false);
+               GridLayout layout = new GridLayout(2, false);
                body.setLayout(layout);
 
-               final Text dnTxt = createLT(body, "DN", group.getName());
-               dnTxt.setEnabled(false);
+               String cn = UserAdminUtils.getProperty(group, LdapAttrs.cn.name());
+               Text cnTxt = createReadOnlyLT(body, "Common Name", cn);
 
-               final String cn = UserAdminUtils.getProperty(group, LdapAttrs.cn.name());
-               final Text cnTxt = createLT(body, "Common Name", cn);
-               cnTxt.setEnabled(false);
+               Text dnTxt = createReadOnlyLT(body, "DN", group.getName());
 
-               final Link markAsWorkgroupLk = new Link(body, SWT.NONE);
-               markAsWorkgroupLk.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false));
+               Link markAsWorkgroupLk = new Link(body, SWT.NONE);
+               markAsWorkgroupLk.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, false, false, 2, 1));
 
                // Label descLbl = new Label(body, SWT.LEAD);
                // descLbl.setText("Description");
@@ -154,7 +154,7 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                // descTxt.setLayoutData(gd);
 
                // create form part (controller)
-               AbstractFormPart part = new SectionPart((Section) body.getParent()) {
+               final AbstractFormPart part = new SectionPart((Section) body.getParent()) {
 
                        private MainInfoListener listener;
 
@@ -186,6 +186,7 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                                        markAsWorkgroupLk.setText("<a>Mark as workgroup</a>");
                                else
                                        markAsWorkgroupLk.setText(cn + " is already marked as being a workgroup");
+                               parent.layout(true, true);
                                super.refresh();
                        }
                };
@@ -201,32 +202,15 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                                if (confirmed) {
                                        Node workgroupHome = NodeUtils.getGroupHome(session, cn);
                                        if (workgroupHome != null)
-                                               // already marked as workgroup, do nothing
-                                               return;
-                                       else {
-                                               // Insure the session is clean to enable rollback
+                                               return; // already marked as workgroup, do nothing
+                                       else
                                                try {
-                                                       if (session.hasPendingChanges())
-                                                               MessageDialog.openError(getSite().getShell(), "Cannot create home group home",
-                                                                               "The current session is dirty. Please save and try again.");
-                                               } catch (RepositoryException e2) {
-                                                       throw new CmsException("Cannot check session state", e2);
+                                                       nodeInstance.createWorkgroup(new LdapName(group.getName()));
+                                                       part.refresh();
+                                               } catch (InvalidNameException e1) {
+                                                       throw new CmsException("Cannot create Workgroup for " + group.toString(), e1);
                                                }
-                                               try {
-                                                       // FIXME hardcoded base path
-                                                       String relPath = generateWorkgroupHomeRelPath(cn);
-                                                       Node newHome = JcrUtils.mkdirs(session.getNode("/groups"), relPath,
-                                                                       NodeType.NT_UNSTRUCTURED);
-                                                       newHome.addMixin(NodeTypes.NODE_GROUP_HOME);
-                                                       newHome.setProperty(NodeNames.LDAP_CN, cn);
-                                                       session.save();
-                                                       JcrUtils.addPrivilege(session, newHome.getPath(), group.getName(), Privilege.JCR_ALL);
-                                                       session.save();
-                                               } catch (RepositoryException e2) {
-                                                       JcrUtils.discardQuietly(session);
-                                                       throw new CmsException("Cannot check session state", e2);
-                                               }
-                                       }
+
                                }
                        }
                });
@@ -236,14 +220,7 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                getManagedForm().addPart(part);
        }
 
-       // FIXME finalise and centralise Workgroup home path management
-       private String generateWorkgroupHomeRelPath(String cn) {
-               // Dirty management of space and special characters
-               String cleanedName = cn.replaceAll("[^a-zA-Z0-9]", "_");
-               return JcrUtils.firstCharsToPath(cleanedName, 2) + '/' + cleanedName;
-       }
-
-       /** Filtered table with members. Has drag & drop ability */
+       /** Filtered table with members. Has drag and drop ability */
        protected void appendMembersPart(Composite parent, Group group) {
 
                FormToolkit tk = getManagedForm().getToolkit();
@@ -269,7 +246,8 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                columnDefs.add(new ColumnDefinition(new RoleIconLP(), "", 0, 24));
                columnDefs.add(new ColumnDefinition(new CommonNameLP(), "Common Name", 150));
                columnDefs.add(new ColumnDefinition(new MailLP(), "Primary Mail", 150));
-               columnDefs.add(new ColumnDefinition(new UserNameLP(), "Distinguished Name", 240));
+               // columnDefs.add(new ColumnDefinition(new UserNameLP(), "Distinguished Name",
+               // 240));
 
                // Create and configure the table
                LdifUsersTable userViewerCmp = new MyUserTableViewer(parent, SWT.MULTI | SWT.H_SCROLL | SWT.V_SCROLL,
@@ -308,6 +286,7 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                        Role[] roles = group.getMembers();
                        List<User> users = new ArrayList<User>();
                        userFilter.setSearchText(filter);
+                       // userFilter.setShowSystemRole(true);
                        for (Role role : roles)
                                // if (role.getType() == Role.GROUP)
                                if (userFilter.select(null, null, role))
@@ -437,7 +416,6 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
                @Override
                public void drop(DropTargetEvent event) {
                        // TODO Is there an opportunity to perform the check before?
-
                        String newUserName = (String) event.data;
                        UserAdmin myUserAdmin = userAdminWrapper.getUserAdmin();
                        Role role = myUserAdmin.getRole(newUserName);
@@ -504,14 +482,27 @@ public class GroupMainPage extends FormPage implements ArgeoNames {
        }
 
        /** Creates label and text. */
-       private Text createLT(Composite parent, String label, String value) {
+//     private Text createLT(Composite parent, String label, String value) {
+//             FormToolkit toolkit = getManagedForm().getToolkit();
+//             Label lbl = toolkit.createLabel(parent, label);
+//             lbl.setLayoutData(new GridData(SWT.LEAD, SWT.CENTER, false, false));
+//             lbl.setFont(EclipseUiUtils.getBoldFont(parent));
+//             Text text = toolkit.createText(parent, value, SWT.BORDER);
+//             text.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false));
+//             CmsUtils.style(text, CmsWorkbenchStyles.WORKBENCH_FORM_TEXT);
+//             return text;
+//     }
+//     
+       Text createReadOnlyLT(Composite parent, String label, String value) {
                FormToolkit toolkit = getManagedForm().getToolkit();
                Label lbl = toolkit.createLabel(parent, label);
                lbl.setLayoutData(new GridData(SWT.END, SWT.CENTER, false, false));
                lbl.setFont(EclipseUiUtils.getBoldFont(parent));
-               Text text = toolkit.createText(parent, value, SWT.BORDER);
+               Text text = toolkit.createText(parent, value, SWT.NONE);
                text.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false));
+               text.setEditable(false);
                CmsUtils.style(text, CmsWorkbenchStyles.WORKBENCH_FORM_TEXT);
                return text;
        }
+
 }