Add comments with some tips regarding header settings of the URL request header.

[lgpl/argeo-commons.git] / eclipse / runtime / org.argeo.eclipse.ui.rap / src / main / java / org / argeo / eclipse / ui / specific / DownloadServiceHandler.java

diff --git a/eclipse/runtime/org.argeo.eclipse.ui.rap/src/main/java/org/argeo/eclipse/ui/specific/DownloadServiceHandler.java b/eclipse/runtime/org.argeo.eclipse.ui.rap/src/main/java/org/argeo/eclipse/ui/specific/DownloadServiceHandler.java
index 0c7eac67f1415f702127d33307c4a499a1d5239b..a2f5c7ca8c934dfa1227aa4967caacff163b2228 100644 (file)
--- a/eclipse/runtime/org.argeo.eclipse.ui.rap/src/main/java/org/argeo/eclipse/ui/specific/DownloadServiceHandler.java
+++ b/eclipse/runtime/org.argeo.eclipse.ui.rap/src/main/java/org/argeo/eclipse/ui/specific/DownloadServiceHandler.java
@@ -31,7 +31,20 @@ public class DownloadServiceHandler implements IServiceHandler {
                response.setContentLength(download.length);
                String contentDisposition = "attachment; filename=\"" + fileName + "\"";
                response.setHeader("Content-Disposition", contentDisposition);
-               // response.setHeader( "Cache-Control", "no-cache" );
+
+               // Various header fields that can be set to solve some issues with some
+               // old browsers.
+               // Unused.
+               // String contentType = "application/force-download; name=\"" + fileName
+               // + "\"";
+               // response.setContentType(contentType);
+               // response.setHeader("Content-Transfer-Encoding", "binary");
+               // response.setHeader("Pragma", "no-cache");
+               // response.setHeader("Cache-Control", "no-cache, must-revalidate");
+               // response.setHeader("Expires", "0");
+               // response.setHeader("Connection", "Keep-Alive");
+               // response.setHeader("Keep-Alive", "timeout=5, max=86");
+               // response.setHeader("transfer-Encoding", "chunked");
 
                try {
                        response.getOutputStream().write(download);