Document ActiveMQ security support

git-svn-id: https://svn.argeo.org/commons/trunk@5553 4cfe0d0a-d680-48aa-b62c-e0a02a3f76cc

diff --git a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSecurityBrokerPlugin.java b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSecurityBrokerPlugin.java
index 5fd48b14ce2e8a712c449c1c3b7f4496afda00cc..3d3cbc20b1867b70b8b39e785ed9be1512ccf5cc 100644 (file)
--- a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSecurityBrokerPlugin.java
+++ b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSecurityBrokerPlugin.java
@@ -27,9 +27,10 @@ import org.springframework.security.context.SecurityContextHolder;
 import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
 
 @SuppressWarnings("unchecked")
+/** Integrates Spring Security with ActiveMQ security.*/
 public class ActiveMqSecurityBrokerPlugin extends BrokerPluginSupport {
-//     private final static Log log = LogFactory
-//                     .getLog(ActiveMqSecurityBrokerPlugin.class);
+       // private final static Log log = LogFactory
+       // .getLog(ActiveMqSecurityBrokerPlugin.class);
 
        private AuthenticationManager authenticationManager;
        private String systemUsername = InternalAuthentication.DEFAULT_SYSTEM_USERNAME;

diff --git a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSpringSecurityContext.java b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSpringSecurityContext.java
index 6492d7cd23e7440158f2d28496496d5f11e5a986..feb5ee7f968bb8928a8debbce35c27116aa9267a 100644 (file)
--- a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSpringSecurityContext.java
+++ b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/ActiveMqSpringSecurityContext.java
@@ -22,6 +22,7 @@ import java.util.Set;
 import org.springframework.security.GrantedAuthority;
 import org.springframework.security.context.SecurityContext;
 
+/** An ActiveMQ security context compatible with Spring Security. */
 public class ActiveMqSpringSecurityContext extends
                org.apache.activemq.security.SecurityContext {
 
@@ -34,8 +35,8 @@ public class ActiveMqSpringSecurityContext extends
 
        @Override
        public Set<?> getPrincipals() {
-               return new HashSet<GrantedAuthority>(Arrays
-                               .asList(springSecurityContext.getAuthentication()
+               return new HashSet<GrantedAuthority>(
+                               Arrays.asList(springSecurityContext.getAuthentication()
                                                .getAuthorities()));
        }
 

diff --git a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/SecuredActiveMqConnectionFactory.java b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/SecuredActiveMqConnectionFactory.java
index 551cd1357faace7a5eb66d1d085eb730d0fb5a40..206d468eeb956c9dd74f90bec42594faef088d7f 100644 (file)
--- a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/SecuredActiveMqConnectionFactory.java
+++ b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/SecuredActiveMqConnectionFactory.java
@@ -38,6 +38,7 @@ import org.springframework.core.io.Resource;
 import org.springframework.jms.connection.CachingConnectionFactory;
 import org.springframework.jms.connection.UserCredentialsConnectionFactoryAdapter;
 
+/** An ActiveMQ connection factory managing secure connections. */
 public class SecuredActiveMqConnectionFactory implements ConnectionFactory,
                InitializingBean, DisposableBean {
 

diff --git a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/UserPasswordDialog.java b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/UserPasswordDialog.java
index 0b60c7b0f461462290e1a2344f9e37bc36f5a0c4..38b8ee85cf6c42e3742620b5c14445f035fdf64c 100644 (file)
--- a/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/UserPasswordDialog.java
+++ b/security/runtime/org.argeo.security.activemq/src/main/java/org/argeo/security/activemq/UserPasswordDialog.java
@@ -30,6 +30,10 @@ import javax.swing.JPanel;
 import javax.swing.JPasswordField;
 import javax.swing.JTextField;
 
+/**
+ * Small Swing-based UI to pass user/name and password. TODO better integrate
+ * with JAAS callbacks.
+ */
 public class UserPasswordDialog extends JDialog implements ActionListener {
        private static final long serialVersionUID = -9052993072210981198L;
        private static String OK = "ok";