Fix char array comparison
authorMathieu Baudier <mbaudier@argeo.org>
Fri, 19 Jan 2018 13:36:05 +0000 (14:36 +0100)
committerMathieu Baudier <mbaudier@argeo.org>
Fri, 19 Jan 2018 13:36:05 +0000 (14:36 +0100)
org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java

index f8c93693875c73cc65fdcc07e780f10dd07787ba..64f4ff9b800f1b1f15990b55d2c94b9d9f84be2b 100644 (file)
@@ -23,6 +23,7 @@ import static org.argeo.cms.CmsMsg.repeatNewPassword;
 import static org.eclipse.jface.dialogs.IMessageProvider.INFORMATION;
 
 import java.security.AccessController;
+import java.util.Arrays;
 
 import javax.naming.InvalidNameException;
 import javax.naming.ldap.LdapName;
@@ -81,7 +82,7 @@ public class OpenChangePasswordDialog extends AbstractHandler {
                User user = (User) userAdmin.getRole(dn.toString());
                if (!user.hasCredential(null, oldPassword))
                        throw new CmsException("Invalid password");
-               if (newPassword.equals(""))
+               if (Arrays.equals(newPassword, new char[0]))
                        throw new CmsException("New password empty");
                try {
                        userTransaction.begin();