Document problems with unregistering HTTP handler
authorMathieu Baudier <mbaudier@argeo.org>
Sun, 24 Sep 2023 09:34:03 +0000 (11:34 +0200)
committerMathieu Baudier <mbaudier@argeo.org>
Sun, 24 Sep 2023 09:34:03 +0000 (11:34 +0200)
org.argeo.cms.lib.jetty/src/org/argeo/cms/jetty/JettyHttpServer.java
org.argeo.cms.lib.jetty/src/org/argeo/cms/jetty/ServletHttpContext.java

index a469a87c4ec8b22ca4b1f7a0dafc095502f613de..1254781e81d0802201db9945801268058cd0c201 100644 (file)
@@ -267,6 +267,9 @@ public class JettyHttpServer extends HttpsServer {
                if (httpContext instanceof ContextHandlerHttpContext contextHandlerHttpContext) {
                        // TODO stop handler first?
                        contextHandlerCollection.removeHandler(contextHandlerHttpContext.getServletContextHandler());
+               } else {
+                       // FIXME apparently servlets cannot be removed in Jetty, we should replace the
+                       // handler
                }
        }
 
index 33611941d9d51e1559a574b398bf80aa1569d7e6..b2a472b449910ef7276fd8ac5434032eea3feb59 100644 (file)
@@ -6,7 +6,6 @@ import java.util.Map;
 
 import javax.websocket.DeploymentException;
 import javax.websocket.server.ServerContainer;
-import javax.websocket.server.ServerEndpointConfig;
 
 import org.argeo.api.cms.CmsLog;
 import org.argeo.cms.servlet.httpserver.HttpContextServlet;