From c817be4ea78c1b9922ba32c9221068616b69e8e8 Mon Sep 17 00:00:00 2001 From: Mathieu Baudier Date: Tue, 19 Mar 2013 16:12:25 +0000 Subject: [PATCH] Merge OS JCR authentication provider logging out unnecessarily https://www.argeo.org/bugzilla/show_bug.cgi?id=146 git-svn-id: https://svn.argeo.org/commons/branches/1.x@6173 4cfe0d0a-d680-48aa-b62c-e0a02a3f76cc --- .../org/argeo/security/jcr/OsJcrAuthenticationProvider.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java index c76ae9daf..aa95e322d 100644 --- a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java +++ b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java @@ -58,7 +58,8 @@ public class OsJcrAuthenticationProvider extends OsAuthenticationProvider { throws AuthenticationException { if (authentication instanceof UsernamePasswordAuthenticationToken) { // deal with remote access to internal server - // FIXME very primitive and unsecure at this sSession adminSession =tage + // FIXME very primitive and unsecure at this sSession adminSession + // =tage // consider using the keyring for username / password authentication // or certificate UsernamePasswordAuthenticationToken upat = (UsernamePasswordAuthenticationToken) authentication; @@ -90,8 +91,6 @@ public class OsJcrAuthenticationProvider extends OsAuthenticationProvider { throw new ArgeoException( "Unexpected exception when synchronizing OS and JCR security ", e); - } finally { - JcrUtils.logoutQuietly(nodeSession); } } else { throw new ArgeoException("Unsupported authentication " -- 2.30.2