X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=src%2Forg%2Fargeo%2Fbuild%2FMake.java;h=b0066ac99bdf7ca0295b1bef5aef8e04efe4e882;hb=98526b7d13944dd2b6ef7227bb51c44f7b0fa1e3;hp=9f6f0846d1a6447c7664bb04ad66db3f5451a482;hpb=0057183fefa56b30bb175dce9fd9b6933b980288;p=cc0%2Fargeo-build.git

diff --git a/src/org/argeo/build/Make.java b/src/org/argeo/build/Make.java
index 9f6f084..b0066ac 100644
--- a/src/org/argeo/build/Make.java
+++ b/src/org/argeo/build/Make.java
@@ -38,6 +38,7 @@ import java.util.jar.Attributes;
 import java.util.jar.JarEntry;
 import java.util.jar.JarOutputStream;
 import java.util.jar.Manifest;
+import java.util.stream.Collectors;
 import java.util.zip.Deflater;
 
 import org.eclipse.jdt.core.compiler.CompilationProgress;
@@ -175,7 +176,8 @@ public class Make {
 
 		List<String> a2Categories = options.getOrDefault("--dep-categories", new ArrayList<>());
 		List<String> a2Bases = options.getOrDefault("--a2-bases", new ArrayList<>());
-		if (a2Bases.isEmpty() || !a2Bases.contains(a2Output.toString())) {
+		a2Bases = a2Bases.stream().distinct().collect(Collectors.toList());// remove duplicates
+		if (a2Bases.isEmpty() || !a2Bases.contains(a2Output.toString())) {// make sure a2 output is available
 			a2Bases.add(a2Output.toString());
 		}
 
@@ -204,10 +206,9 @@ public class Make {
 							A2Jar current = a2Jars.get(a2Jar.name);
 							if (a2Jar.major > current.major)
 								a2Jars.put(a2Jar.name, a2Jar);
-							else if (a2Jar.major == current.major //
-									// if minor equals, we take the last one
-									&& a2Jar.minor >= current.minor)
+							else if (a2Jar.major == current.major && a2Jar.minor > current.minor)
 								a2Jars.put(a2Jar.name, a2Jar);
+							// keep if minor equals
 						} else {
 							a2Jars.put(a2Jar.name, a2Jar);
 						}
@@ -380,7 +381,7 @@ public class Make {
 				Path targetParent = targetJarP.getParent();
 				if (targetParent.startsWith(targetA2))
 					deleteEmptyParents(targetA2, targetParent);
-				if (targetParent.startsWith(nativeTargetA2))
+				if (nativeTargetA2 != null && targetParent.startsWith(nativeTargetA2))
 					deleteEmptyParents(nativeTargetA2, targetParent);
 			} else { // install
 				Files.createDirectories(targetJarP.getParent());
@@ -416,6 +417,14 @@ public class Make {
 
 	/** Delete empty parent directory up to the base directory (included). */
 	void deleteEmptyParents(Path baseDir, Path targetParent) throws IOException {
+		if (!targetParent.startsWith(baseDir))
+			throw new IllegalArgumentException(targetParent + " does not start with " + baseDir);
+		if (!Files.exists(baseDir))
+			return;
+		if (!Files.exists(targetParent)) {
+			deleteEmptyParents(baseDir, targetParent.getParent());
+			return;
+		}
 		if (!Files.isDirectory(targetParent))
 			throw new IllegalArgumentException(targetParent + " must be a directory");
 		boolean isA2target = Files.isSameFile(baseDir, targetParent);