X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=server%2Fplugins%2Forg.argeo.jcr.ui.explorer%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fjcr%2Fui%2Fexplorer%2Feditors%2FGenericNodePage.java;h=975e6664e553a688c31b4d3cd9334625ca4c5ae6;hb=ae696952b94054d3b9ec8ab05c02fc82d11607bf;hp=da01f3d49da4c0683564fea9237ed958d0ace15d;hpb=2f0d8516846690fcb9a13ebe7a8c15ca50930a2b;p=lgpl%2Fargeo-commons.git

diff --git a/server/plugins/org.argeo.jcr.ui.explorer/src/main/java/org/argeo/jcr/ui/explorer/editors/GenericNodePage.java b/server/plugins/org.argeo.jcr.ui.explorer/src/main/java/org/argeo/jcr/ui/explorer/editors/GenericNodePage.java
index da01f3d49..975e6664e 100644
--- a/server/plugins/org.argeo.jcr.ui.explorer/src/main/java/org/argeo/jcr/ui/explorer/editors/GenericNodePage.java
+++ b/server/plugins/org.argeo.jcr.ui.explorer/src/main/java/org/argeo/jcr/ui/explorer/editors/GenericNodePage.java
@@ -13,8 +13,6 @@ import javax.jcr.PropertyIterator;
 import javax.jcr.PropertyType;
 import javax.jcr.RepositoryException;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
 import org.argeo.ArgeoException;
 import org.argeo.jcr.JcrUtils;
 import org.argeo.jcr.ui.explorer.JcrExplorerConstants;
@@ -24,7 +22,6 @@ import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.layout.GridLayout;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
-import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
 import org.eclipse.ui.forms.AbstractFormPart;
 import org.eclipse.ui.forms.IManagedForm;
@@ -33,8 +30,13 @@ import org.eclipse.ui.forms.editor.FormPage;
 import org.eclipse.ui.forms.widgets.FormToolkit;
 import org.eclipse.ui.forms.widgets.ScrolledForm;
 
+/**
+ * Main node editor page. Lists all properties of the current node and enable
+ * access and editing for some of them.
+ */
+
 public class GenericNodePage extends FormPage implements JcrExplorerConstants {
-	private final static Log log = LogFactory.getLog(GenericNodePage.class);
+	// private final static Log log = LogFactory.getLog(GenericNodePage.class);
 
 	// local constants
 	private final static String JCR_PROPERTY_NAME = "jcr:name";
@@ -55,18 +57,13 @@ public class GenericNodePage extends FormPage implements JcrExplorerConstants {
 	}
 
 	protected void createFormContent(IManagedForm managedForm) {
-		try {
-			tk = managedForm.getToolkit();
-			ScrolledForm form = managedForm.getForm();
-			GridLayout twt = new GridLayout(3, false);
-			twt.marginWidth = twt.marginHeight = 5;
+		tk = managedForm.getToolkit();
+		ScrolledForm form = managedForm.getForm();
+		GridLayout twt = new GridLayout(3, false);
+		twt.marginWidth = twt.marginHeight = 5;
 
-			form.getBody().setLayout(twt);
-
-			createPropertiesPart(form.getBody());
-		} catch (Exception e) {
-			e.printStackTrace();
-		}
+		form.getBody().setLayout(twt);
+		createPropertiesPart(form.getBody());
 	}
 
 	private void createPropertiesPart(Composite parent) {
@@ -118,12 +115,12 @@ public class GenericNodePage extends FormPage implements JcrExplorerConstants {
 	private void addPropertyLine(Composite parent, AbstractFormPart part,
 			Property prop) {
 		try {
-			Label lbl = tk.createLabel(parent, prop.getName());
-			lbl = tk.createLabel(parent,
+			tk.createLabel(parent, prop.getName());
+			tk.createLabel(parent,
 					"[" + JcrUtils.getPropertyDefinitionAsString(prop) + "]");
 
 			if (prop.getDefinition().isProtected()) {
-				lbl = tk.createLabel(parent, formatReadOnlyPropertyValue(prop));
+				tk.createLabel(parent, formatReadOnlyPropertyValue(prop));
 			} else
 				addModifyableValueWidget(parent, part, prop);
 		} catch (RepositoryException re) {