X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=security%2Fruntime%2Forg.argeo.security.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fsecurity%2Fldap%2FArgeoUserDetailsContextMapper.java;h=55232648066d2368e67d39d9e799d72140367edb;hb=54ca073308e726107a5e59b50ce875ebeb43b965;hp=25b5c6eba57df15e36fc4138b9842deea0f7b95b;hpb=7c9ba14fbe8cd771af9d205c7988507c1dd7abb6;p=lgpl%2Fargeo-commons.git

diff --git a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/ldap/ArgeoUserDetailsContextMapper.java b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/ldap/ArgeoUserDetailsContextMapper.java
index 25b5c6eba..552326480 100644
--- a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/ldap/ArgeoUserDetailsContextMapper.java
+++ b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/ldap/ArgeoUserDetailsContextMapper.java
@@ -14,7 +14,10 @@ import org.springframework.security.userdetails.UserDetails;
 import org.springframework.security.userdetails.ldap.UserDetailsContextMapper;
 
 public class ArgeoUserDetailsContextMapper implements UserDetailsContextMapper {
-	private List<UserNatureMapper> userInfoMappers = new ArrayList<UserNatureMapper>();
+//	private final static Log log = LogFactory
+//			.getLog(ArgeoUserDetailsContextMapper.class);
+
+	private List<UserNatureMapper> userNatureMappers = new ArrayList<UserNatureMapper>();
 
 	public UserDetails mapUserFromContext(DirContextOperations ctx,
 			String username, GrantedAuthority[] authorities) {
@@ -22,13 +25,15 @@ public class ArgeoUserDetailsContextMapper implements UserDetailsContextMapper {
 				.first();
 		String password = new String(arr);
 
-		List<UserNature> userInfos = new ArrayList<UserNature>();
-		for (UserNatureMapper userInfoMapper : userInfoMappers) {
-			userInfos.add(userInfoMapper.mapUserInfoFromContext(ctx));
+		List<UserNature> userNatures = new ArrayList<UserNature>();
+		for (UserNatureMapper userInfoMapper : userNatureMappers) {
+			UserNature userNature = userInfoMapper.mapUserInfoFromContext(ctx);
+			if (userNature != null)
+				userNatures.add(userNature);
 		}
 
 		return new ArgeoUserDetails(username, Collections
-				.unmodifiableList(userInfos), password, authorities);
+				.unmodifiableList(userNatures), password, authorities);
 	}
 
 	public void mapUserToContext(UserDetails user, DirContextAdapter ctx) {
@@ -37,19 +42,19 @@ public class ArgeoUserDetailsContextMapper implements UserDetailsContextMapper {
 		ctx.setAttributeValue("userPassword", user.getPassword());
 		if (user instanceof ArgeoUser) {
 			ArgeoUser argeoUser = (ArgeoUser) user;
-			for (UserNature userInfo : argeoUser.getUserNatures()) {
-				for (UserNatureMapper userInfoMapper : userInfoMappers) {
-					if (userInfoMapper.supports(userInfo)) {
-						userInfoMapper.mapUserInfoToContext(userInfo, ctx);
-						break;// use the first mapper found an no others
+			for (UserNature userNature : argeoUser.getUserNatures()) {
+				for (UserNatureMapper userInfoMapper : userNatureMappers) {
+					if (userInfoMapper.supports(userNature)) {
+						userInfoMapper.mapUserInfoToContext(userNature, ctx);
+						break;// use the first mapper found and no others
 					}
 				}
 			}
 		}
 	}
 
-	public void setUserInfoMappers(List<UserNatureMapper> userInfoMappers) {
-		this.userInfoMappers = userInfoMappers;
+	public void setUserNatureMappers(List<UserNatureMapper> userNatureMappers) {
+		this.userNatureMappers = userNatureMappers;
 	}
 
 }