X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=security%2Fruntime%2Forg.argeo.security.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fsecurity%2Fcore%2FKeyBasedSystemExecutionService.java;h=b5791c587f00ec2dd9ea021c4c06172cf3be7527;hb=6bb0606505be3e99021c5ff9771c719eb1e1f2e7;hp=b2dfc4a2439922cbd795d3c6c1522444130903c2;hpb=6b3ffc999e1ba5719420b861c7fe411bbbdfa9e2;p=lgpl%2Fargeo-commons.git

diff --git a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/KeyBasedSystemExecutionService.java b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/KeyBasedSystemExecutionService.java
index b2dfc4a24..b5791c587 100644
--- a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/KeyBasedSystemExecutionService.java
+++ b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/KeyBasedSystemExecutionService.java
@@ -1,31 +1,24 @@
 package org.argeo.security.core;
 
-import java.security.AccessController;
 import java.util.concurrent.Callable;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 import java.util.concurrent.FutureTask;
 
-import javax.security.auth.Subject;
-
 import org.argeo.ArgeoException;
 import org.argeo.security.SystemExecutionService;
-import org.springframework.security.Authentication;
-import org.springframework.security.AuthenticationManager;
-import org.springframework.security.context.SecurityContext;
-import org.springframework.security.context.SecurityContextHolder;
 
 /**
  * Implementation of a {@link SystemExecutionService} using a key-based
  * {@link InternalAuthentication}
  */
-public class KeyBasedSystemExecutionService implements SystemExecutionService {
-	private AuthenticationManager authenticationManager;
-	private String systemAuthenticationKey;
-
+public class KeyBasedSystemExecutionService extends AbstractSystemExecution
+		implements SystemExecutionService {
 	public void execute(Runnable runnable) {
 		try {
 			wrapWithSystemAuthentication(Executors.callable(runnable)).call();
+		} catch (RuntimeException e) {
+			throw e;
 		} catch (Exception e) {
 			throw new ArgeoException(
 					"Exception when running system authenticated task", e);
@@ -44,46 +37,13 @@ public class KeyBasedSystemExecutionService implements SystemExecutionService {
 		return new Callable<T>() {
 
 			public T call() throws Exception {
-				SecurityContext securityContext = SecurityContextHolder
-						.getContext();
-				Authentication currentAuth = securityContext
-						.getAuthentication();
-				if (currentAuth != null)
-					throw new ArgeoException(
-							"System execution on an already authenticated thread: "
-									+ currentAuth + ", THREAD="
-									+ Thread.currentThread().getId());
-
-				Subject subject = Subject.getSubject(AccessController
-						.getContext());
-				if (subject != null
-						&& !subject.getPrincipals(Authentication.class)
-								.isEmpty())
-					throw new ArgeoException(
-							"There is already an authenticated subject: "
-									+ subject);
-
-				Authentication auth = authenticationManager
-						.authenticate(new InternalAuthentication(
-								systemAuthenticationKey));
-				securityContext.setAuthentication(auth);
+				authenticateAsSystem();
 				try {
 					return runnable.call();
 				} finally {
-					// remove the authentication
-					securityContext.setAuthentication(null);
+					deauthenticateAsSystem();
 				}
 			}
 		};
 	}
-
-	public void setAuthenticationManager(
-			AuthenticationManager authenticationManager) {
-		this.authenticationManager = authenticationManager;
-	}
-
-	public void setSystemAuthenticationKey(String systemAuthenticationKey) {
-		this.systemAuthenticationKey = systemAuthenticationKey;
-	}
-
 }