X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=security%2Fruntime%2Forg.argeo.security.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fsecurity%2FSimpleArgeoUser.java;h=c021f8e4453a8e1ae61975c7839c644c9f9d7288;hb=802beab5459c8da4970215886babb45d968e4639;hp=9dd3d694343b896ae5755f970ca7ffce277e50bf;hpb=490d9907457c43acfa965e7979ce5974bc1ba6ca;p=lgpl%2Fargeo-commons.git

diff --git a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/SimpleArgeoUser.java b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/SimpleArgeoUser.java
index 9dd3d6943..c021f8e44 100644
--- a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/SimpleArgeoUser.java
+++ b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/SimpleArgeoUser.java
@@ -18,14 +18,23 @@ package org.argeo.security;
 
 import java.io.Serializable;
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
-public class SimpleArgeoUser implements ArgeoUser, Serializable {
+import org.argeo.ArgeoException;
+
+/**
+ * Read-write implementation of an Argeo user. Typically initialized with a
+ * generic instance (read-only9 in order to modify a user.
+ */
+public class SimpleArgeoUser implements ArgeoUser, Serializable,
+		Comparable<ArgeoUser> {
 	private static final long serialVersionUID = 1L;
 
 	private String username;
 	private String password;
-	private List<UserNature> userNatures = new ArrayList<UserNature>();
+	private Map<String, UserNature> userNatures = new HashMap<String, UserNature>();
 	private List<String> roles = new ArrayList<String>();
 
 	public SimpleArgeoUser() {
@@ -35,16 +44,57 @@ public class SimpleArgeoUser implements ArgeoUser, Serializable {
 	public SimpleArgeoUser(ArgeoUser argeoUser) {
 		username = argeoUser.getUsername();
 		password = argeoUser.getPassword();
-		userNatures = new ArrayList<UserNature>(argeoUser.getUserNatures());
+		userNatures = new HashMap<String, UserNature>(
+				argeoUser.getUserNatures());
 		roles = new ArrayList<String>(argeoUser.getRoles());
 	}
 
-	public List<UserNature> getUserNatures() {
+	public Map<String, UserNature> getUserNatures() {
 		return userNatures;
 	}
 
-	public void updateUserNatures(List<UserNature> userNaturesData) {
-		UserNature.updateUserNaturesWithCheck(userNatures, userNaturesData);
+	public void updateUserNatures(Map<String, UserNature> userNaturesData) {
+		updateUserNaturesWithCheck(userNatures, userNaturesData);
+	}
+
+	public static void updateUserNaturesWithCheck(
+			Map<String, UserNature> userNatures,
+			Map<String, UserNature> userNaturesData) {
+		// checks consistency
+		if (userNatures.size() != userNaturesData.size())
+			throw new ArgeoException(
+					"It is forbidden to add or remove user natures via this method");
+
+		for (String type : userNatures.keySet()) {
+			if (!userNaturesData.containsKey(type))
+				throw new ArgeoException(
+						"Could not find a user nature of type " + type);
+		}
+
+		for (String key : userNatures.keySet()) {
+			userNatures.put(key, userNaturesData.get(key));
+		}
+	}
+
+	@Override
+	public boolean equals(Object obj) {
+		if (!(obj instanceof ArgeoUser))
+			return false;
+		return ((ArgeoUser) obj).getUsername().equals(username);
+	}
+
+	public int compareTo(ArgeoUser o) {
+		return username.compareTo(o.getUsername());
+	}
+
+	@Override
+	public int hashCode() {
+		return username.hashCode();
+	}
+
+	@Override
+	public String toString() {
+		return username;
 	}
 
 	public List<String> getRoles() {
@@ -59,7 +109,7 @@ public class SimpleArgeoUser implements ArgeoUser, Serializable {
 		this.username = username;
 	}
 
-	public void setUserNatures(List<UserNature> userNatures) {
+	public void setUserNatures(Map<String, UserNature> userNatures) {
 		this.userNatures = userNatures;
 	}