X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=org.argeo.cms.ui.workbench%2Fsrc%2Forg%2Fargeo%2Fcms%2Fui%2Fworkbench%2Finternal%2Fjcr%2Fcommands%2FEditNode.java;h=67f82380b5034d7ef654dbb100c5ce855e8de7ff;hb=5b444174cd13680f99944026877f6cac2e1faba1;hp=3acd6e82716b80b6f9951214fadd1483c6cdcdfb;hpb=23b7a170cae60b500e9d45551f26b5075eba73a4;p=lgpl%2Fargeo-commons.git

diff --git a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/commands/EditNode.java b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/commands/EditNode.java
index 3acd6e827..67f82380b 100644
--- a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/commands/EditNode.java
+++ b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/commands/EditNode.java
@@ -29,9 +29,9 @@ import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.handlers.HandlerUtil;
 
-/** Generic command to open a path in an editor. */
+/** Generic command to open a Node in an editor. */
 public class EditNode extends AbstractHandler {
-	public final static String EDITOR_PARAM = "editor";
+	public final static String PARAM_EDITOR_ID = "editor";
 
 	private String defaultEditorId;
 
@@ -39,18 +39,16 @@ public class EditNode extends AbstractHandler {
 
 	public Object execute(ExecutionEvent event) throws ExecutionException {
 		String path = event.getParameter(Property.JCR_PATH);
-
 		String type = event.getParameter(NodeType.NT_NODE_TYPE);
 		if (type == null)
 			type = NodeType.NT_UNSTRUCTURED;
 
-		String editorId = event.getParameter(NodeType.NT_NODE_TYPE);
+		String editorId = event.getParameter(PARAM_EDITOR_ID);
 		if (editorId == null)
 			editorId = nodeTypeToEditor.containsKey(type) ? nodeTypeToEditor
 					.get(type) : defaultEditorId;
-					
-		NodeEditorInput nei = new NodeEditorInput(path);
 
+		NodeEditorInput nei = new NodeEditorInput(path);
 		try {
 			HandlerUtil.getActiveWorkbenchWindow(event).getActivePage()
 					.openEditor(nei, editorId);
@@ -58,12 +56,10 @@ public class EditNode extends AbstractHandler {
 			ErrorFeedback.show("Cannot open " + editorId + " with " + path
 					+ " of type " + type, e);
 		}
-		// TODO Auto-generated method stub
 		return null;
 	}
 
 	public void setDefaultEditorId(String defaultEditorId) {
 		this.defaultEditorId = defaultEditorId;
 	}
-
 }