X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=org.argeo.cms%2Fsrc%2Forg%2Fargeo%2Fcms%2Finternal%2Fjcr%2FRepositoryBuilder.java;h=b3ab11a3357f0c4d0ff3e1c38590f511dc6919e1;hb=040134a521a7952b7523e5c1a53310b40bbd1b60;hp=622600d3ce6ba6fe5f34198247ed850eb349e30c;hpb=914f28bff086f27218c7e657428fd68fa44b0d15;p=lgpl%2Fargeo-commons.git diff --git a/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java b/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java index 622600d3c..b3ab11a33 100644 --- a/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java +++ b/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java @@ -14,7 +14,6 @@ import java.util.UUID; import javax.jcr.RepositoryException; -import org.apache.commons.io.IOUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.jackrabbit.core.RepositoryContext; @@ -32,7 +31,8 @@ import org.xml.sax.InputSource; public class RepositoryBuilder { private final static Log log = LogFactory.getLog(RepositoryBuilder.class); - public RepositoryContext createRepositoryContext(Dictionary properties) throws RepositoryException { + public RepositoryContext createRepositoryContext(Dictionary properties) + throws RepositoryException, IOException { RepositoryConfig repositoryConfig = createRepositoryConfig(properties); RepositoryContext repositoryContext = createJackrabbitRepository(repositoryConfig); RepositoryImpl repository = repositoryContext.getRepository(); @@ -49,22 +49,17 @@ public class RepositoryBuilder { return repositoryContext; } - RepositoryConfig createRepositoryConfig(Dictionary properties) throws RepositoryException { + RepositoryConfig createRepositoryConfig(Dictionary properties) throws RepositoryException, IOException { JackrabbitType type = JackrabbitType.valueOf(prop(properties, RepoConf.type).toString()); ClassLoader cl = getClass().getClassLoader(); - InputStream in = null; - try { - final String base = "/org/argeo/cms/internal/jcr"; - in = cl.getResourceAsStream(base + "/repository-" + type.name() + ".xml"); - + final String base = "/org/argeo/cms/internal/jcr"; + try (InputStream in = cl.getResourceAsStream(base + "/repository-" + type.name() + ".xml")) { if (in == null) throw new ArgeoJcrException("Repository configuration not found"); InputSource config = new InputSource(in); Properties jackrabbitVars = getConfigurationProperties(type, properties); RepositoryConfig repositoryConfig = RepositoryConfig.create(config, jackrabbitVars); return repositoryConfig; - } finally { - IOUtils.closeQuietly(in); } } @@ -101,7 +96,14 @@ public class RepositoryBuilder { } } else { try { - homePath = Paths.get(new URI(homeUri)).toAbsolutePath(); + URI uri = new URI(homeUri); + String host = uri.getHost(); + if (host == null || host.trim().equals("")) { + homePath = Paths.get(uri).toAbsolutePath(); + } else { + // TODO remote at this stage? + throw new IllegalArgumentException("Cannot manage repository path for host " + host); + } } catch (URISyntaxException e) { throw new CmsException("Invalid repository home URI", e); } @@ -193,8 +195,8 @@ public class RepositoryBuilder { RepositoryContext repositoryContext = RepositoryContext.create(repositoryConfig); double duration = ((double) (System.currentTimeMillis() - begin)) / 1000; - if (log.isTraceEnabled()) - log.trace( + if (log.isDebugEnabled()) + log.debug( "Created Jackrabbit repository in " + duration + " s, home: " + repositoryConfig.getHomeDir()); return repositoryContext;