X-Git-Url: https://git.argeo.org/?a=blobdiff_plain;f=org.argeo.cms%2Fsrc%2Forg%2Fargeo%2Fcms%2Fauth%2FHttpSessionLoginModule.java;h=cbd54063cbda19c4496a4930566000f3a735ef36;hb=ba9ea52d11b6ac81120f35351ee632191f251f7d;hp=7b7207ef3e32536b84b8c67f099617ca14d42fe1;hpb=6be83ba7b02c903dfb5aa5df9f7ef58bbbd9f6be;p=lgpl%2Fargeo-commons.git diff --git a/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java b/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java index 7b7207ef3..cbd54063c 100644 --- a/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java +++ b/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java @@ -21,6 +21,7 @@ import javax.servlet.http.HttpSession; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.argeo.cms.CmsException; +import org.argeo.cms.internal.kernel.Activator; import org.osgi.framework.BundleContext; import org.osgi.framework.FrameworkUtil; import org.osgi.framework.InvalidSyntaxException; @@ -198,9 +199,24 @@ public class HttpSessionLoginModule implements LoginModule { private void extractClientCertificate(HttpServletRequest req) { X509Certificate[] certs = (X509Certificate[]) req.getAttribute("javax.servlet.request.X509Certificate"); - if (null != certs && certs.length > 0) { - sharedState.put(CmsAuthUtils.SHARED_STATE_NAME, certs[0].getSubjectX500Principal().getName()); + if (null != certs && certs.length > 0) {// Servlet container verified the client certificate + String certDn = certs[0].getSubjectX500Principal().getName(); + sharedState.put(CmsAuthUtils.SHARED_STATE_NAME, certDn); sharedState.put(CmsAuthUtils.SHARED_STATE_CERTIFICATE_CHAIN, certs); + if (log.isDebugEnabled()) + log.debug("Client certificate " + certDn + " verified by servlet container"); + } // Reverse proxy verified the client certificate + String clientDnHttpHeader = Activator.getHttpProxySslHeader(); + if (clientDnHttpHeader != null) { + String certDn = req.getHeader(clientDnHttpHeader); + // TODO retrieve more cf. https://httpd.apache.org/docs/current/mod/mod_ssl.html + // String issuerDn = req.getHeader("SSL_CLIENT_I_DN"); + if (certDn != null && !certDn.trim().equals("(null)")) { + sharedState.put(CmsAuthUtils.SHARED_STATE_NAME, certDn); + sharedState.put(CmsAuthUtils.SHARED_STATE_CERTIFICATE_CHAIN, ""); + if (log.isDebugEnabled()) + log.debug("Client certificate " + certDn + " verified by reverse proxy"); + } } }