From ed93fb9db5f9008a78d9ab892806ae398ed65b85 Mon Sep 17 00:00:00 2001
From: Mathieu Baudier <mbaudier@argeo.org>
Date: Sun, 18 Nov 2007 14:58:20 +0000
Subject: [PATCH] Improve formatting of the code. Remove exception thrown when
 no closed date found.

git-svn-id: https://svn.argeo.org/slc/trunk@721 4cfe0d0a-d680-48aa-b62c-e0a02a3f76cc
---
 .../include/ant/slc-factory-targets.xml       |  6 ++---
 .../org/argeo/slc/ant/SlcProjectHelper.java   |  4 ++--
 .../argeo/slc/ant/deploy/SlcDeployTask.java   |  4 ++--
 .../slc/ant/test/SlcCloseTestResultTask.java  |  2 --
 .../slc/core/deploy/WritableDeployment.java   |  2 +-
 .../slc/core/test/ExecutableTestRun.java      |  4 ++--
 .../argeo/slc/core/test/SimpleResultPart.java |  1 +
 .../argeo/slc/core/test/SimpleTestResult.java |  3 +--
 .../argeo/slc/core/test/TestResultPart.java   |  2 +-
 .../org/argeo/slc/core/test/TestStatus.java   |  2 +-
 .../AsynchronousTreeTestResultListener.java   |  2 +-
 .../argeo/slc/core/test/tree/PartSubList.java |  4 ++--
 .../slc/core/test/tree/TreeTestResult.java    | 18 +++++++--------
 .../tree/htmlreport/FullHtmlTreeReport.java   |  6 ++---
 .../core/test/tree/htmlreport/ResultPage.java |  8 ++++++-
 .../test/tree/htmlreport/ResultsList.java     |  6 ++---
 .../slc/dao/structure/tree/TreeSPathDao.java  |  2 ++
 .../java/org/argeo/slc/diff/DiffIssue.java    |  4 ++--
 .../java/org/argeo/slc/diff/DiffMissing.java  |  4 +---
 .../org/argeo/slc/diff/SimpleDiffResult.java  |  2 +-
 .../org/argeo/slc/diff/XPathDiffPosition.java |  2 +-
 .../structure/tree/TreeSPathDaoHibernate.java |  4 +---
 .../tree/TreeSRegistryDaoHibernate.java       |  3 ++-
 .../argeo/slc/unit/SpringBasedTestCase.java   |  4 ++--
 .../org/argeo/slc/example/ExampleTask.java    |  4 ++--
 .../argeo/slc/example/appli/ExampleAppli.java |  6 ++---
 .../tree/TreeSPathDaoHibernateTest.java       | 11 +++++-----
 .../tree/TreeSRegistryDaoHibernateTest.java   | 16 +++++++-------
 .../tree/TreeTestResultDaoHibernateTest.java  | 22 +++++++++----------
 29 files changed, 80 insertions(+), 78 deletions(-)

diff --git a/org.argeo.slc/src/main/config/include/ant/slc-factory-targets.xml b/org.argeo.slc/src/main/config/include/ant/slc-factory-targets.xml
index c53515a1e..b76dbcb81 100644
--- a/org.argeo.slc/src/main/config/include/ant/slc-factory-targets.xml
+++ b/org.argeo.slc/src/main/config/include/ant/slc-factory-targets.xml
@@ -98,19 +98,19 @@ $LastChangedDate$
 	<target name="init.slcbase" if="slc.basePackage">
 		<unzip dest="${slc.base}" src="${slc.basePackage}" />
 
-		<copy todir="${dist.base}">
+		<copy todir="${dist.base}" overwrite="true" verbose="true">
 			<fileset dir="${slc.base}">
 				<include name="doc/argeo-slc/**" />
 				<include name="bin/*" />
 			</fileset>
 		</copy>
 
-		<copy todir="${main.libdir}">
+		<copy todir="${main.libdir}" overwrite="true" verbose="true">
 			<fileset dir="${slc.base}/lib">
 				<include name="*" />
 			</fileset>
 		</copy>
-		<copy todir="${main.libdir-src}">
+		<copy todir="${main.libdir-src}" overwrite="true" verbose="true">
 			<fileset dir="${slc.base}/lib-src">
 				<include name="*" />
 			</fileset>
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/ant/SlcProjectHelper.java b/org.argeo.slc/src/main/java/org/argeo/slc/ant/SlcProjectHelper.java
index cefa61f69..d877e2b4b 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/ant/SlcProjectHelper.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/ant/SlcProjectHelper.java
@@ -46,8 +46,8 @@ public class SlcProjectHelper extends ProjectHelperImpl {
 
 		// initialize config
 		SlcAntConfig slcAntConfig = new SlcAntConfig();
-		
-		if(!slcAntConfig.initProject(project)){
+
+		if (!slcAntConfig.initProject(project)) {
 			// not SLC compatible, do normal Ant
 			super.parse(project, source);
 			return;
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/ant/deploy/SlcDeployTask.java b/org.argeo.slc/src/main/java/org/argeo/slc/ant/deploy/SlcDeployTask.java
index 70c0ff7f6..fb470992d 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/ant/deploy/SlcDeployTask.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/ant/deploy/SlcDeployTask.java
@@ -48,13 +48,13 @@ public class SlcDeployTask extends SAwareTask {
 		this.deploymentBean = deploymentBean;
 	}
 
-	/** Creates deployment data sub tag.*/
+	/** Creates deployment data sub tag. */
 	public DeploymentDataArg createDeploymentData() {
 		deploymentDataArg = new DeploymentDataArg();
 		return deploymentDataArg;
 	}
 
-	/** Creates target data sub tag.*/
+	/** Creates target data sub tag. */
 	public TargetDataArg createTargetData() {
 		targetDataArg = new TargetDataArg();
 		return targetDataArg;
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/ant/test/SlcCloseTestResultTask.java b/org.argeo.slc/src/main/java/org/argeo/slc/ant/test/SlcCloseTestResultTask.java
index 660928abe..bc0c2ba1a 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/ant/test/SlcCloseTestResultTask.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/ant/test/SlcCloseTestResultTask.java
@@ -1,9 +1,7 @@
 package org.argeo.slc.ant.test;
 
 import org.argeo.slc.ant.structure.SAwareTask;
-import org.argeo.slc.core.structure.StructureAware;
 import org.argeo.slc.core.structure.StructureRegistry;
-import org.argeo.slc.core.test.TestReport;
 import org.argeo.slc.core.test.TestResult;
 
 /** Ant tasks closing a given result. */
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/deploy/WritableDeployment.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/deploy/WritableDeployment.java
index f67531cca..15c3ccb6c 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/deploy/WritableDeployment.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/deploy/WritableDeployment.java
@@ -1,6 +1,6 @@
 package org.argeo.slc.core.deploy;
 
-public interface WritableDeployment extends ExecutableDeployment{
+public interface WritableDeployment extends ExecutableDeployment {
 	public void setDeployedSystem(DeployedSystem deployedSystem);
 
 	public void setTargetData(TargetData targetData);
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/ExecutableTestRun.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/ExecutableTestRun.java
index bd1526412..34216799f 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/ExecutableTestRun.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/ExecutableTestRun.java
@@ -1,7 +1,7 @@
 package org.argeo.slc.core.test;
 
-/** A test run that can be executed*/
-public interface ExecutableTestRun extends TestRun{
+/** A test run that can be executed */
+public interface ExecutableTestRun extends TestRun {
 
 	/** Executes this test run. */
 	public void execute();
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleResultPart.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleResultPart.java
index 97b937fa8..249fd2149 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleResultPart.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleResultPart.java
@@ -5,6 +5,7 @@ package org.argeo.slc.core.test;
  * Basic implementation of a result part, implementing the standard three status
  * approach for test results.
  * </p>
+ * 
  * @see TestStatus
  */
 public class SimpleResultPart implements TestResultPart, TestStatus {
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleTestResult.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleTestResult.java
index 3f673305d..9ef6cdea3 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleTestResult.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/SimpleTestResult.java
@@ -8,8 +8,7 @@ import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
 /**
- * Basic implementation of a test result containing only a list of result
- * parts.
+ * Basic implementation of a test result containing only a list of result parts.
  */
 public class SimpleTestResult implements TestResult {
 	private static Log log = LogFactory.getLog(SimpleTestResult.class);
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestResultPart.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestResultPart.java
index 3d56a5f11..707c00f3b 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestResultPart.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestResultPart.java
@@ -5,7 +5,7 @@ package org.argeo.slc.core.test;
  * 
  * @see TestResult
  */
-public interface TestResultPart {	
+public interface TestResultPart {
 	public Integer getStatus();
 
 	public String getMessage();
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestStatus.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestStatus.java
index 9f7f6e821..0f54d9655 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestStatus.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/TestStatus.java
@@ -1,7 +1,7 @@
 package org.argeo.slc.core.test;
 
 /**
- * Simple statuses. 
+ * Simple statuses.
  * <p>
  * <ul>
  * <li>{@link #PASSED}: the test succeeded</li>
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/AsynchronousTreeTestResultListener.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/AsynchronousTreeTestResultListener.java
index c3bc793ef..751b0e9b1 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/AsynchronousTreeTestResultListener.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/AsynchronousTreeTestResultListener.java
@@ -39,7 +39,7 @@ public abstract class AsynchronousTreeTestResultListener implements
 			thread = null;
 			partStructs.notifyAll();
 		}
-		postClose((TreeTestResult)testResult);
+		postClose((TreeTestResult) testResult);
 	}
 
 	public final void resultPartAdded(TestResult testResult,
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/PartSubList.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/PartSubList.java
index eab01a048..113ef48bb 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/PartSubList.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/PartSubList.java
@@ -20,12 +20,12 @@ public class PartSubList {
 
 	private List<TestResultPart> parts = new Vector<TestResultPart>();
 
-	/** Gets the result parts.*/
+	/** Gets the result parts. */
 	public List<TestResultPart> getParts() {
 		return parts;
 	}
 
-	/** Sets the result parts.*/
+	/** Sets the result parts. */
 	public void setParts(List<TestResultPart> parts) {
 		this.parts = parts;
 	}
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/TreeTestResult.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/TreeTestResult.java
index dc0f3aa59..3124b055f 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/TreeTestResult.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/TreeTestResult.java
@@ -33,7 +33,7 @@ public class TreeTestResult implements TestResult, StructureAware {
 	private List<TestResultListener> listeners = new Vector<TestResultListener>();
 
 	private TreeSPath currentPath;
-	
+
 	private Date closeDate;
 
 	private boolean isClosed = false;
@@ -41,7 +41,7 @@ public class TreeTestResult implements TestResult, StructureAware {
 	private SortedMap<TreeSPath, PartSubList> resultParts = new TreeMap<TreeSPath, PartSubList>();
 
 	private StructureRegistry registry;
-	
+
 	public TestResultId getTestResultId() {
 		return testResultId;
 	}
@@ -54,12 +54,12 @@ public class TreeTestResult implements TestResult, StructureAware {
 		return testResultId;
 	}
 
-	/** Sets the test result id as a numeric test result id.*/
+	/** Sets the test result id as a numeric test result id. */
 	public void setNumericResultId(NumericTRId testResultId) {
 		this.testResultId = testResultId;
 	}
 
-	/** Sets the list of listeners.*/
+	/** Sets the list of listeners. */
 	public void setListeners(List<TestResultListener> listeners) {
 		this.listeners = listeners;
 	}
@@ -88,7 +88,7 @@ public class TreeTestResult implements TestResult, StructureAware {
 		this.registry = registry;
 	}
 
-	/** Gets the current path.*/
+	/** Gets the current path. */
 	public TreeSPath getCurrentPath() {
 		return currentPath;
 	}
@@ -117,7 +117,7 @@ public class TreeTestResult implements TestResult, StructureAware {
 			listeners.clear();
 		}
 		isClosed = true;
-		
+
 		log.info("Test Result #" + getTestResultId() + " closed.");
 	}
 
@@ -129,12 +129,12 @@ public class TreeTestResult implements TestResult, StructureAware {
 		this.tid = tid;
 	}
 
-	/** Gets the related registry (can be null).*/
+	/** Gets the related registry (can be null). */
 	public StructureRegistry getRegistry() {
 		return registry;
 	}
 
-	/** Sets the related registry.*/
+	/** Sets the related registry. */
 	public void setRegistry(StructureRegistry registry) {
 		this.registry = registry;
 	}
@@ -143,7 +143,7 @@ public class TreeTestResult implements TestResult, StructureAware {
 		return closeDate;
 	}
 
-	/** Sets the close date (for ORM)*/
+	/** Sets the close date (for ORM) */
 	public void setCloseDate(Date closeDate) {
 		this.closeDate = closeDate;
 	}
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/FullHtmlTreeReport.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/FullHtmlTreeReport.java
index eb8a360d7..b05ed389a 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/FullHtmlTreeReport.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/FullHtmlTreeReport.java
@@ -132,11 +132,11 @@ public class FullHtmlTreeReport implements TestReport, StructureAware {
 		return reportDir;
 	}
 
-	void addStyles(StringBuffer buf){
+	void addStyles(StringBuffer buf) {
 		try {
 			buf.append("<style type=\"text/css\">\n");
 			InputStream in = FullHtmlTreeReport.class
-			.getResourceAsStream("style.css");
+					.getResourceAsStream("style.css");
 			String styles = IOUtils.toString(in);
 			IOUtils.closeQuietly(in);
 			buf.append(styles);
@@ -145,7 +145,7 @@ public class FullHtmlTreeReport implements TestReport, StructureAware {
 			throw new SlcException("Cannot load styles", e);
 		}
 	}
-	
+
 	private void resourceToFile(String resourceName) {
 		try {
 			File file = new File(getReportDir() + File.separator + resourceName);
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultPage.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultPage.java
index e4f7f20f6..dbf047568 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultPage.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultPage.java
@@ -1,6 +1,7 @@
 package org.argeo.slc.core.test.tree.htmlreport;
 
 import java.io.IOException;
+import java.util.Date;
 import java.util.SortedMap;
 import java.util.TreeMap;
 
@@ -51,7 +52,12 @@ class ResultPage {
 		buf.append("<a name=\"top\"/>\n");
 		buf.append("<h1>Result #").append(result.getTestResultId()).append(
 				"</h1>\n");
-		buf.append(report.sdf.format(result.getCloseDate()));
+		Date closeDate = result.getCloseDate();
+		if (closeDate == null) {
+			buf.append("[Not closed]");
+		} else {
+			buf.append(report.sdf.format(closeDate));
+		}
 
 		// TOC
 		generateToc(buf, registry);
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultsList.java b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultsList.java
index 84b1f7fe0..ad9b2bfec 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultsList.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/core/test/tree/htmlreport/ResultsList.java
@@ -5,7 +5,6 @@ import java.io.FileWriter;
 import java.io.IOException;
 import java.util.Date;
 
-import org.argeo.slc.core.SlcException;
 import org.argeo.slc.core.test.tree.TreeTestResult;
 
 class ResultsList {
@@ -33,9 +32,10 @@ class ResultsList {
 		buf.append("<td>");
 		Date closeDate = result.getCloseDate();
 		if (closeDate == null) {
-			throw new SlcException("No close date");
+			buf.append("[Not closed]");
+		} else {
+			buf.append(report.sdf.format(closeDate));
 		}
-		buf.append(report.sdf.format(closeDate));
 		buf.append("</td>\n");
 		// Id and link
 		buf.append("<td><a class=\"nav\" href=\"");
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/dao/structure/tree/TreeSPathDao.java b/org.argeo.slc/src/main/java/org/argeo/slc/dao/structure/tree/TreeSPathDao.java
index 379f826db..0ebca0d8c 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/dao/structure/tree/TreeSPathDao.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/dao/structure/tree/TreeSPathDao.java
@@ -4,6 +4,8 @@ import org.argeo.slc.core.structure.tree.TreeSPath;
 
 public interface TreeSPathDao {
 	public void create(TreeSPath path);
+
 	public TreeSPath getTreeSPath(String pathString);
+
 	public TreeSPath getOrCreate(TreeSPath pathTransient);
 }
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffIssue.java b/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffIssue.java
index 544fd9940..5517b3a66 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffIssue.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffIssue.java
@@ -2,10 +2,10 @@ package org.argeo.slc.diff;
 
 /** The root class for issues which happened during a diff. */
 public abstract class DiffIssue implements Comparable<DiffIssue> {
-	/** The position of this issue.*/
+	/** The position of this issue. */
 	protected final DiffPosition position;
 
-	/** Constructor*/
+	/** Constructor */
 	public DiffIssue(DiffPosition position) {
 		super();
 		this.position = position;
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffMissing.java b/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffMissing.java
index 1b3e01fa4..da4476660 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffMissing.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/diff/DiffMissing.java
@@ -1,6 +1,5 @@
 package org.argeo.slc.diff;
 
-
 /**
  * A value missing in one of the file. If its position is related to expected,
  * this means it is a left over in the reached, if its position is related to
@@ -23,8 +22,7 @@ public class DiffMissing extends DiffIssue {
 	public String toString() {
 		if (position.relatedFile == RelatedFile.EXPECTED) {
 			return position + ": left over " + key;
-		}
-		else if (position.relatedFile == RelatedFile.REACHED) {
+		} else if (position.relatedFile == RelatedFile.REACHED) {
 			return position + ": missing " + key;
 		}
 		return super.toString();
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/diff/SimpleDiffResult.java b/org.argeo.slc/src/main/java/org/argeo/slc/diff/SimpleDiffResult.java
index accd71834..6eefb7f28 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/diff/SimpleDiffResult.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/diff/SimpleDiffResult.java
@@ -3,7 +3,7 @@ package org.argeo.slc.diff;
 import java.util.List;
 import java.util.Vector;
 
-/** A basic implementation of <code>DiffResult</code>.*/
+/** A basic implementation of <code>DiffResult</code>. */
 public class SimpleDiffResult implements DiffResult {
 	private List<DiffIssue> issues = new Vector<DiffIssue>();
 
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/diff/XPathDiffPosition.java b/org.argeo.slc/src/main/java/org/argeo/slc/diff/XPathDiffPosition.java
index 9069011cd..f295eb9e6 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/diff/XPathDiffPosition.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/diff/XPathDiffPosition.java
@@ -2,7 +2,7 @@ package org.argeo.slc.diff;
 
 import org.argeo.slc.core.UnsupportedException;
 
-/** A diff position within an Xml file. <b>NOT YET IMPLEMENTED</b>.*/
+/** A diff position within an Xml file. <b>NOT YET IMPLEMENTED</b>. */
 public class XPathDiffPosition extends DiffPosition {
 
 	private String xPath;
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernate.java b/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernate.java
index 549be3b3b..fe0839272 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernate.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernate.java
@@ -25,7 +25,6 @@ public class TreeSPathDaoHibernate extends HibernateDaoSupport implements
 		createImpl(path);
 	}
 
-	
 	private void createImpl(TreeSPath path) {
 		if (path.getParent() != null) {
 			TreeSPath parent = getTreeSPath(path.getParent()
@@ -52,8 +51,7 @@ public class TreeSPathDaoHibernate extends HibernateDaoSupport implements
 	}
 
 	public TreeSPath getOrCreate(TreeSPath pathTransient) {
-		TreeSPath path = getTreeSPath(pathTransient
-				.getAsUniqueString());
+		TreeSPath path = getTreeSPath(pathTransient.getAsUniqueString());
 		if (path != null) {
 			return path;
 		} else {
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernate.java b/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernate.java
index b3287a581..3effc45d1 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernate.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernate.java
@@ -16,7 +16,8 @@ import org.argeo.slc.dao.structure.tree.TreeSRegistryDao;
 public class TreeSRegistryDaoHibernate extends HibernateDaoSupport implements
 		TreeSRegistryDao {
 
-	//private static Log log = LogFactory.getLog(TreeSRegistryDaoHibernate.class);
+	// private static Log log =
+	// LogFactory.getLog(TreeSRegistryDaoHibernate.class);
 
 	public void create(TreeSRegistry registry) {
 		getHibernateTemplate().save(registry);
diff --git a/org.argeo.slc/src/main/java/org/argeo/slc/unit/SpringBasedTestCase.java b/org.argeo.slc/src/main/java/org/argeo/slc/unit/SpringBasedTestCase.java
index 589edfd02..3d6f0c8af 100644
--- a/org.argeo.slc/src/main/java/org/argeo/slc/unit/SpringBasedTestCase.java
+++ b/org.argeo.slc/src/main/java/org/argeo/slc/unit/SpringBasedTestCase.java
@@ -1,10 +1,10 @@
 package org.argeo.slc.unit;
 
+import junit.framework.TestCase;
+
 import org.springframework.context.ApplicationContext;
 import org.springframework.context.support.ClassPathXmlApplicationContext;
 
-import junit.framework.TestCase;
-
 /** Helper for tests using a Spring application co,text. */
 public abstract class SpringBasedTestCase extends TestCase {
 	private ApplicationContext context;
diff --git a/org.argeo.slc/src/test/java/org/argeo/slc/example/ExampleTask.java b/org.argeo.slc/src/test/java/org/argeo/slc/example/ExampleTask.java
index 9da9c8e48..c77e4513f 100644
--- a/org.argeo.slc/src/test/java/org/argeo/slc/example/ExampleTask.java
+++ b/org.argeo.slc/src/test/java/org/argeo/slc/example/ExampleTask.java
@@ -10,7 +10,7 @@ import org.argeo.slc.core.test.TestDefinition;
 import org.argeo.slc.core.test.TestResult;
 import org.argeo.slc.core.test.TestRun;
 
-/** Example task.*/
+/** Example task. */
 public class ExampleTask implements StructureAware, TestDefinition,
 		StructureElement {
 	private TreeSPath path;
@@ -32,7 +32,7 @@ public class ExampleTask implements StructureAware, TestDefinition,
 		return description;
 	}
 
-	/** Sets the description.*/
+	/** Sets the description. */
 	public void setDescription(String description) {
 		this.description = description;
 	}
diff --git a/org.argeo.slc/src/test/java/org/argeo/slc/example/appli/ExampleAppli.java b/org.argeo.slc/src/test/java/org/argeo/slc/example/appli/ExampleAppli.java
index fd0c6c0f7..7644c5710 100644
--- a/org.argeo.slc/src/test/java/org/argeo/slc/example/appli/ExampleAppli.java
+++ b/org.argeo.slc/src/test/java/org/argeo/slc/example/appli/ExampleAppli.java
@@ -5,11 +5,11 @@ import java.io.FileReader;
 import java.io.FileWriter;
 import java.io.IOException;
 
-/** Example appli.*/
+/** Example appli. */
 public class ExampleAppli {
 	private int skipFreq = 2;
 
-	/** Filters.*/
+	/** Filters. */
 	public void filter(String[] args) {
 		if (args.length < 2) {
 			throw new RuntimeException(
@@ -40,7 +40,7 @@ public class ExampleAppli {
 		}
 	}
 
-	/** Sets the frequency of the lines to skip.*/
+	/** Sets the frequency of the lines to skip. */
 	public void setSkipFreq(int skipFreq) {
 		this.skipFreq = skipFreq;
 	}
diff --git a/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernateTest.java b/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernateTest.java
index 3b9a32ddf..d383313a1 100644
--- a/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernateTest.java
+++ b/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSPathDaoHibernateTest.java
@@ -9,15 +9,15 @@ public class TreeSPathDaoHibernateTest extends SpringBasedTestCase {
 	public void testCreate() {
 		TreeSPathDao treeSPathDao = (TreeSPathDao) getContext().getBean(
 				"treeSPathDao");
-		
+
 		String pathParentStr = "/root/testParent";
-		String pathStr = pathParentStr+"/test";
+		String pathStr = pathParentStr + "/test";
 		TreeSPath path = TreeSPath.parseToCreatePath(pathStr);
 		treeSPathDao.create(path);
-		
+
 		TreeSPath pathChild = treeSPathDao.getTreeSPath(pathStr);
 		assertEquals(path, pathChild);
-		
+
 		TreeSPath pathParent = treeSPathDao.getTreeSPath(pathParentStr);
 		assertEquals(path.getParent(), pathParent);
 	}
@@ -26,6 +26,5 @@ public class TreeSPathDaoHibernateTest extends SpringBasedTestCase {
 	protected String getApplicationContextLocation() {
 		return "org/argeo/slc/hibernate/applicationContext.xml";
 	}
-	
-	
+
 }
diff --git a/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernateTest.java b/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernateTest.java
index b5b626b3e..7317994a7 100644
--- a/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernateTest.java
+++ b/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/structure/tree/TreeSRegistryDaoHibernateTest.java
@@ -11,24 +11,24 @@ public class TreeSRegistryDaoHibernateTest extends SpringBasedTestCase {
 
 	public void testCreate() {
 		TreeSRegistryDao treeSRegistryDao = (TreeSRegistryDao) getContext()
-		.getBean("treeSRegistryDao");
-		
+				.getBean("treeSRegistryDao");
+
 		TreeSPathDao treeSPathDao = (TreeSPathDao) getContext().getBean(
-		"treeSPathDao");
+				"treeSPathDao");
 
 		TreeSPath root = TreeSPath.parseToCreatePath("/root");
 		TreeSPath path = root.createChild("test");
-		
+
 		treeSPathDao.create(root);
 		treeSPathDao.create(path);
-		
+
 		TreeSRegistry registry = new TreeSRegistry();
 		registry.setRoot(root);
-		String desc= "desc";
+		String desc = "desc";
 		registry.register(path, new SimpleSElement(desc));
-		
+
 		treeSRegistryDao.create(registry);
-		
+
 		TreeSRegistry registry2 = treeSRegistryDao.getTreeSRegistry(path);
 		SimpleSElement element = registry2.getElements().get(path);
 		assertEquals(desc, element.getDescription());
diff --git a/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/test/tree/TreeTestResultDaoHibernateTest.java b/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/test/tree/TreeTestResultDaoHibernateTest.java
index 939d154fc..8ec8410bc 100644
--- a/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/test/tree/TreeTestResultDaoHibernateTest.java
+++ b/org.argeo.slc/src/test/java/org/argeo/slc/hibernate/test/tree/TreeTestResultDaoHibernateTest.java
@@ -43,7 +43,7 @@ public class TreeTestResultDaoHibernateTest extends SpringBasedTestCase {
 		treeTestResult.notifyCurrentPath(null, path);
 		treeTestResult.addResultPart(partPassed);
 		treeTestResult.addResultPart(partFailed);
-		
+
 		Date closeDate = new Date();
 		treeTestResult.setCloseDate(closeDate);
 
@@ -52,16 +52,16 @@ public class TreeTestResultDaoHibernateTest extends SpringBasedTestCase {
 		TreeTestResult treeTestResult2 = (TreeTestResult) testResultDao
 				.getTestResult(trId);
 		PartSubList list = treeTestResult2.getResultParts().get(path);
-		
-		assertEquals(2,list.getParts().size());
-		SimpleResultPart part0 = (SimpleResultPart)list.getParts().get(0);
-		assertEquals(TestStatus.PASSED, (int)part0.getStatus());
-		assertEquals(msgPassed,part0.getMessage());
-		
-		SimpleResultPart part1 = (SimpleResultPart)list.getParts().get(1);
-		assertEquals(TestStatus.FAILED, (int)part1.getStatus());
-		assertEquals(msgFailed,part1.getMessage());
-		
+
+		assertEquals(2, list.getParts().size());
+		SimpleResultPart part0 = (SimpleResultPart) list.getParts().get(0);
+		assertEquals(TestStatus.PASSED, (int) part0.getStatus());
+		assertEquals(msgPassed, part0.getMessage());
+
+		SimpleResultPart part1 = (SimpleResultPart) list.getParts().get(1);
+		assertEquals(TestStatus.FAILED, (int) part1.getStatus());
+		assertEquals(msgFailed, part1.getMessage());
+
 		assertEquals(closeDate, treeTestResult2.getCloseDate());
 	}
 
-- 
2.39.5