From e85f259de1f77b38c5c9abd7eacfa74c7f571fdb Mon Sep 17 00:00:00 2001 From: Mathieu Baudier Date: Fri, 19 Jan 2018 14:36:05 +0100 Subject: [PATCH] Fix char array comparison --- .../cms/ui/workbench/commands/OpenChangePasswordDialog.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java index f8c936938..64f4ff9b8 100644 --- a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java +++ b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java @@ -23,6 +23,7 @@ import static org.argeo.cms.CmsMsg.repeatNewPassword; import static org.eclipse.jface.dialogs.IMessageProvider.INFORMATION; import java.security.AccessController; +import java.util.Arrays; import javax.naming.InvalidNameException; import javax.naming.ldap.LdapName; @@ -81,7 +82,7 @@ public class OpenChangePasswordDialog extends AbstractHandler { User user = (User) userAdmin.getRole(dn.toString()); if (!user.hasCredential(null, oldPassword)) throw new CmsException("Invalid password"); - if (newPassword.equals("")) + if (Arrays.equals(newPassword, new char[0])) throw new CmsException("New password empty"); try { userTransaction.begin(); -- 2.30.2