From bc95fc842d36a257a47fa4cd6bbecf626f255cf6 Mon Sep 17 00:00:00 2001 From: Bruno Sinou Date: Wed, 26 Feb 2014 11:19:54 +0000 Subject: [PATCH] Clean, update comments git-svn-id: https://svn.argeo.org/slc/trunk@6856 4cfe0d0a-d680-48aa-b62c-e0a02a3f76cc --- .../org/argeo/slc/repo/maven/MavenProxyServiceImpl.java | 8 +++++--- .../src/main/java/org/argeo/slc/SlcConstants.java | 3 +++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/runtime/org.argeo.slc.repo/src/main/java/org/argeo/slc/repo/maven/MavenProxyServiceImpl.java b/runtime/org.argeo.slc.repo/src/main/java/org/argeo/slc/repo/maven/MavenProxyServiceImpl.java index a3277a8c7..fcd65d954 100644 --- a/runtime/org.argeo.slc.repo/src/main/java/org/argeo/slc/repo/maven/MavenProxyServiceImpl.java +++ b/runtime/org.argeo.slc.repo/src/main/java/org/argeo/slc/repo/maven/MavenProxyServiceImpl.java @@ -24,6 +24,7 @@ import javax.jcr.RepositoryException; import javax.jcr.Session; import javax.jcr.nodetype.NodeType; import javax.jcr.security.AccessControlException; +import javax.jcr.security.Privilege; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -50,13 +51,14 @@ public class MavenProxyServiceImpl extends AbstractUrlProxy implements @Override protected void beforeInitSessionSave(Session session) throws RepositoryException { - JcrUtils.addPrivilege(session, "/", "anonymous", "jcr:read"); + JcrUtils.addPrivilege(session, "/", SlcConstants.USER_ANONYMOUS, Privilege.JCR_READ); try { JcrUtils.addPrivilege(session, "/", SlcConstants.ROLE_SLC, - "jcr:all"); + Privilege.JCR_ALL); } catch (AccessControlException e) { if (log.isTraceEnabled()) - log.trace("Cannot give jcr:all privileges to ROLE_SLC"); + log.trace("Cannot give jcr:all privileges to " + + SlcConstants.ROLE_SLC); } JcrUtils.mkdirsSafe(session, RepoConstants.DEFAULT_ARTIFACTS_BASE_PATH); diff --git a/runtime/org.argeo.slc.specs/src/main/java/org/argeo/slc/SlcConstants.java b/runtime/org.argeo.slc.specs/src/main/java/org/argeo/slc/SlcConstants.java index 3cc53e4ee..2b26e878f 100644 --- a/runtime/org.argeo.slc.specs/src/main/java/org/argeo/slc/SlcConstants.java +++ b/runtime/org.argeo.slc.specs/src/main/java/org/argeo/slc/SlcConstants.java @@ -4,4 +4,7 @@ package org.argeo.slc; public interface SlcConstants { /** Read-write role. */ public final static String ROLE_SLC = "ROLE_SLC"; + + /** Read only unlogged user */ + public final static String USER_ANONYMOUS = "anonymous"; } -- 2.39.2