From: Mathieu Baudier <mbaudier@argeo.org>
Date: Fri, 19 Jan 2018 13:36:05 +0000 (+0100)
Subject: Fix char array comparison
X-Git-Tag: argeo-commons-2.1.71~46
X-Git-Url: http://git.argeo.org/?a=commitdiff_plain;h=e85f259de1f77b38c5c9abd7eacfa74c7f571fdb;p=lgpl%2Fargeo-commons.git

Fix char array comparison
---

diff --git a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java
index f8c936938..64f4ff9b8 100644
--- a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java
+++ b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/commands/OpenChangePasswordDialog.java
@@ -23,6 +23,7 @@ import static org.argeo.cms.CmsMsg.repeatNewPassword;
 import static org.eclipse.jface.dialogs.IMessageProvider.INFORMATION;
 
 import java.security.AccessController;
+import java.util.Arrays;
 
 import javax.naming.InvalidNameException;
 import javax.naming.ldap.LdapName;
@@ -81,7 +82,7 @@ public class OpenChangePasswordDialog extends AbstractHandler {
 		User user = (User) userAdmin.getRole(dn.toString());
 		if (!user.hasCredential(null, oldPassword))
 			throw new CmsException("Invalid password");
-		if (newPassword.equals(""))
+		if (Arrays.equals(newPassword, new char[0]))
 			throw new CmsException("New password empty");
 		try {
 			userTransaction.begin();