From: Mathieu Baudier <mbaudier@argeo.org>
Date: Tue, 19 Mar 2013 16:04:25 +0000 (+0000)
Subject: Fix OS JCR authentication provider logging out unnecessarily
X-Git-Tag: argeo-commons-2.1.30~673
X-Git-Url: http://git.argeo.org/?a=commitdiff_plain;h=b12fdccad3a641643b045752dafdc4839096b86d;p=lgpl%2Fargeo-commons.git

Fix OS JCR authentication provider logging out unnecessarily
https://www.argeo.org/bugzilla/show_bug.cgi?id=146

git-svn-id: https://svn.argeo.org/commons/trunk@6170 4cfe0d0a-d680-48aa-b62c-e0a02a3f76cc
---

diff --git a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java
index c76ae9daf..aa95e322d 100644
--- a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java
+++ b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/jcr/OsJcrAuthenticationProvider.java
@@ -58,7 +58,8 @@ public class OsJcrAuthenticationProvider extends OsAuthenticationProvider {
 			throws AuthenticationException {
 		if (authentication instanceof UsernamePasswordAuthenticationToken) {
 			// deal with remote access to internal server
-			// FIXME very primitive and unsecure at this sSession adminSession =tage
+			// FIXME very primitive and unsecure at this sSession adminSession
+			// =tage
 			// consider using the keyring for username / password authentication
 			// or certificate
 			UsernamePasswordAuthenticationToken upat = (UsernamePasswordAuthenticationToken) authentication;
@@ -90,8 +91,6 @@ public class OsJcrAuthenticationProvider extends OsAuthenticationProvider {
 				throw new ArgeoException(
 						"Unexpected exception when synchronizing OS and JCR security ",
 						e);
-			} finally {
-				JcrUtils.logoutQuietly(nodeSession);
 			}
 		} else {
 			throw new ArgeoException("Unsupported authentication "