From: Bruno Sinou <bsinou@argeo.org>
Date: Thu, 7 Apr 2016 07:56:07 +0000 (+0000)
Subject: Some cosmetics changes
X-Git-Tag: argeo-commons-2.1.36~5
X-Git-Url: http://git.argeo.org/?a=commitdiff_plain;h=1c75ba2f683c41d0e081970758d1fb5b2e91689f;p=lgpl%2Fargeo-commons.git

Some cosmetics changes

git-svn-id: https://svn.argeo.org/commons/trunk@8866 4cfe0d0a-d680-48aa-b62c-e0a02a3f76cc
---

diff --git a/org.argeo.security.ui.admin/src/org/argeo/security/ui/admin/internal/commands/NewGroup.java b/org.argeo.security.ui.admin/src/org/argeo/security/ui/admin/internal/commands/NewGroup.java
index 37bae611f..b83412d10 100644
--- a/org.argeo.security.ui.admin/src/org/argeo/security/ui/admin/internal/commands/NewGroup.java
+++ b/org.argeo.security.ui.admin/src/org/argeo/security/ui/admin/internal/commands/NewGroup.java
@@ -64,10 +64,10 @@ public class NewGroup extends AbstractHandler {
 
 	private class NewGroupWizard extends Wizard {
 
-		// pages
+		// Pages
 		private MainGroupInfoWizardPage mainGroupInfo;
 
-		// End user fields
+		// UI fields
 		private Text dNameTxt, commonNameTxt, descriptionTxt;
 		private Combo baseDnCmb;
 
@@ -88,8 +88,9 @@ public class NewGroup extends AbstractHandler {
 			String commonName = commonNameTxt.getText();
 			try {
 				userAdminWrapper.beginTransactionIfNeeded();
+				String dn = getDn(commonName);
 				Group group = (Group) userAdminWrapper.getUserAdmin()
-						.createRole(getDn(commonName), Role.GROUP);
+						.createRole(dn, Role.GROUP);
 				Dictionary props = group.getProperties();
 				String descStr = descriptionTxt.getText();
 				if (EclipseUiUtils.notEmpty(descStr))
@@ -133,7 +134,6 @@ public class NewGroup extends AbstractHandler {
 						"Common name");
 				commonNameTxt.addFocusListener(this);
 
-				
 				Label descLbl = new Label(bodyCmp, SWT.LEAD);
 				descLbl.setText("Description");
 				descLbl.setLayoutData(new GridData(SWT.RIGHT, SWT.TOP, false,
@@ -171,7 +171,7 @@ public class NewGroup extends AbstractHandler {
 			public void focusGained(FocusEvent event) {
 			}
 
-			/** @return error message or null if complete */
+			/** @return the error message or null if complete */
 			protected String checkComplete() {
 				String name = commonNameTxt.getText();