X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=security%2Fruntime%2Forg.argeo.security.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fsecurity%2Fcore%2FSimpleRoleRegistration.java;fp=security%2Fruntime%2Forg.argeo.security.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fsecurity%2Fcore%2FSimpleRoleRegistration.java;h=aa8a5f06e2bb23b447921e4ea19b085fa66dfe61;hb=059ce5bd0851788e146a4a382fb3fd934557335b;hp=b20a842842d98f7a19fba31cdff1631f10e2365a;hpb=7e6177f94240b17ed5f858de4821883346ee0538;p=lgpl%2Fargeo-commons.git

diff --git a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/SimpleRoleRegistration.java b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/SimpleRoleRegistration.java
index b20a84284..aa8a5f06e 100644
--- a/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/SimpleRoleRegistration.java
+++ b/security/runtime/org.argeo.security.core/src/main/java/org/argeo/security/core/SimpleRoleRegistration.java
@@ -1,9 +1,12 @@
 package org.argeo.security.core;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.argeo.security.UserAdminService;
 
 /**
@@ -11,21 +14,29 @@ import org.argeo.security.UserAdminService;
  * is already registered.
  */
 public class SimpleRoleRegistration implements Runnable {
+	private final static Log log = LogFactory
+			.getLog(SimpleRoleRegistration.class);
+
 	private String role;
-	private List<String> roles;
+	private List<String> roles = new ArrayList<String>();
 	private UserAdminService userAdminService;
 
 	@Override
 	public void run() {
 		Set<String> existingRoles = userAdminService.listEditableRoles();
 		if (role != null && !existingRoles.contains(role))
-			userAdminService.newRole(role);
+			newRole(role);
 		for (String r : roles) {
 			if (!existingRoles.contains(r))
-				userAdminService.newRole(r);
+				newRole(r);
 		}
 	}
 
+	protected void newRole(String r) {
+		userAdminService.newRole(r);
+		log.info("Added role " + r + " required by application.");
+	}
+
 	public void register(UserAdminService userAdminService, Map<?, ?> properties) {
 		this.userAdminService = userAdminService;
 		run();