X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=runtime%2Forg.argeo.slc.support.activemq%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fslc%2Fjms%2FMarshallerMessageConverter.java;h=8df639aa336031ff9f4f36ff0a123f8a9bdddbba;hb=1fdb1b4e7b1d2b0cabb6483238301b857a6392fa;hp=dfab1e4bf3ffa79cd8d8b1c017d91d8c8fda20ec;hpb=11a9d0e8d3e9f610d0546463cfaf07ae884cb249;p=gpl%2Fargeo-slc.git

diff --git a/runtime/org.argeo.slc.support.activemq/src/main/java/org/argeo/slc/jms/MarshallerMessageConverter.java b/runtime/org.argeo.slc.support.activemq/src/main/java/org/argeo/slc/jms/MarshallerMessageConverter.java
index dfab1e4bf..8df639aa3 100644
--- a/runtime/org.argeo.slc.support.activemq/src/main/java/org/argeo/slc/jms/MarshallerMessageConverter.java
+++ b/runtime/org.argeo.slc.support.activemq/src/main/java/org/argeo/slc/jms/MarshallerMessageConverter.java
@@ -1,10 +1,30 @@
+/*
+ * Copyright (C) 2010 Mathieu Baudier <mbaudier@argeo.org>
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package org.argeo.slc.jms;
 
+import java.util.Enumeration;
+
 import javax.jms.JMSException;
 import javax.jms.Message;
 import javax.jms.Session;
 import javax.jms.TextMessage;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.argeo.slc.SlcException;
 import org.springframework.jms.support.converter.MessageConversionException;
 import org.springframework.jms.support.converter.MessageConverter;
@@ -14,20 +34,45 @@ import org.springframework.xml.transform.StringResult;
 import org.springframework.xml.transform.StringSource;
 
 public class MarshallerMessageConverter implements MessageConverter {
+	private final static Log log = LogFactory
+			.getLog(MarshallerMessageConverter.class);
+
 	private Marshaller marshaller;
 	private Unmarshaller unmarshaller;
 
+	/** @return the converted message or null if the message itself is null */
+	@SuppressWarnings("unchecked")
 	public Object fromMessage(Message message) throws JMSException,
 			MessageConversionException {
+		if (message == null) {
+			return null;
+		}
+
+		if (log.isTraceEnabled()) {
+			Enumeration<String> names = message.getPropertyNames();
+			while (names.hasMoreElements()) {
+				String name = names.nextElement();
+				log.trace("JMS Property: " + name + "="
+						+ message.getObjectProperty(name));
+			}
+		}
+
 		if (message instanceof TextMessage) {
+
 			String text = ((TextMessage) message).getText();
+
+			if (text == null)
+				throw new SlcException(
+						"Cannot unmarshall message without body: " + message);
+
 			try {
 				return unmarshaller.unmarshal(new StringSource(text));
 			} catch (Exception e) {
 				throw new SlcException("Could not unmarshall " + text, e);
 			}
 		} else {
-			throw new SlcException("Only JMS TextMessage are supported.");
+			throw new SlcException("This type of messages is not supported: "
+					+ message);
 		}
 	}