X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=runtime%2Forg.argeo.slc.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fslc%2Fcore%2Fexecution%2FExecutionAspect.java;h=b50b78f512d35c2f81ba35da24bb2465bd624bf5;hb=d1298659fe6f179d1cbbc8c89f108a0bbc5b4edf;hp=e9e5b4cddd89967d62724500b61aaec332dfa24d;hpb=30f4c6af6c20077e5e36b61faf5edb22c1aae6c6;p=gpl%2Fargeo-slc.git diff --git a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ExecutionAspect.java b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ExecutionAspect.java index e9e5b4cdd..b50b78f51 100644 --- a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ExecutionAspect.java +++ b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ExecutionAspect.java @@ -1,5 +1,5 @@ /* - * Copyright (C) 2010 Mathieu Baudier + * Copyright (C) 2007-2012 Argeo GmbH * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -13,7 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.argeo.slc.core.execution; import org.apache.commons.logging.Log; @@ -27,6 +26,7 @@ import org.aspectj.lang.annotation.Aspect; import org.aspectj.lang.annotation.Pointcut; @Aspect +/** Aspect intercepting calls on execution flows and contexts. */ public class ExecutionAspect { private final static Log log = LogFactory.getLog(ExecutionAspect.class); @@ -46,30 +46,16 @@ public class ExecutionAspect { executionContext.setVariable(ExecutionContext.VAR_FLOW_NAME, executionFlow.getName()); - if (log.isDebugEnabled()) - logStackEvent("=> ", executionFlow); - + logStackEvent("=> ", executionFlow); try { // Actually execute the flow pjp.proceed(); } finally { - if (log.isDebugEnabled()) - logStackEvent("<= ", executionFlow); - + logStackEvent("<= ", executionFlow); executionStack.leaveFlow(executionFlow); } } - @Around("runnableExecution()") - public void aroundRunnable(ProceedingJoinPoint pjp) throws Throwable { - ExecutionFlow executionFlow = (ExecutionFlow) pjp.getTarget(); - Runnable runnable = (Runnable) pjp.getArgs()[0]; - if (log.isDebugEnabled()) - logRunnableExecution(executionFlow, runnable); - // Actually execute the runnable - pjp.proceed(); - } - @Around("getVariable()") public Object aroundGetVariable(ProceedingJoinPoint pjp) throws Throwable { Object obj = pjp.proceed(); @@ -86,10 +72,6 @@ public class ExecutionAspect { public void flowExecution() { } - @Pointcut("execution(void org.argeo.slc.execution.ExecutionFlow.doExecuteRunnable(..))") - public void runnableExecution() { - } - @Pointcut("execution(* org.argeo.slc.execution.ExecutionContext.getVariable(..))") public void getVariable() { } @@ -108,7 +90,7 @@ public class ExecutionAspect { log.debug(depthSpaces(stackSize) + symbol + executionFlow + " #" + executionStack.getCurrentStackLevelUuid() + ", depth=" + stackSize); - else if (log.isDebugEnabled()) + if (log.isDebugEnabled()) log.debug(depthSpaces(stackSize) + symbol + executionFlow); }