X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=runtime%2Forg.argeo.slc.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fslc%2Fcore%2Fexecution%2FDefaultExecutionFlow.java;h=afb6ddbd2b8c72f4e955ded044fb0726dbc9f22e;hb=24d560ee846fda5d7954d44f83cb22ab449dbe61;hp=bf1cf99a5f5efc8e3b3da117407ce58c831b0537;hpb=24cb7655cc4bc5eefa244f565934dda802f4392c;p=gpl%2Fargeo-slc.git diff --git a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java index bf1cf99a5..afb6ddbd2 100644 --- a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java +++ b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java @@ -36,6 +36,7 @@ import org.springframework.beans.factory.BeanNameAware; import org.springframework.beans.factory.InitializingBean; import org.springframework.validation.MapBindingResult; +/** Default implementation of an execution flow. */ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean, BeanNameAware { private final static Log log = LogFactory @@ -83,13 +84,13 @@ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean, ExecutionSpecAttribute attr = executionSpec.getAttributes() .get(key); - if (attr.getIsParameter() && !isSetAsParameter(key)) { - errors.rejectValue(key, "Parameter not set"); + if (attr.getIsImmutable() && !isSetAsParameter(key)) { + errors.rejectValue(key, "Immutable but not set"); break; } - if (attr.getIsFrozen() && !isSetAsParameter(key)) { - errors.rejectValue(key, "Frozen but not set as parameter"); + if (attr.getIsConstant() && !isSetAsParameter(key)) { + errors.rejectValue(key, "Constant but not set as parameter"); break; } @@ -108,9 +109,23 @@ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean, public void run() { try { for (Runnable executable : executables) { + if (Thread.interrupted()) { + log.error("Flow '" + getName() + "' killed before '" + + executable + "'"); + Thread.currentThread().interrupt(); + return; + // throw new ThreadDeath(); + } this.doExecuteRunnable(executable); } } catch (RuntimeException e) { + if (Thread.interrupted()) { + log.error("Flow '" + getName() + + "' killed while receiving an unrelated exception", e); + Thread.currentThread().interrupt(); + return; + // throw new ThreadDeath(); + } if (failOnError) throw e; else {