X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=runtime%2Forg.argeo.slc.core%2Fsrc%2Fmain%2Fjava%2Forg%2Fargeo%2Fslc%2Fcore%2Fexecution%2FDefaultExecutionFlow.java;h=7425a35c93a1e94ff9a16d8c66e27d83b53fc517;hb=a18184e7d6bb5cc2cd6763439310061c60a00a78;hp=7fd07fe770ff32c1d28a94be1c21500cd067be4d;hpb=08aa02f96eb32a6e1f0cc001113df9311a618eb9;p=gpl%2Fargeo-slc.git

diff --git a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java
index 7fd07fe77..7425a35c9 100644
--- a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java
+++ b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/DefaultExecutionFlow.java
@@ -5,6 +5,8 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.argeo.slc.SlcException;
 import org.argeo.slc.core.structure.tree.TreeSPath;
 import org.argeo.slc.core.structure.tree.TreeSRegistry;
@@ -18,7 +20,9 @@ import org.springframework.beans.factory.InitializingBean;
 import org.springframework.validation.MapBindingResult;
 
 public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean,
-		BeanNameAware, StructureAware<TreeSPath> {
+		BeanNameAware {
+	private final static Log log = LogFactory
+			.getLog(DefaultExecutionFlow.class);
 
 	private final ExecutionSpec executionSpec;
 	private String name = null;
@@ -28,6 +32,8 @@ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean,
 	private String path;
 	private StructureRegistry<TreeSPath> registry = new TreeSRegistry();
 
+	private Boolean failOnError = true;
+
 	public DefaultExecutionFlow() {
 		this.executionSpec = new DefaultExecutionSpec();
 	}
@@ -83,11 +89,28 @@ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean,
 	}
 
 	public void run() {
-		for (Runnable executable : executables) {
-			executable.run();
+		try {
+			for (Runnable executable : executables) {
+				doExecuteRunnable(executable);
+			}
+		} catch (RuntimeException e) {
+			if (failOnError)
+				throw e;
+			else {
+				log.error("Execution flow failed,"
+						+ " but process did not fail"
+						+ " because failOnError property"
+						+ " is set to false: " + e);
+				if (log.isTraceEnabled())
+					e.printStackTrace();
+			}
 		}
 	}
 
+	public void doExecuteRunnable(Runnable runnable) {
+		runnable.run();
+	}
+
 	@SuppressWarnings(value = { "unchecked" })
 	public void afterPropertiesSet() throws Exception {
 		if (path != null) {
@@ -95,6 +118,11 @@ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean,
 				if (executable instanceof StructureAware) {
 					((StructureAware<TreeSPath>) executable).notifyCurrentPath(
 							registry, new TreeSPath(path));
+				} else if (executable instanceof DefaultExecutionFlow) {
+					// so we don't need to have DefaultExecutionFlow
+					// implementing StructureAware
+					DefaultExecutionFlow flow = (DefaultExecutionFlow) executable;
+					flow.setPath(path + '/' + flow.getName());
 				}
 			}
 		}
@@ -148,14 +176,21 @@ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean,
 						.getAttributes().get(key).getValue() != null);
 	}
 
+	@Override
 	public String toString() {
-		return new StringBuffer("Flow ").append(name).toString();
+		return new StringBuffer("Execution flow ").append(name).toString();
 	}
 
+	@Override
 	public boolean equals(Object obj) {
 		return ((ExecutionFlow) obj).getName().equals(name);
 	}
 
+	@Override
+	public int hashCode() {
+		return name.hashCode();
+	}
+
 	public String getPath() {
 		return path;
 	}
@@ -168,11 +203,12 @@ public class DefaultExecutionFlow implements ExecutionFlow, InitializingBean,
 		this.registry = registry;
 	}
 
-	public void notifyCurrentPath(StructureRegistry<TreeSPath> registry,
-			TreeSPath path) {
-		if (this.path == null) {
-			this.path = path.toString();
-		}
+	public Boolean getFailOnError() {
+		return failOnError;
+	}
+
+	public void setFailOnError(Boolean failOnError) {
+		this.failOnError = failOnError;
 	}
 
 }