X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=org.argeo.eclipse.ui.rap%2Fsrc%2Forg%2Fargeo%2Feclipse%2Fui%2Fspecific%2FOpenFile.java;h=409b96dedca031f97b5de91b4c54e8a654a1d24d;hb=0af549d05ec45b5e31df9026b6627de9038d39eb;hp=b55521b126d804b07ca2332f2600f9dda9bbae4d;hpb=e71b1737815da9f0fdaff1ee1c69773a8c073ef1;p=lgpl%2Fargeo-commons.git diff --git a/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java b/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java index b55521b12..409b96ded 100644 --- a/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java +++ b/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java @@ -24,19 +24,25 @@ import org.eclipse.rap.rwt.RWT; import org.eclipse.rap.rwt.client.service.UrlLauncher; /** - * Rap specific command handler to open a file retrieved from the server. It + * RWT specific command handler to open a file retrieved from the server. It * forwards the request to the correct service after encoding file name and path * in the request URI. * + *

* The parameter "URI" is used to determine the correct file service, the path - * and the file name. An optional file name can be precised to present a - * different file name as the one used to retrieve it to the end user/ + * and the file name. An optional file name can be precized to present a + * different file name as the one used to retrieve it to the end user. + *

* + *

* Various instances of this handler with different command ID might coexist in * order to provide context specific download service. + *

* + *

* The instance specific service is called by its ID and must have been * externally created + *

*/ public class OpenFile extends AbstractHandler { private final static Log log = LogFactory.getLog(OpenFile.class); @@ -51,7 +57,7 @@ public class OpenFile extends AbstractHandler { String fileName = event.getParameter(PARAM_FILE_NAME); String fileUri = event.getParameter(PARAM_FILE_URI); - // sanity check + // Sanity check if (fileUri == null || "".equals(fileUri.trim()) || openFileServiceId == null || "".equals(openFileServiceId.trim())) @@ -72,14 +78,6 @@ public class OpenFile extends AbstractHandler { UrlLauncher launcher = RWT.getClient().getService(UrlLauncher.class); launcher.openURL(downloadUrl); - - // These lines are useless in the current use case but might be - // necessary with new browsers. Stored here for memo - // response.setContentType("application/force-download"); - // response.setHeader("Content-Disposition", contentDisposition); - // response.setHeader("Content-Transfer-Encoding", "binary"); - // response.setHeader("Pragma", "no-cache"); - // response.setHeader("Cache-Control", "no-cache, must-revalidate"); return null; }