X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=org.argeo.cms%2Fsrc%2Forg%2Fargeo%2Fcms%2Finternal%2Fjcr%2FRepositoryBuilder.java;h=d4a42fdcc8dff434c11447d28fb3b3a6730372b6;hb=c38430e4dc4d8104162d7306675bc2f087d45a54;hp=622600d3ce6ba6fe5f34198247ed850eb349e30c;hpb=914f28bff086f27218c7e657428fd68fa44b0d15;p=lgpl%2Fargeo-commons.git

diff --git a/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java b/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java
index 622600d3c..d4a42fdcc 100644
--- a/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java
+++ b/org.argeo.cms/src/org/argeo/cms/internal/jcr/RepositoryBuilder.java
@@ -14,7 +14,6 @@ import java.util.UUID;
 
 import javax.jcr.RepositoryException;
 
-import org.apache.commons.io.IOUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.jackrabbit.core.RepositoryContext;
@@ -22,17 +21,16 @@ import org.apache.jackrabbit.core.RepositoryImpl;
 import org.apache.jackrabbit.core.cache.CacheManager;
 import org.apache.jackrabbit.core.config.RepositoryConfig;
 import org.apache.jackrabbit.core.config.RepositoryConfigurationParser;
-import org.argeo.cms.CmsException;
+import org.argeo.api.NodeConstants;
 import org.argeo.cms.internal.kernel.CmsPaths;
-import org.argeo.jcr.ArgeoJcrException;
-import org.argeo.node.NodeConstants;
 import org.xml.sax.InputSource;
 
 /** Can interpret properties in order to create an actual JCR repository. */
 public class RepositoryBuilder {
 	private final static Log log = LogFactory.getLog(RepositoryBuilder.class);
 
-	public RepositoryContext createRepositoryContext(Dictionary<String, ?> properties) throws RepositoryException {
+	public RepositoryContext createRepositoryContext(Dictionary<String, ?> properties)
+			throws RepositoryException, IOException {
 		RepositoryConfig repositoryConfig = createRepositoryConfig(properties);
 		RepositoryContext repositoryContext = createJackrabbitRepository(repositoryConfig);
 		RepositoryImpl repository = repositoryContext.getRepository();
@@ -49,22 +47,31 @@ public class RepositoryBuilder {
 		return repositoryContext;
 	}
 
-	RepositoryConfig createRepositoryConfig(Dictionary<String, ?> properties) throws RepositoryException {
+	RepositoryConfig createRepositoryConfig(Dictionary<String, ?> properties) throws RepositoryException, IOException {
 		JackrabbitType type = JackrabbitType.valueOf(prop(properties, RepoConf.type).toString());
 		ClassLoader cl = getClass().getClassLoader();
-		InputStream in = null;
-		try {
-			final String base = "/org/argeo/cms/internal/jcr";
-			in = cl.getResourceAsStream(base + "/repository-" + type.name() + ".xml");
-
+		final String base = "/org/argeo/cms/internal/jcr";
+		try (InputStream in = cl.getResourceAsStream(base + "/repository-" + type.name() + ".xml")) {
 			if (in == null)
-				throw new ArgeoJcrException("Repository configuration not found");
+				throw new IllegalArgumentException("Repository configuration not found");
 			InputSource config = new InputSource(in);
 			Properties jackrabbitVars = getConfigurationProperties(type, properties);
-			RepositoryConfig repositoryConfig = RepositoryConfig.create(config, jackrabbitVars);
+			// RepositoryConfig repositoryConfig = RepositoryConfig.create(config,
+			// jackrabbitVars);
+
+			// custom configuration parser
+			CustomRepositoryConfigurationParser parser = new CustomRepositoryConfigurationParser(jackrabbitVars);
+			parser.setAccessControlProviderClassLoader(cl);
+			RepositoryConfig repositoryConfig = parser.parseRepositoryConfig(config);
+			repositoryConfig.init();
+
+			// set the proper classloaders
+			repositoryConfig.getSecurityConfig().getSecurityManagerConfig().setClassLoader(cl);
+			repositoryConfig.getSecurityConfig().getAccessManagerConfig().setClassLoader(cl);
+//			for (WorkspaceConfig workspaceConfig : repositoryConfig.getWorkspaceConfigs()) {
+//				workspaceConfig.getSecurityConfig().getAccessControlProviderConfig().setClassLoader(cl);
+//			}
 			return repositoryConfig;
-		} finally {
-			IOUtils.closeQuietly(in);
 		}
 	}
 
@@ -82,7 +89,7 @@ public class RepositoryBuilder {
 		String clusterIdProp = props.getProperty(RepoConf.clusterId.name());
 		if (clusterId != null) {
 			if (clusterIdProp != null)
-				throw new CmsException("Cluster id defined as System properties and in deploy config");
+				throw new IllegalArgumentException("Cluster id defined as System properties and in deploy config");
 			props.put(RepoConf.clusterId.name(), clusterId);
 		} else {
 			clusterId = clusterIdProp;
@@ -101,9 +108,16 @@ public class RepositoryBuilder {
 			}
 		} else {
 			try {
-				homePath = Paths.get(new URI(homeUri)).toAbsolutePath();
+				URI uri = new URI(homeUri);
+				String host = uri.getHost();
+				if (host == null || host.trim().equals("")) {
+					homePath = Paths.get(uri).toAbsolutePath();
+				} else {
+					// TODO remote at this stage?
+					throw new IllegalArgumentException("Cannot manage repository path for host " + host);
+				}
 			} catch (URISyntaxException e) {
-				throw new CmsException("Invalid repository home URI", e);
+				throw new IllegalArgumentException("Invalid repository home URI", e);
 			}
 		}
 		// TODO use Jackrabbit API (?)
@@ -116,7 +130,7 @@ public class RepositoryBuilder {
 			// File homeDir = homePath.toFile();
 			// homeDir.mkdirs();
 		} catch (IOException e) {
-			throw new CmsException("Cannot set up repository  home " + homePath, e);
+			throw new RuntimeException("Cannot set up repository  home " + homePath, e);
 		}
 		// home cannot be overridden
 		props.put(RepositoryConfigurationParser.REPOSITORY_HOME_VARIABLE, homePath.toString());
@@ -155,7 +169,7 @@ public class RepositoryBuilder {
 		case localfs:
 			break;
 		default:
-			throw new ArgeoJcrException("Unsupported node type " + type);
+			throw new IllegalArgumentException("Unsupported node type " + type);
 		}
 		return props;
 	}
@@ -193,8 +207,8 @@ public class RepositoryBuilder {
 			RepositoryContext repositoryContext = RepositoryContext.create(repositoryConfig);
 
 			double duration = ((double) (System.currentTimeMillis() - begin)) / 1000;
-			if (log.isTraceEnabled())
-				log.trace(
+			if (log.isDebugEnabled())
+				log.debug(
 						"Created Jackrabbit repository in " + duration + " s, home: " + repositoryConfig.getHomeDir());
 
 			return repositoryContext;