X-Git-Url: http://git.argeo.org/?a=blobdiff_plain;f=org.argeo.cms%2Fsrc%2Forg%2Fargeo%2Fcms%2Fauth%2FHttpSessionLoginModule.java;h=d3103627c294259f8d4218e3534f2a8d98ce89c1;hb=d2057396fab26e7b94e9d479d8429e0ed2487067;hp=ce004c58e86762e5937f4d8bae1aa8e509fe2cc4;hpb=7864616a19aefc440239c1c8854c6b3969be7af0;p=lgpl%2Fargeo-commons.git

diff --git a/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java b/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java
index ce004c58e..d3103627c 100644
--- a/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java
+++ b/org.argeo.cms/src/org/argeo/cms/auth/HttpSessionLoginModule.java
@@ -14,11 +14,13 @@ import javax.security.auth.login.LoginException;
 import javax.security.auth.spi.LoginModule;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
 
 import org.apache.commons.codec.binary.Base64;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.argeo.cms.CmsException;
+import org.argeo.naming.LdapAttrs;
 import org.osgi.framework.BundleContext;
 import org.osgi.framework.FrameworkUtil;
 import org.osgi.framework.InvalidSyntaxException;
@@ -68,7 +70,14 @@ public class HttpSessionLoginModule implements LoginModule {
 			return false;
 		authorization = (Authorization) request.getAttribute(HttpContext.AUTHORIZATION);
 		if (authorization == null) {// search by session ID
-			String httpSessionId = request.getSession().getId();
+			HttpSession httpSession = request.getSession(false);
+			if (httpSession == null) {
+				// TODO make sure this is always safe
+				if (log.isTraceEnabled())
+					log.trace("Create http session");
+				httpSession = request.getSession(true);
+			}
+			String httpSessionId = httpSession.getId();
 			// authorization = (Authorization)
 			// request.getSession().getAttribute(HttpContext.AUTHORIZATION);
 			// if (authorization == null) {
@@ -111,7 +120,7 @@ public class HttpSessionLoginModule implements LoginModule {
 		}
 
 		if (authorization != null) {
-			CmsAuthUtils.addAuthorization(subject, authorization, request);
+			CmsAuthUtils.addAuthorization(subject, authorization, request.getLocale(), request);
 			cleanUp();
 			return true;
 		} else {
@@ -167,6 +176,15 @@ public class HttpSessionLoginModule implements LoginModule {
 				}
 			}
 		}
+
+		// auth token
+//		String mail = request.getParameter(LdapAttrs.mail.name());
+//		String authPassword = request.getParameter(LdapAttrs.authPassword.name());
+//		if (authPassword != null) {
+//			sharedState.put(CmsAuthUtils.SHARED_STATE_PWD, authPassword);
+//			if (mail != null)
+//				sharedState.put(CmsAuthUtils.SHARED_STATE_NAME, mail);
+//		}
 	}
 
 	private X509Certificate[] extractClientCertificate(HttpServletRequest req) {