Don't create directory when requiring file. Improve unit test.

[gpl/argeo-slc.git] / runtime / org.argeo.slc.support.simple / src / main / java / org / argeo / slc / core / execution / FileExecutionResources.java

diff --git a/runtime/org.argeo.slc.support.simple/src/main/java/org/argeo/slc/core/execution/FileExecutionResources.java b/runtime/org.argeo.slc.support.simple/src/main/java/org/argeo/slc/core/execution/FileExecutionResources.java
index 316633a80decb1f50f548b22b6423fc04d2e1a74..e6530832ad7638ea7d41babadfe64363df49a4b9 100644 (file)
--- a/runtime/org.argeo.slc.support.simple/src/main/java/org/argeo/slc/core/execution/FileExecutionResources.java
+++ b/runtime/org.argeo.slc.support.simple/src/main/java/org/argeo/slc/core/execution/FileExecutionResources.java
@@ -53,7 +53,9 @@ public class FileExecutionResources implements ExecutionResources {
        public Resource getWritableResource(String relativePath) {
                File file = getFile(relativePath);
                File parentDir = file.getParentFile();
+
                if (!parentDir.exists()) {
+                       // Creates if necessary
                        if (log.isTraceEnabled())
                                log.trace("Creating parent directory " + parentDir);
                        parentDir.mkdirs();
@@ -72,13 +74,6 @@ public class FileExecutionResources implements ExecutionResources {
                                + executionContext.getUuid();
                File executionDir = new File(path);
 
-               // Creates if necessary
-               if (!executionDir.exists()) {
-                       if (log.isDebugEnabled())
-                               log.debug("Creating execution directory " + executionDir);
-                       executionDir.mkdirs();
-               }
-
                return new File(executionDir.getPath() + File.separator
                                + relativePath.replace('/', File.separatorChar));
        }