Fix ressource leak

[gpl/argeo-slc.git] / runtime / org.argeo.slc.core / src / main / java / org / argeo / slc / core / execution / ProcessThreadGroup.java

diff --git a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ProcessThreadGroup.java b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ProcessThreadGroup.java
index d7fa4f959eb45361d444b21e1ee08442a3322a1a..969c9b93fba5737c75ea723c601402f991b7d7d9 100644 (file)
--- a/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ProcessThreadGroup.java
+++ b/runtime/org.argeo.slc.core/src/main/java/org/argeo/slc/core/execution/ProcessThreadGroup.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2010 Mathieu Baudier <mbaudier@argeo.org>
+ * Copyright (C) 2007-2012 Argeo GmbH
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package org.argeo.slc.core.execution;
 
 import java.util.ArrayList;
@@ -24,13 +23,10 @@ import java.util.concurrent.BlockingQueue;
 import org.argeo.slc.execution.ExecutionModulesManager;
 import org.argeo.slc.execution.ExecutionProcess;
 import org.argeo.slc.execution.ExecutionStep;
-import org.argeo.slc.process.SlcExecution;
-import org.argeo.slc.process.SlcExecutionStep;
 import org.springframework.security.Authentication;
 import org.springframework.security.context.SecurityContextHolder;
 
 /** The thread group attached to a given {@link SlcExecution}. */
-@SuppressWarnings("deprecation")
 public class ProcessThreadGroup extends ThreadGroup {
        private final ExecutionModulesManager executionModulesManager;
        private final ProcessThread processThread;
@@ -55,14 +51,12 @@ public class ProcessThreadGroup extends ThreadGroup {
        }
 
        public void dispatchAddStep(ExecutionStep step) {
-               // legacy
                ExecutionProcess slcProcess = processThread.getProcess();
-               if (slcProcess instanceof SlcExecution)
-                       ((SlcExecution) slcProcess).getSteps().add((SlcExecutionStep) step);
-
                List<ExecutionStep> steps = new ArrayList<ExecutionStep>();
                steps.add(step);
+               // TODO clarify why we don't dispatch steps, must be a reason
                // dispatchAddSteps(steps);
+               slcProcess.addSteps(steps);
                this.steps.add(step);
        }