]> git.argeo.org Git - gpl/argeo-slc.git/blobdiff - plugins/org.argeo.slc.client.ui/src/main/java/org/argeo/slc/client/ui/views/JcrResultTreeView.java
+ Fix some bugs on ResultTree Observer
[gpl/argeo-slc.git] / plugins / org.argeo.slc.client.ui / src / main / java / org / argeo / slc / client / ui / views / JcrResultTreeView.java
index e1a5759eff3d92d3257a9998ad409893838e999d..57ea55eb645ecbcbf03c17e23fb3990e497976e8 100644 (file)
@@ -1,6 +1,5 @@
 package org.argeo.slc.client.ui.views;\r
 \r
-import java.awt.Window;\r
 import java.util.ArrayList;\r
 import java.util.Calendar;\r
 import java.util.List;\r
@@ -142,6 +141,8 @@ public class JcrResultTreeView extends ViewPart {
 \r
                sashForm.setWeights(getWeights());\r
 \r
+               resultTreeViewer.setInput(initializeResultTree());\r
+               // Initialize observer\r
                try {\r
                        ObservationManager observationManager = session.getWorkspace()\r
                                        .getObservationManager();\r
@@ -154,9 +155,6 @@ public class JcrResultTreeView extends ViewPart {
                } catch (RepositoryException e) {\r
                        throw new SlcException("Cannot register listeners", e);\r
                }\r
-\r
-               // Refresh the view to initialize it\r
-               refresh(null);\r
        }\r
 \r
        // The main tree viewer\r
@@ -308,8 +306,8 @@ public class JcrResultTreeView extends ViewPart {
         * \r
         */\r
        public void refresh(ResultParent resultParent) {\r
-               if (log.isDebugEnabled())\r
-                       log.debug("Refreshing '" + resultParent + "'...");\r
+               // if (log.isDebugEnabled())\r
+               // log.debug("Refreshing '" + resultParent + "'...");\r
                // Thread.dumpStack();\r
                if (resultParent == null) {\r
                        resultTreeViewer.setInput(initializeResultTree());\r
@@ -335,8 +333,9 @@ public class JcrResultTreeView extends ViewPart {
         * \r
         */\r
        public boolean jcrRefresh(Node node) {\r
-               if (log.isDebugEnabled())\r
-                       log.debug(" JCR refreshing " + node + "...");\r
+               // if (log.isDebugEnabled())\r
+               // log.debug(" JCR refreshing " + node + "...");\r
+               // Thread.dumpStack();\r
                boolean isPassed = true;\r
                try {\r
                        if (node.isNodeType(SlcTypes.SLC_TEST_RESULT)) {\r
@@ -368,56 +367,54 @@ public class JcrResultTreeView extends ViewPart {
 \r
        private ResultParent[] initializeResultTree() {\r
                try {\r
-                       if (session.nodeExists(SlcJcrResultUtils\r
-                                       .getSlcResultsBasePath(session))) {\r
-                               ResultParent[] roots = new ResultParent[5];\r
-\r
-                               // My results\r
-                               roots[0] = new ParentNodeFolder(null,\r
-                                               SlcJcrResultUtils.getMyResultParentNode(session),\r
-                                               SlcUiConstants.DEFAULT_MY_RESULTS_FOLDER_LABEL);\r
-\r
-                               // today\r
-                               Calendar cal = Calendar.getInstance();\r
-                               String relPath = JcrUtils.dateAsPath(cal);\r
-                               List<String> datePathes = new ArrayList<String>();\r
-                               datePathes.add(relPath);\r
-                               roots[1] = new VirtualFolder(null,\r
-                                               ResultParentUtils.getResultsForDates(session,\r
-                                                               datePathes), "Today");\r
-\r
-                               // Yesterday\r
-                               cal = Calendar.getInstance();\r
-                               cal.add(Calendar.DAY_OF_YEAR, -1);\r
+                       // Force initialization of the tree structure if needed\r
+                       SlcJcrResultUtils.getSlcResultsParentNode(session);\r
+                       SlcJcrResultUtils.getMyResultParentNode(session);\r
+                       ResultParent[] roots = new ResultParent[5];\r
+\r
+                       // My results\r
+                       roots[0] = new ParentNodeFolder(null,\r
+                                       SlcJcrResultUtils.getMyResultParentNode(session),\r
+                                       SlcUiConstants.DEFAULT_MY_RESULTS_FOLDER_LABEL);\r
+\r
+                       // today\r
+                       Calendar cal = Calendar.getInstance();\r
+                       String relPath = JcrUtils.dateAsPath(cal);\r
+                       List<String> datePathes = new ArrayList<String>();\r
+                       datePathes.add(relPath);\r
+                       roots[1] = new VirtualFolder(null,\r
+                                       ResultParentUtils.getResultsForDates(session, datePathes),\r
+                                       "Today");\r
+\r
+                       // Yesterday\r
+                       cal = Calendar.getInstance();\r
+                       cal.add(Calendar.DAY_OF_YEAR, -1);\r
+                       relPath = JcrUtils.dateAsPath(cal);\r
+                       datePathes = new ArrayList<String>();\r
+                       datePathes.add(relPath);\r
+                       roots[2] = new VirtualFolder(null,\r
+                                       ResultParentUtils.getResultsForDates(session, datePathes),\r
+                                       "Yesterday");\r
+                       // Last 7 days\r
+\r
+                       cal = Calendar.getInstance();\r
+                       datePathes = new ArrayList<String>();\r
+\r
+                       for (int i = 0; i < 7; i++) {\r
+                               cal.add(Calendar.DAY_OF_YEAR, -i);\r
                                relPath = JcrUtils.dateAsPath(cal);\r
-                               datePathes = new ArrayList<String>();\r
                                datePathes.add(relPath);\r
-                               roots[2] = new VirtualFolder(null,\r
-                                               ResultParentUtils.getResultsForDates(session,\r
-                                                               datePathes), "Yesterday");\r
-                               // Last 7 days\r
-\r
-                               cal = Calendar.getInstance();\r
-                               datePathes = new ArrayList<String>();\r
-\r
-                               for (int i = 0; i < 7; i++) {\r
-                                       cal.add(Calendar.DAY_OF_YEAR, -i);\r
-                                       relPath = JcrUtils.dateAsPath(cal);\r
-                                       datePathes.add(relPath);\r
-                               }\r
-                               roots[3] = new VirtualFolder(null,\r
-                                               ResultParentUtils.getResultsForDates(session,\r
-                                                               datePathes), "Last 7 days");\r
-\r
-                               // All results\r
-                               Node otherResultsPar = session.getNode(SlcJcrResultUtils\r
-                                               .getSlcResultsBasePath(session));\r
-                               roots[4] = new ParentNodeFolder(null, otherResultsPar,\r
-                                               "All results");\r
-                               return roots;\r
-                       } else\r
-                               // no test has yet been processed, we leave the viewer blank\r
-                               return null;\r
+                       }\r
+                       roots[3] = new VirtualFolder(null,\r
+                                       ResultParentUtils.getResultsForDates(session, datePathes),\r
+                                       "Last 7 days");\r
+\r
+                       // All results\r
+                       Node otherResultsPar = session.getNode(SlcJcrResultUtils\r
+                                       .getSlcResultsBasePath(session));\r
+                       roots[4] = new ParentNodeFolder(null, otherResultsPar,\r
+                                       "All results");\r
+                       return roots;\r
                } catch (RepositoryException re) {\r
                        throw new ArgeoException(\r
                                        "Unexpected error while initializing ResultTree.", re);\r
@@ -432,27 +429,27 @@ public class JcrResultTreeView extends ViewPart {
                IWorkbenchWindow window = ClientUiPlugin.getDefault().getWorkbench()\r
                                .getActiveWorkbenchWindow();\r
 \r
-               // Building conditions\r
                IStructuredSelection selection = (IStructuredSelection) resultTreeViewer\r
                                .getSelection();\r
                boolean canAddSubfolder = false;\r
+               boolean canRenamefolder = false;\r
                boolean isSingleResultNode = false;\r
+               // Building conditions\r
                if (selection.size() == 1) {\r
                        Object obj = selection.getFirstElement();\r
                        try {\r
-                               // if (obj instanceof ResultFolder\r
-                               // && (((ResultFolder) obj).getNode())\r
-                               // .isNodeType(SlcTypes.SLC_RESULT_FOLDER))\r
-                               if (isResultFolder)\r
-                                       canAddSubfolder = true;\r
-                               else if (obj instanceof SingleResultNode)\r
+                               if (obj instanceof SingleResultNode)\r
                                        isSingleResultNode = true;\r
-                               else if (obj instanceof ParentNodeFolder\r
-                                               && (((ParentNodeFolder) obj).getNode().getPath()\r
-                                                               .startsWith(SlcJcrResultUtils\r
-                                                                               .getMyResultsBasePath(session))))\r
-                                       canAddSubfolder = true;\r
-\r
+                               else if (obj instanceof ParentNodeFolder) {\r
+                                       Node cNode = ((ParentNodeFolder) obj).getNode();\r
+                                       if (cNode.isNodeType(SlcTypes.SLC_RESULT_FOLDER)) {\r
+                                               canAddSubfolder = true;\r
+                                               canRenamefolder = true;\r
+                                       } else if (cNode\r
+                                                       .isNodeType(SlcTypes.SLC_MY_RESULT_ROOT_FOLDER)) {\r
+                                               canAddSubfolder = true;\r
+                                       }\r
+                               }\r
                        } catch (RepositoryException re) {\r
                                throw new SlcException(\r
                                                "unexpected error while building condition for context menu",\r
@@ -468,7 +465,7 @@ public class JcrResultTreeView extends ViewPart {
 \r
                CommandUtils.refreshCommand(menuManager, window, RenameResultFolder.ID,\r
                                RenameResultFolder.DEFAULT_LABEL,\r
-                               RenameResultFolder.DEFAULT_IMG_DESCRIPTOR, canAddSubfolder);\r
+                               RenameResultFolder.DEFAULT_IMG_DESCRIPTOR, canRenamefolder);\r
 \r
                CommandUtils.refreshCommand(menuManager, window, RenameResultNode.ID,\r
                                RenameResultNode.DEFAULT_LABEL,\r
@@ -545,39 +542,41 @@ public class JcrResultTreeView extends ViewPart {
                @Override\r
                public boolean validateDrop(Object target, int operation,\r
                                TransferData transferType) {\r
-\r
                        boolean validDrop = false;\r
                        try {\r
                                // We can only drop under myResults\r
                                Node tpNode = null;\r
-                               if (target instanceof ResultFolder) {\r
+                               if (target instanceof SingleResultNode) {\r
+                                       Node currNode = ((SingleResultNode) target).getNode();\r
+                                       String pPath = currNode.getParent().getPath();\r
+                                       if (pPath.startsWith(SlcJcrResultUtils\r
+                                                       .getMyResultsBasePath(session)))\r
+                                               tpNode = currNode.getParent();\r
+                               } else if (target instanceof ResultFolder) {\r
                                        tpNode = ((ResultFolder) target).getNode();\r
                                } else if (target instanceof ParentNodeFolder) {\r
-                                       if ((((ParentNodeFolder) target).getNode().getPath()\r
-                                                       .startsWith(SlcJcrResultUtils\r
-                                                                       .getMyResultsBasePath(session))))\r
+                                       Node node = ((ParentNodeFolder) target).getNode();\r
+                                       if (node.isNodeType(SlcTypes.SLC_MY_RESULT_ROOT_FOLDER))\r
                                                tpNode = ((ParentNodeFolder) target).getNode();\r
-                               } else if (target instanceof SingleResultNode) {\r
-                                       Node currNode = ((SingleResultNode) target).getNode();\r
-                                       if (currNode\r
-                                                       .getParent()\r
-                                                       .getPath()\r
-                                                       .startsWith(\r
-                                                                       SlcJcrResultUtils\r
-                                                                                       .getMyResultsBasePath(session)))\r
-                                               tpNode = currNode.getParent();\r
                                }\r
 \r
                                if (tpNode != null) {\r
                                        // Sanity check : we cannot move a folder to one of its sub\r
+                                       // folder or neither move an object in the same parent\r
                                        // folder\r
                                        boolean doit = true;\r
+                                       Node source = null;\r
                                        if (isResultFolder) {\r
-                                               Node source = ((ParentNodeFolder) lastSelectedSourceElement)\r
+                                               source = ((ParentNodeFolder) lastSelectedSourceElement)\r
                                                                .getNode();\r
-                                               String sourcePath = source.getPath();\r
-                                               String targetPath = tpNode.getPath();\r
-                                               if (targetPath.startsWith(sourcePath))\r
+                                               if (tpNode.getPath().startsWith(source.getPath()))\r
+                                                       doit = false;\r
+                                       } else if (lastSelectedSourceElement instanceof SingleResultNode) {\r
+                                               source = ((SingleResultNode) lastSelectedSourceElement)\r
+                                                               .getNode();\r
+                                               String sourceParentPath = JcrUtils.parentPath(source\r
+                                                               .getPath());\r
+                                               if (tpNode.getPath().equals(sourceParentPath))\r
                                                        doit = false;\r
                                        }\r
                                        if (doit) {\r
@@ -586,7 +585,6 @@ public class JcrResultTreeView extends ViewPart {
                                                lastSelectedTargetElement = (ResultParent) target;\r
                                        }\r
                                }\r
-\r
                        } catch (RepositoryException re) {\r
                                throw new SlcException(\r
                                                "unexpected error while validating drop target", re);\r
@@ -616,7 +614,7 @@ public class JcrResultTreeView extends ViewPart {
                                                        name, targetParentNode);\r
                                        WizardDialog dialog = new WizardDialog(Display.getDefault()\r
                                                        .getActiveShell(), wizard);\r
-                                       \r
+\r
                                        if (dialog.open() == WizardDialog.CANCEL)\r
                                                return true;\r
 \r
@@ -671,40 +669,43 @@ public class JcrResultTreeView extends ViewPart {
 \r
                protected void onEventInUiThread(List<Event> events)\r
                                throws RepositoryException {\r
-                       int i = 0;\r
-\r
-                       for (Event event : events) {\r
-                               i++;\r
-                               // if (log.isDebugEnabled())\r
-                               // log.debug("Received event " + event);\r
-                               int eventType = event.getType();\r
-                               if (eventType == Event.NODE_REMOVED) {\r
-                                       String path = event.getPath();\r
-                                       String parPath = JcrUtils.parentPath(path);\r
-                                       if (session.nodeExists(parPath)) {\r
-                                               Node currNode = session.getNode(parPath);\r
-                                               if (currNode.isNodeType(NodeType.NT_UNSTRUCTURED)) {\r
-                                                       // jcrRefresh(currNode);\r
-                                                       refresh(lastSelectedSourceElementParent);\r
-                                               }\r
-                                       }\r
-                               } else if (eventType == Event.NODE_ADDED) {\r
-                                       // refresh(lastSelectedTargetElement);\r
-                                       String path = event.getPath();\r
-                                       if (session.nodeExists(path)) {\r
-                                               Node currNode = session.getNode(path);\r
-                                               if (currNode.isNodeType(SlcTypes.SLC_TEST_RESULT)\r
-                                                               || currNode\r
-                                                                               .isNodeType(SlcTypes.SLC_RESULT_FOLDER)) {\r
-                                                       refresh(lastSelectedTargetElement);\r
-                                                       // resultTreeViewer.expandToLevel(\r
-                                                       // lastSelectedTargetElement, 1);\r
-                                               }\r
-                                       }\r
-                               }\r
-                       }\r
-                       if (log.isDebugEnabled())\r
-                               log.debug("treated events: " + i);\r
+                       refresh(lastSelectedSourceElementParent);\r
+\r
+                       // boolean wasRemoved = false;\r
+                       // boolean wasAdded = false;\r
+                       //\r
+                       // for (Event event : events) {\r
+                       // // if (log.isDebugEnabled())\r
+                       // // log.debug("Received event " + event);\r
+                       // int eventType = event.getType();\r
+                       // if (eventType == Event.NODE_REMOVED) {\r
+                       // String path = event.getPath();\r
+                       // String parPath = JcrUtils.parentPath(path);\r
+                       // if (session.nodeExists(parPath)) {\r
+                       // Node currNode = session.getNode(parPath);\r
+                       // if (currNode.isNodeType(NodeType.NT_UNSTRUCTURED)) {\r
+                       // // jcrRefresh(currNode);\r
+                       // wasRemoved = true;\r
+                       // }\r
+                       // }\r
+                       // } else if (eventType == Event.NODE_ADDED) {\r
+                       // // refresh(lastSelectedTargetElement);\r
+                       // String path = event.getPath();\r
+                       // if (session.nodeExists(path)) {\r
+                       // Node currNode = session.getNode(path);\r
+                       // if (currNode.isNodeType(SlcTypes.SLC_TEST_RESULT)\r
+                       // || currNode\r
+                       // .isNodeType(SlcTypes.SLC_RESULT_FOLDER)) {\r
+                       // // refresh(lastSelectedTargetElement);\r
+                       // wasAdded = true;\r
+                       // // resultTreeViewer.expandToLevel(\r
+                       // // lastSelectedTargetElement, 1);\r
+                       // }\r
+                       // }\r
+                       // }\r
+                       // }\r
+                       // if (wasRemoved || wasAdded)\r
+                       // refresh(lastSelectedSourceElementParent);\r
                }\r
        }\r
 \r