]> git.argeo.org Git - lgpl/argeo-commons.git/blobdiff - org.argeo.security.core/src/org/argeo/osgi/useradmin/AbstractUserDirectory.java
Proper LDIF backend for deploy configs.
[lgpl/argeo-commons.git] / org.argeo.security.core / src / org / argeo / osgi / useradmin / AbstractUserDirectory.java
index 58eb41ca377f0d3254825960ef75a8ec9bebcc18..121fb3500480b955447d47fa2be0053e971d66c5 100644 (file)
@@ -26,7 +26,6 @@ import javax.naming.ldap.Rdn;
 import javax.transaction.SystemException;
 import javax.transaction.Transaction;
 import javax.transaction.TransactionManager;
-import javax.transaction.xa.Xid;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -40,8 +39,7 @@ import org.osgi.service.useradmin.UserAdmin;
 
 /** Base class for a {@link UserDirectory}. */
 abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
-       private final static Log log = LogFactory
-                       .getLog(AbstractUserDirectory.class);
+       private final static Log log = LogFactory.getLog(AbstractUserDirectory.class);
 
        private final Hashtable<String, Object> properties;
        private final String baseDn;
@@ -52,16 +50,14 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
        private final URI uri;
 
        private UserAdmin externalRoles;
-       private List<String> indexedUserProperties = Arrays.asList(new String[] {
-                       LdifName.uid.name(), LdifName.mail.name(), LdifName.cn.name() });
+       private List<String> indexedUserProperties = Arrays
+                       .asList(new String[] { LdifName.uid.name(), LdifName.mail.name(), LdifName.cn.name() });
 
        private String memberAttributeId = "member";
-       private List<String> credentialAttributeIds = Arrays
-                       .asList(new String[] { LdifName.userpassword.name() });
+       private List<String> credentialAttributeIds = Arrays.asList(new String[] { LdifName.userPassword.name() });
 
        private TransactionManager transactionManager;
-       private ThreadLocal<UserDirectoryWorkingCopy> workingCopy = new ThreadLocal<UserDirectoryWorkingCopy>();
-       private Xid editingTransactionXid = null;
+       private WcXaResource xaResource = new WcXaResource(this);
 
        AbstractUserDirectory(Dictionary<String, ?> props) {
                properties = new Hashtable<String, Object>();
@@ -77,16 +73,14 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                        try {
                                uri = new URI(uriStr);
                        } catch (URISyntaxException e) {
-                               throw new UserDirectoryException("Badly formatted URI "
-                                               + uriStr, e);
+                               throw new UserDirectoryException("Badly formatted URI " + uriStr, e);
                        }
 
                baseDn = UserAdminConf.baseDn.getValue(properties).toString();
                String readOnlyStr = UserAdminConf.readOnly.getValue(properties);
                if (readOnlyStr == null) {
                        readOnly = readOnlyDefault(uri);
-                       properties.put(UserAdminConf.readOnly.property(),
-                                       Boolean.toString(readOnly));
+                       properties.put(UserAdminConf.readOnly.name(), Boolean.toString(readOnly));
                } else
                        readOnly = new Boolean(readOnlyStr);
 
@@ -112,19 +106,13 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
        }
 
        boolean isEditing() {
-               if (editingTransactionXid == null)
-                       return false;
-               return workingCopy.get() != null;
+               return xaResource.wc() != null;
        }
 
        protected UserDirectoryWorkingCopy getWorkingCopy() {
-               UserDirectoryWorkingCopy wc = workingCopy.get();
+               UserDirectoryWorkingCopy wc = xaResource.wc();
                if (wc == null)
                        return null;
-               if (wc.getXid() == null) {
-                       workingCopy.set(null);
-                       return null;
-               }
                return wc;
        }
 
@@ -136,25 +124,14 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                        throw new UserDirectoryException("Cannot get transaction", e);
                }
                if (transaction == null)
-                       throw new UserDirectoryException(
-                                       "A transaction needs to be active in order to edit");
-               if (editingTransactionXid == null) {
-                       UserDirectoryWorkingCopy wc = new UserDirectoryWorkingCopy(this);
+                       throw new UserDirectoryException("A transaction needs to be active in order to edit");
+               if (xaResource.wc() == null) {
                        try {
-                               transaction.enlistResource(wc);
-                               editingTransactionXid = wc.getXid();
-                               workingCopy.set(wc);
+                               transaction.enlistResource(xaResource);
                        } catch (Exception e) {
-                               throw new UserDirectoryException("Cannot enlist " + wc, e);
+                               throw new UserDirectoryException("Cannot enlist " + xaResource, e);
                        }
                } else {
-                       if (workingCopy.get() == null)
-                               throw new UserDirectoryException("Transaction "
-                                               + editingTransactionXid + " already editing");
-                       else if (!editingTransactionXid.equals(workingCopy.get().getXid()))
-                               throw new UserDirectoryException("Working copy Xid "
-                                               + workingCopy.get().getXid() + " inconsistent with"
-                                               + editingTransactionXid);
                }
        }
 
@@ -225,8 +202,7 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
        @Override
        public User getUser(String key, String value) {
                // TODO check value null or empty
-               List<DirectoryUser> collectedUsers = new ArrayList<DirectoryUser>(
-                               getIndexedUserProperties().size());
+               List<DirectoryUser> collectedUsers = new ArrayList<DirectoryUser>(getIndexedUserProperties().size());
                if (key != null) {
                        doGetUser(key, value, collectedUsers);
                } else {
@@ -246,28 +222,23 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                if (collectedUsers.size() == 1)
                        return collectedUsers.get(0);
                else if (collectedUsers.size() > 1)
-                       log.warn(collectedUsers.size() + " users for "
-                                       + (key != null ? key + "=" : "") + value);
+                       log.warn(collectedUsers.size() + " users for " + (key != null ? key + "=" : "") + value);
                return null;
        }
 
-       protected void doGetUser(String key, String value,
-                       List<DirectoryUser> collectedUsers) {
+       protected void doGetUser(String key, String value, List<DirectoryUser> collectedUsers) {
                try {
-                       Filter f = FrameworkUtil.createFilter("(&(" + objectClass + "="
-                                       + getUserObjectClass() + ")(" + key + "=" + value + "))");
+                       Filter f = FrameworkUtil.createFilter("(" + key + "=" + value + ")");
                        List<DirectoryUser> users = doGetRoles(f);
                        collectedUsers.addAll(users);
                } catch (InvalidSyntaxException e) {
-                       throw new UserDirectoryException("Cannot get user with " + key
-                                       + "=" + value, e);
+                       throw new UserDirectoryException("Cannot get user with " + key + "=" + value, e);
                }
        }
 
        @Override
        public Authorization getAuthorization(User user) {
-               return new LdifAuthorization((DirectoryUser) user,
-                               getAllRoles((DirectoryUser) user));
+               return new LdifAuthorization((DirectoryUser) user, getAllRoles((DirectoryUser) user));
        }
 
        @Override
@@ -275,11 +246,10 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                checkEdit();
                UserDirectoryWorkingCopy wc = getWorkingCopy();
                LdapName dn = toDn(name);
-               if ((daoHasRole(dn) && !wc.getDeletedUsers().containsKey(dn))
-                               || wc.getNewUsers().containsKey(dn))
+               if ((daoHasRole(dn) && !wc.getDeletedUsers().containsKey(dn)) || wc.getNewUsers().containsKey(dn))
                        throw new UserDirectoryException("Already a role " + name);
-               BasicAttributes attrs = new BasicAttributes();
-               attrs.put("dn", dn.toString());
+               BasicAttributes attrs = new BasicAttributes(true);
+               // attrs.put(LdifName.dn.name(), dn.toString());
                Rdn nameRdn = dn.getRdn(dn.size() - 1);
                // TODO deal with multiple attr RDN
                attrs.put(nameRdn.getType(), nameRdn.getValue());
@@ -298,7 +268,7 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                LdifUser newRole;
                BasicAttribute objClass = new BasicAttribute(objectClass.name());
                if (type == Role.USER) {
-                       String userObjClass = getUserObjectClass();
+                       String userObjClass = newUserObjectClass(dn);
                        objClass.add(userObjClass);
                        if (inetOrgPerson.name().equals(userObjClass)) {
                                objClass.add(organizationalPerson.name());
@@ -306,12 +276,14 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                        } else if (organizationalPerson.name().equals(userObjClass)) {
                                objClass.add(person.name());
                        }
-                       objClass.add(top);
+                       objClass.add(top.name());
                        attrs.put(objClass);
                        newRole = new LdifUser(this, dn, attrs);
                } else if (type == Role.GROUP) {
-                       objClass.add(getGroupObjectClass());
-                       objClass.add(top);
+                       String groupObjClass = getGroupObjectClass();
+                       objClass.add(groupObjClass);
+                       // objClass.add(LdifName.extensibleObject.name());
+                       objClass.add(top.name());
                        attrs.put(objClass);
                        newRole = new LdifGroup(this, dn, attrs);
                } else
@@ -334,8 +306,7 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                }
                for (LdapName groupDn : getDirectGroups(dn)) {
                        DirectoryUser group = doGetRole(groupDn);
-                       group.getAttributes().get(getMemberAttributeId())
-                                       .remove(dn.toString());
+                       group.getAttributes().get(getMemberAttributeId()).remove(dn.toString());
                }
                return actuallyDeleted;
        }
@@ -353,10 +324,6 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
 
        }
 
-       void clearEditingTransactionXid() {
-               editingTransactionXid = null;
-       }
-
        // UTILITIES
        protected LdapName toDn(String name) {
                try {
@@ -367,7 +334,6 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
        }
 
        // GETTERS
-
        String getMemberAttributeId() {
                return memberAttributeId;
        }
@@ -413,10 +379,15 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                return baseDn;
        }
 
+       /** dn can be null, in that case a default should be returned. */
        protected String getUserObjectClass() {
                return userObjectClass;
        }
 
+       protected String newUserObjectClass(LdapName dn) {
+               return getUserObjectClass();
+       }
+
        protected String getGroupObjectClass() {
                return groupObjectClass;
        }
@@ -433,4 +404,8 @@ abstract class AbstractUserDirectory implements UserAdmin, UserDirectory {
                this.transactionManager = transactionManager;
        }
 
+       public WcXaResource getXaResource() {
+               return xaResource;
+       }
+
 }