enable better content type definition for the download file service

[lgpl/argeo-commons.git] / org.argeo.eclipse.ui.rap / src / org / argeo / eclipse / ui / specific / OpenFile.java

diff --git a/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java b/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java
index b55521b126d804b07ca2332f2600f9dda9bbae4d..409b96dedca031f97b5de91b4c54e8a654a1d24d 100644 (file)
--- a/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java
+++ b/org.argeo.eclipse.ui.rap/src/org/argeo/eclipse/ui/specific/OpenFile.java
@@ -24,19 +24,25 @@ import org.eclipse.rap.rwt.RWT;
 import org.eclipse.rap.rwt.client.service.UrlLauncher;
 
 /**
- * Rap specific command handler to open a file retrieved from the server. It
+ * RWT specific command handler to open a file retrieved from the server. It
  * forwards the request to the correct service after encoding file name and path
  * in the request URI.
  * 
+ * <p>
  * The parameter "URI" is used to determine the correct file service, the path
- * and the file name. An optional file name can be precised to present a
- * different file name as the one used to retrieve it to the end user/
+ * and the file name. An optional file name can be precized to present a
+ * different file name as the one used to retrieve it to the end user.
+ * </p>
  * 
+ * <p>
  * Various instances of this handler with different command ID might coexist in
  * order to provide context specific download service.
+ * </p>
  * 
+ * <p>
  * The instance specific service is called by its ID and must have been
  * externally created
+ * </p>
  */
 public class OpenFile extends AbstractHandler {
        private final static Log log = LogFactory.getLog(OpenFile.class);
@@ -51,7 +57,7 @@ public class OpenFile extends AbstractHandler {
                String fileName = event.getParameter(PARAM_FILE_NAME);
                String fileUri = event.getParameter(PARAM_FILE_URI);
 
-               // sanity check
+               // Sanity check
                if (fileUri == null || "".equals(fileUri.trim())
                                || openFileServiceId == null
                                || "".equals(openFileServiceId.trim()))
@@ -72,14 +78,6 @@ public class OpenFile extends AbstractHandler {
 
                UrlLauncher launcher = RWT.getClient().getService(UrlLauncher.class);
                launcher.openURL(downloadUrl);
-
-               // These lines are useless in the current use case but might be
-               // necessary with new browsers. Stored here for memo
-               // response.setContentType("application/force-download");
-               // response.setHeader("Content-Disposition", contentDisposition);
-               // response.setHeader("Content-Transfer-Encoding", "binary");
-               // response.setHeader("Pragma", "no-cache");
-               // response.setHeader("Cache-Control", "no-cache, must-revalidate");
                return null;
        }