Code cleaning

[lgpl/argeo-commons.git] / org.argeo.cms.ui.workbench / src / org / argeo / cms / ui / workbench / internal / jcr / SingleNodeAsTreeContentProvider.java

diff --git a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/SingleNodeAsTreeContentProvider.java b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/SingleNodeAsTreeContentProvider.java
index 558e35f4041cf19a047050ce10babe30ee447ec4..83ada24aafd6d3364831ed087a6a8a5eee7794ec 100644 (file)
--- a/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/SingleNodeAsTreeContentProvider.java
+++ b/org.argeo.cms.ui.workbench/src/org/argeo/cms/ui/workbench/internal/jcr/SingleNodeAsTreeContentProvider.java
@@ -46,15 +46,11 @@ public class SingleNodeAsTreeContentProvider implements ITreeContentProvider {
                        Node rootNode = (Node) inputElement;
                        List<Node> result = new ArrayList<Node>();
                        NodeIterator ni = rootNode.getNodes();
-                       while (ni.hasNext()) {
+                       while (ni.hasNext())
                                result.add(ni.nextNode());
-                       }
-
                        return result.toArray();
                } catch (RepositoryException re) {
-                       throw new EclipseUiException(
-                                       "Unexpected error while getting child nodes for children editor page ",
-                                       re);
+                       throw new EclipseUiException("Unable to retrieve elements for " + inputElement, re);
                }
        }
 
@@ -78,29 +74,27 @@ public class SingleNodeAsTreeContentProvider implements ITreeContentProvider {
                try {
                        return ((Node) element).hasNodes();
                } catch (RepositoryException e) {
-                       throw new EclipseUiException("Cannot check children of " + element, e);
+                       throw new EclipseUiException("Cannot check children existence on " + element, e);
                }
        }
 
-       public void dispose() {
-       }
-
-       public void inputChanged(Viewer viewer, Object oldInput, Object newInput) {
-       }
-
        protected Object[] childrenNodes(Node parentNode) {
                try {
                        List<Node> children = new ArrayList<Node>();
                        NodeIterator nit = parentNode.getNodes();
-                       while (nit.hasNext()) {
-                               Node node = nit.nextNode();
-                               children.add(node);
-                       }
-                       Node[] arr = children.toArray(new Node[children.size()]);
+                       while (nit.hasNext())
+                               children.add(nit.nextNode());
+                       Node[] arr = children.toArray(new Node[0]);
                        Arrays.sort(arr, itemComparator);
                        return arr;
                } catch (RepositoryException e) {
                        throw new EclipseUiException("Cannot list children of " + parentNode, e);
                }
        }
+
+       public void dispose() {
+       }
+
+       public void inputChanged(Viewer viewer, Object oldInput, Object newInput) {
+       }
 }